[Resolved] Array imploding with blank values

tomandhannah

<?
$author = $row['author'];
$publisher = $row['publisher'];

$arr = array($author,$publisher);
$imploded = implode(", ", $arr);
echo $imploded;

?>

In the code above, I'm getting author and publisher information from a database, but I want to combine them (comma separated).

They are not required fields. So, some rows will have both, or only one. However, PHP is still printing the comma if both fields are empty, OR if only one field has data. So, the output often looks like this:

row1: Author,
row2: Author, Publisher <--correct
row3: ,
row4: , Publisher

Ideally, the output should look like this:

row1: Author
row2: Author, Publisher
row3:
row4: Publisher

Why is my array printing like this? How can I fix it without adding count($arr) and building IF statements? There must be a simple solution...

bubblenut

<?
$arr=array();
if(!empty($row['author']))
  array_push($arr,$row['author']);
if(!empty($row['publisher']))
  array_push($arr,$row['publisher']);

$imploded = implode(", ", $arr);
echo $imploded;

?>

Is that the sort of thing you want. I think there may be a more efficient way of doing that but I'm not sure.
HTH
Bubble

tomandhannah

Well, yes... that does accomplish it, (and much more concise than what I had in mind! 🙂 ) but I was looking for something even more efficient. Wishful thinking? I would think it could be done without adding 4 lines of code.

bubblenut

Well actually, we know that both $row['author'] and $row['publisher'] will always be set, the only issue is whether or not they have any data in them, therefore prehapse empty() is a little overkill, !='' will always provide the same result with no warnings. Also, regarding the asthetics, you said you wanted it more concise (I'm probably going to get flamed for this, but the logic is simple so I don't think it's so bad) we can change the ifs for ternary operators. The result of these two changes is as follows.

$arr=array();

$row['author']!=''?array_push($arr,$row['author']):'';
$row['publisher']!=''?array_push($arr,$row['publisher']):'';

$imploded = implode(', ', $arr);
echo$imploded;

NB The the speed ganed by this going to be virtually nill, if optimization is the aim then look at more serious bottleknecks such as DB and file access. It is rare that program logic is what's actuall slowing a script.
HTH
Bubble

tomandhannah

Thanks for your advice... and help!