hi i need help with this function

[har_dick]

I posted this on the other forum, but I couldn't quite understand and solve the problem.

I am pretty new at managing and building functions, i'm kinda beginning to understand how they work.

this is a function inside a php script:

<?
function submit_final($filename,$image,$stars,$plot,$poster)
{

// from here this was a php file called submitfinal.php now it's part of this function

$date = date("M d, Y");

$conn = db_connect();

$time = time();

$sql = "insert into imagesdb (filename, image, stars, plot, poster) values ('$filename', '$image', '$stars', '$plot', '$poster')";

$result = mysql_query($sql,$conn);

if (!$result) {
print "Error on database while executing<PRE>$sql</PRE>";
print mysql_error();
exit;
}

if ($poster_name != "")
{    
	move_uploaded_file("$poster", "/home/wwsite/public_html/images/images/$poster_name") or die("Couldn't Upload Your File.");

} else {

	die("You haven't uploaded any file!");
}

if (!$story)
{
	$story = mysql_insert_id();

$sql = "update imagesdb set poster = '$poster_name' where id = $story";
$result = mysql_query($sql,$conn);

}
}
?>

I had this code working in a separate file, along with its upload form and it worked perfectly, but now that I joined them both as functions in a single file, I get the following error:

Warning: Missing argument 1 for submit_final() in /home/tucuadre/public_html/test/functions.php on line 339

Warning: Missing argument 2 for submit_final() in /home/tucuadre/public_html/test/functions.php on line 339

Warning: Missing argument 3 for submit_final() in /home/tucuadre/public_html/test/functions.php on line 339

Warning: Missing argument 4 for submit_final() in /home/tucuadre/public_html/test/functions.php on line 339

Warning: Missing argument 5 for submit_final() in /home/tucuadre/public_html/test/functions.php on line 339
You haven't uploaded any file!

As a result, there is no insersion on the database and no image is uploaded.

As I said before, what surprises me the most is that the code outside the function worked perfectly.

I call the function at another file as follows:

<?php
include('variablesmov.php');
include('functions.php');

submit_final();
?>

the form is a normal form

<?php 

function createimage()
{
// etc....
}
<input type="hidden" name="MAX_FILE_SIZE" value="300000">
<input type="file" name="poster">
<input type="submit" value="Enviar" name="submit2">
<?php
}
?>

i'd appreciate any help because i've had a couple of days strugling with this code.

[lilleman]

You have to pass the values as arguments to the function.

<?php
include('variablesmov.php');
include('functions.php');

$filename = 'test.php';
$image = 'hello.gif';
$stars = 4;
$plot = 'a murderer';
$poster = 'me';

submit_final($filename, $image, $stars, $plot, $poster);
?>

A function cannot access variables that have been declared outside of the function if you don't declare them as global in the function. Here is an example of a code that will not work...

<?php

function foo()
{
  $bar .= ' John';
}

$bar = 'Hello';
foo();

echo $bar; // prints "Hello"

?>

As i said before, there are two ways of manipulating variables; you can either pass them as arguments or declare them global. Here is an example of how to pass a value as an argument.

<?php

function foo($bar)
{
  return $bar . ' John';
}

$bar = 'Hello';
$bar = foo($bar);

echo $bar; // prints "Hello John"

?>

And now, here is an example of how to declare a variable as global.

<?php

function foo()
{
  global $bar;
  $bar .= ' John';
}

$bar = 'Hello';
foo();

echo $bar; // prints "Hello John"

?>

I hope that this makes at least a little sense to you... 🙂

[Barb54]

I have been looking for help on understanding functions as well. I finally found a great article at the Zend website today under the Tutorials link. I read it and all of a sudden it "clicked" I think, lol.

Now I will be using functions quite a lot I think. This is the kind of programming I learned so many years ago and just makes more since to me.

Actually from what I saw, this is the "real" means by which you can separate your html from your php/sql. I looked at Smarty for templating and it took playing around with 3-4 files just to get one page lol. With functions you create your functions file then include it with your page, then call it where you want it on that same page. Sheesh I LOVE it, lol. I may just get the hang of this after all, lmbo.

OK OK I'll stop rambling, lol.

Hope that helps ya out.
Barb