x3 upload form processing, optimising code

[bluns]

  $picture1=$_FILES['picture1']['tmp_name'];
  $picture1_name=$_FILES['picture1']['name'];
  $picture1_size=$_FILES['picture1']['size'];
  $picture1_type=$_FILES['picture1']['type'];
  $picture1_error=$_FILES['picture1']['error'];

 $picture2=$_FILES['picture2']['tmp_name'];
  $picture2_name=$_FILES['picture2']['name'];
  $picture2_size=$_FILES['picture2']['size'];
  $picture2_type=$_FILES['picture2']['type'];
  $picture2_error=$_FILES['picture2']['error']; 

  $picture3=$_FILES['picture3']['tmp_name'];
  $picture3_name=$_FILES['picture3']['name'];
  $picture3_size=$_FILES['picture3']['size'];
  $picture3_type=$_FILES['picture3']['type'];
  $picture3_error=$_FILES['picture3']['error'];  

  $comments=$_POST['comments'];

  //check picture1 uploading errors
  if ($picture1_error >0)
  {
   echo 'Problem: ';
   switch ($picture1_error)
   {
   case 1: echo 'File exceeded upload_max_filesize'; break;
   case 2: echo 'File exceeded max_file_size'; break;
   case 3: echo 'File only partially uploaded'; break;
   case 4: echo 'No file uploaded'; break;
   }
   exit;
  }

//check picture2 uploading errors
  if ($picture2_error >0)
  {
   echo 'Problem: ';
   switch ($picture2_error)
   {
   case 1: echo 'File exceeded upload_max_filesize'; break;
   case 2: echo 'File exceeded max_file_size'; break;
   case 3: echo 'File only partially uploaded'; break;
   case 4: echo 'No file uploaded'; break;
   }
   exit;
  }

//check picture3 uploading errors
  if ($picture3_error >0)
  {
   echo 'Problem: ';
   switch ($picture3_error)
   {
   case 1: echo 'File exceeded upload_max_filesize'; break;
   case 2: echo 'File exceeded max_file_size'; break;
   case 3: echo 'File only partially uploaded'; break;
   case 4: echo 'No file uploaded'; break;
   }
   exit;
  }

  //check picture1 MIME type
  if ($picture1_type != 'image/gif')
  {
  echo 'Problem: File must be an image';
  exit;
  }

  //check picture2 MIME type
  if ($picture2_type != 'image/gif')
  {
  echo 'Problem: File must be an image';
  exit;
  }

  //check picture3 MIME type
  if ($picture3_type != 'image/gif')
  {
  echo 'Problem: File must be an image';
  exit;
  }


  // where to upload picture1
  $upfile1 = '../images/uploads/'.$picture1_name;

  if(is_uploaded_file($picture1))
  {
   if (!move_uploaded_file($picture1, $upfile1))
   {
  echo 'Could not move file to destination directory';
  exit;
   }
  }
  else
  {
  echo 'Possible file upload attack. Filename: '.$picture1_name;
  exit;
  }

  // where to upload picture2
  $upfile2 = '../images/uploads/'.$picture2_name;

  if(is_uploaded_file($picture2))
  {
   if (!move_uploaded_file($picture2, $upfile2))
   {
  echo 'Could not move file to destination directory';
  exit;
   }
  }
  else
  {
  echo 'Possible file upload attack. Filename: '.$picture2_name;
  exit;
  }

  // where to upload picture3
  $upfile3 = '../images/uploads/'.$picture3_name;

  if(is_uploaded_file($picture3))
  {
   if (!move_uploaded_file($picture3, $upfile3))
   {
  echo 'Could not move file to destination directory';
  exit;
   }
  }
  else
  {
  echo 'Possible file upload attack. Filename: '.$picture3_name;
  exit;
  }

  echo 'Files uploaded successfully';

  //reformat picture1 contents
  $fp = fopen($upfile1, 'r');
  $contents=fread($fp, filesize ($upfile1));
  fclose ($fp);

  $contents = strip_tags($contents1);
  $fp = fopen($upfile1, 'w');
  fwrite ($fp, $contents);
  fclose ($fp);

  //reformat picture2 contents
  $fp = fopen($upfile2, 'r');
  $contents=fread($fp, filesize ($upfile2));
  fclose ($fp);

  $contents = strip_tags($contents2);
  $fp = fopen($upfile2, 'w');
  fwrite ($fp, $contents2);
  fclose ($fp);

  //reformat picture1 contents
  $fp = fopen($upfile3, 'r');
  $contents=fread($fp, filesize ($upfile3));
  fclose ($fp);

  $contents = strip_tags($contents3);
  $fp = fopen($upfile3, 'w');
  fwrite ($fp, $contents3);
  fclose ($fp);

All it does is processes 3 different upload forms, copy/pasted upload processing script 3 times changing the variables slightly

Im sure there is a better way outside of my skill scope 😉

[Moonglobe]

what with only allowing .gif files? what about png and jpeg?

[bluns]

Originally posted by Moonglobe
what with only allowing .gif files? what about png and jpeg?

http://www.phpbuilder.com/board/showthread.php?s=&threadid=10270963 😉

Already working fixing that problem i can always do that in the future 🙂

I just think i am using way too much lines of code and it could be optimised better

[Weedpacket]

Using arrays instead of variables would make it a lot easier to put the repeated parts in loops, and also allow arbitrary numbers of files.