[Resolved] Array Skipping First Value in Processing

[OctoberAsh]

I'm using a table that stores metadata about other tables in the db, and I want to pull out a comma-separated string to use in an INSERT query as well as create variables out of it, pre-pending "$" in front of each part of the array.

Problem One: Ignoring First Element
The query looks like this:

$element_list = "Select tblFieldName from tblTables where tblNumber = 2 AND tblGroup='AD'";

Then I wrote a function to implode the result for use in the INSERT statement:

function array_sql_list($resultset, $rowcount, $fieldname) {
if ($rowcount > 0)
{
	while ($column = mysql_fetch_object($resultset))
	{
	$row_names[] = $column->$fieldname;
	}
	$row_names = implode(", ",$row_names);
	return $row_names;

} elseif ($rowcount < 1) {
	echo "Nothing to add";
	}
}

It's not the prettiest thing in the world, but it does work...kinda. The problem is that it's returning 23 of the 24 fields, ignoring the first element of the result. Can anyone recommend a better way to do this so that the result captures all elements?

Problem Two: Prepending "$"
Actually, two sub-issues in one.

The first is that I'm using the same result set as above, but on sending it through a loop to prepend the "$", it tells me that the result set is no longer an array. I tried to reset() the array (thinking that the pointer was stuck on the last element from the first loop through), but that didn't work. I know it's an array because it worked the first time through, but arguing with the keyboard isn't getting me anywhere.

The second issue is that prepending the "$" to each result, then imploding them into a comma-separated list isn't working at all. I want to write a function to prepend the "$", then implode the result - is there a better way to accomplish this?

Thanks in advance for any suggestions,

[OctoberAsh]

No luck with the first part, but for the second part, I wrote a function

function array_sql_varlist($resultset) 
{
$varlist = array();
	{
	while ($row = mysql_fetch_row($resultset))
		{
			foreach ($row as $value)
				{
					$new_value = "$" . $value;
					$new_array = array_push($varlist,$new_value);
				}
		}
	}
return $new_array;
}

The frustrating part is that it's working, but not returning an array. Instead, it's returning the number of elements in the resulting array. Not sure why - any assistance would be greatly appreciated.

[swr]

Read the [man]array_push[/man] manual page; the number of elements is exactly what you should be getting with the way you are using it. You probably just want to return $varlist.

As for skipping the first element in the array... Not sure what is going on there. Try reset($row_names) before doing the implode, and/or $row_names = array() at the start of the function.

[OctoberAsh]

You probably just want to return $varlist.

Yup, that worked - I must've confused the array_push() use with its final output.

I rewrote both functions thusly:

function make_field_list($resultset)
{
$varlist = array();
	{
	while ($row = mysql_fetch_row($resultset))
		{
			foreach ($row as $value)
				{
					$pushval = array_push($varlist,$value);
				}
		}

}
return $varlist;	
}

and

function make_variable_list($resultset) 
{
$varlist = array();
	{
	while ($row = mysql_fetch_row($resultset))
		{
			foreach ($row as $value)
				{
					$new_value = "$" . $value;
					$new_array = array_push($varlist,$new_value);
				}
		}
	}
return $varlist;
}

Now they both function, but both still have the missing first element problem. I've gone back and looked at the query results, and I know they both contain 24 elements but only display 23 of them. I've also determined that the first element is the one that's missing in both cases.

I've tried reset()s in various places within both functions, but it didn't bring in that first element.

Thanks for your help so far, swr.

[swr]

The missing first element is very odd. The code you've posted looks like it should work. My guess is, the first element is going away because of something else, elsewhere in the code.

Maybe you've got a for loop somewhere that starts at 1 instead of 0?

[OctoberAsh]

I'm reviewing the code now, but there isn't anything being done to the query results before this step - no for loops, etc. Here's a brief rundown of the relevent code - the rest is a series of $HTTP_POST_VAR assignments from the form:

//Query to derive the fieldnames
$var_list = "Select tblFieldName from tblTables where tblNumber = 2 AND tblGroup='AD' ORDER BY tblSortOrder";
$var_result = mysql_query($var_list);

//Send the resultset to the function, then implode()
$variablelist = make_variable_list($var_result);
$imploded_variables = implode(", ",$variablelist);

//Function to take ($var_result) and create the variable list
function make_variable_list($resultset) 
{
$varlist = array();
	{
	while ($row = mysql_fetch_row($resultset))
		{
			foreach ($row as $value)
				{
					$new_value = "$" . $value;
					$new_array = array_push($varlist,$new_value);
				}
		}
	}
return $varlist;
}

//Take that result and build an INSERT query from it
$updqry_AddPractice="INSERT INTO tblPractice (" . $imploded_fields . ") VALUES (" . $imploded_variables . ")";

The page is a handler for a form that adds clients to a database, if that helps any. It's really strange - it looks like it should work, but no dice so far.

Thanks again!

[OctoberAsh]

I figured it out - I had an extra "fetch" inserted below the original sql query to determine the affected rows, and it was eating the first element of each array. 🙁

Thanks for your input!