FTP upload

[MrCool]

I tried to create a form where people upload a file to the FTP server, but doesn t seem to work. why?

$user="MrCool";
include("dbconnect.php");
$continue = 1;
if(empty($_POST[name])){
print("<p>A name for the file? Would that be a good idea?</p>");
$continue=0;
}
if(empty($_POST[description])){
print("<p>A description for the file? Would that be a good idea?</p>");
$continue=0;
}
if(empty($_POST[select])){
print("<p>A category for the file? Would that be a good idea?</p>");
$continue=0;
}
if(empty($_POST[private])){
$private = 0;
}
else
{
$private = 1;
}
print("$_POST[name] $_POST[description] $_POST[select] $_POST[private]");
if($_FILES['userfile']['size']<"1") {
print("You forgot to choose a file! Suffer from Alzhaimer or what?");
} else {
$file = $_FILES['userfile']['name'];
$size = $_FILES['userfile']['size'];
$type = $_FILES['userfile']['type'];
echo $filename;
$fileName = $_FILES['userfile']['name'];
$imgLocation = str_replace("\\","/", $fileName); 
/* '\\' represent '\' */
echo $imgLocation;
}
//separation
$sqll="SELECT status FROM users WHERE username = '$user' LIMIT 1"; 
$status=mysql_query($sqll, $db); 
$row=mysql_fetch_array($status); 
print $roww[status]; 
$question="SELECT * FROM ftp WHERE status='$row[status]' LIMIT 1";
$codes=mysql_query($question,$db);
$line=mysql_fetch_array($codes); 
$username=$line[username];
$password=$line[password];
//separation
$filename="ftp_server.txt"; 
$maxdigits= "15";
$file = fopen($filename, "r"); 
$content = fread( $file,$maxdigits); 
fclose($file); 
#and at last we let counter to show count of visits to this page to requesting user. 
echo "<p><a href=\"ftp://".$line[username].":".$line[password]."@$content\">$content</a></p>";
if($private==1){
$firstpart="/Admin/";
} else {
$firstpart="/Members/upload/";
}
$uploaddir = $content.$firstpart.$_POST[select]."/";
$uploadfile = $uploaddir . $_FILES['userfile']['name'];
print("<br>");
$ftp_server = $content;
$ftp_user = $line[username];
$ftp_pass = $line[password];
// set up a connection or die
$conn_id = ftp_connect($ftp_server) or die("Couldn't connect to $ftp_server. Connection died"); 
// try to login
if (@ftp_login($conn_id, $ftp_user, $ftp_pass)) {
   echo "Connected as $ftp_user@$ftp_server<br>";
} else {
   echo "Couldn't connect as $ftp_user\n";
}
//echo "$uploaddir";
echo "$uploadfile";
//if (move_uploaded_file($_FILES['userfile']['tmp_name'], $uploadfile)) {
 //print "File is valid, and was successfully uploaded. ";
//print "Here's some more debugging info:\n";
//print_r($_FILES);
//} else {
  // print "Possible file upload attack!  Here's some debugging info:\n";
  //print_r($_FILES);
//}
if (ftp_put($conn_id, $_FILES['userfile']['tmp_name'], $uploadfile, FTP_ASCII)) {
 echo "successfully uploaded $file\n";
} else {
 echo "There was a problem while uploading $uploadfile\n";
}
ftp_close($conn_id);  

[AstroTeg]

You almost had it - but you commented it out: "//if (move_uploaded_file($_FILES['userfile']['tmp_name'
], $uploadfile))"

That will be your key.

From looking at your code, you attempt to initiate an FTP connection with a server that appears to be named in "ftp_server.txt". I'm not sure what you have in this file and who you're trying to connect to.

Regardless, because you don't have [man]move_uploaded_file[/man] executing, the uploaded file gets transferred via HTTP (very important to know) and gets saved in the server's temp directory. The best way to get to this file is by using [man]move_uploaded_file[/man] and save it to a location within your web site/directory. Then if you still wish you want to do FTP with another FTP server (another important key), you have the file physically available to do so.

You do know most users do NOT run an FTP server. Without an FTP server, you can not have your web server talk to their computer and get the file.