God I'm so frustrated with this.

Kinsbane

Could someone please take a look at the below page and offer ideas on what's wrong? I have no idea what's going on. When you first go, it claims there's an undefined variable: action on line 11. No clue why - it's never done this before. Then, if you wanna upload something, it just goes to a blank page - its never done this either. :mad: 😕 :mad: 😕

http://www.kinsbane.kicks-ass.net/upload.php

here's two bits of code dealing with what's wrong (that I can't fix):

10
11 switch($action) {
12 default:
13 echo "

The linking system is set up so it's all in one page, you wanna do uploads the link says upload.php?action=upload and it takes you to where you can upload. when the upload is done, you're supposed to be able to view the pic you just uploaded - and the link looks like upload.php?action=doupload. So, that's where the $action variable is - i dont know why it wont take it.

Also, the files wont even upload - gives me an error that a variable is undefined and, according to my script, that I didnt even browse for a file, when I did!

here's the error:
Notice: Undefined variable: filer in c:\program files\apache group\apache\htdocs\upload.php on line 256
Must select file to upload!

here's the code for that:

250 case "doupload":
251 $dbh=mysql_connect ('localhost', 'e_novative', 'e_novative') or die ('I cannot connect to the database because: ' . mysql_error());
252 mysql_select_db ('uploads'); 
253 if(isset($_GET['file'])) $filer=$_GET['file'];
254
255 $dir = "dir";
256 if ($filer!="") {

Someone help. I'm at my wit's end. 🙁

Weedpacket

Sounds like a subject for another thread, but the short answer is that you need to make sure that a variable exists before you start using it; if a form field is empty when the form is submitted, it won't be represented in the array.

Tekime

Noticing a few things:

<form method=POST action=upload.php?action=doupload enctype=multipart/form-data>

Is submitting the form elements via POST, but the upload.php?action=doupload is submitting the 'action' variable via GET.

You are also checking for $GET['file'], when you should probably be checking for $POST['file'].

Kinsbane

Originally posted by Weedpacket
Sounds like a subject for another thread, but the short answer is that you need to make sure that a variable exists before you start using it; if a form field is empty when the form is submitted, it won't be represented in the array.

See that's the thing, though. Here's an example I did for my band's website, www.darwenstheory.net - here's the main page when somone first gets to it:

switch ($s) {
default:
include ('news.php');
break;
case "band": 
include ('band.php');
break;
case "media":
include ('media.php');
break; 
case "shows":
include ('shows.php');
break; 
case "contact":
include ('contact.php');
break;
case "showgig":
include ('showgig.php');
break;
case "showpic":
include ('showpic.php');
break;
case "showvid":
include ('showvid.php');
break;
}

That's never told me there's been an undefined variable s before - ive never had a problem with that code. You can try to upload stuff yourself; if you try to upload, you'll get the same error I do - it says I need to select a file to upload, when I clearly did! I dunno what's going on.

Tekime - I just tried that and it doesn't work. 🙁

Kinsbane

I just took out the line
if(isset($GET['file'])) $filer=$GET['file'];

and instead of

if ($filer!="") {

I put in
if(isset($file) && $file != "")

and now when i try to upload, I get a blank page.

what the heck is going on? 🙁

Weedpacket

Originally posted by Kinsbane
See that's the thing, though. Here's an example I did for my band's website,

Seems as though the post I was replying to has been moved to another thread 🙂 - that or it's been deleted.