[Resolved] Logic Flow Problems

[degauss]

Well, that's the easiest way I can describe it.

I have a block of code that checks to see whether feet, miles or inches are greater than 0.

$inches = $winnerArray["points"]/72;
				$feet =  $inches/12;
				$miles = $feet/5280;
				print "I:".$inches."<br />F:".$feet."<br />M:".$miles."<br />";
				if ($inches > 0 && $feet > 0 && $miles > 0) {
					$points = number_format($miles,2,".","")." Miles";
				} elseif ($inches > 0 && $feet > 0 && $miles < 0) {
					$points = number_format($feet,2,".","")." Feet";
				} elseif ($inches > 0 && $feet < 0 && $miles < 0) {
					$points = number_format($inches,2,".","")." Inches";
				}

Sample numbers would be something like the following:

Inches: 145.63888888889
Feet: 12.136574074074
Miles: 0.0022985935746352

No matter what happens, The loop always comes out with the Miles part.

Now, I'm probably stupidly tired, but I can't see anything wrong with the code above, but it just always comes out as miles.

Your help is appreciated.

[swr]

If $winnerArray["points"] is > 0, then $inches $feet and $miles will also be > 0, if only slightly.

Maybe you want to compare to 1 instead?

[degauss]

Sorry, should have specified this, but in each case $winnerArray["points"] is always greater than 0.

/edit

Erk, sorry, didn't read your post properly.

Whilst $winnerArray["points"] is always 0, $miles could be less than 0 because of the way the points are converted into inches, feet and miles.

[swr]

Originally posted by degauss
Whilst $winnerArray["points"] is always 0, $miles could be less than 0 because of the way the points are converted into inches, feet and miles. [/B]

Huh? If $winnerArray["points"] is non-negative, and you're only dividing by positive numbers, how could you possibly end up with a negative number?

Certainly you can end up with a really really small number, but it would still not be negative.

[degauss]

Okay, last night I wasn't making much sense, but here we go with example time:

Bob has 1000 points. so $winnerArray["points"] is now 1000.

If you look at the code example in the first post, I'm now dividing this 1000 points by 72 to get inches.

$inches = 1000 ($winnerArray["points"]) /72
so now $inches would be around 13.

$feet is how many inches are in a foot. Because we have 13 in $inches, and there are 12 inches in a foot, we have 1.1 feet...

Do you see what I'm getting at?

In this instance, both $inches and $feet will be greater than 0, but $miles (5280 feet in a mile) will be less than 0, so it should logically go into the second if..else statement and set $points to be number_format.... ." Feet"

[nemonoman]

inches feet and miles will always be greater than 0 if points>0

$inches = $winnerArray["points"]/72;
$feet = $inches/12;
$miles = $feet/5280;

You haven't rounded these off to the nearest integer or anything like

if there is 1 point(1/72 of an inch for the non-typesetters here), that equates to .0000000000000something miles, with is definitely more than 0 miles.

Either compare to > 1, as was suggested, or round off, or do some modulo arithmetic and calculate each part of the measurement separately.

Just get over the idea that a point divided by 72125280 somehow equals 0.

[nemonoman]

if ( $miles >= 1) {
                    $points = number_format($miles,2,".","")." Miles";
                } elseif ( $feet >=1 ) {
                    $points = number_format($feet,2,".","")." Feet";
                } else {
                    $points = number_format($inches,2,".","")." Inches";
                }

[degauss]

Damn, yes, you're both right.

There was nothing wrong with the loops, just my basic math skills 😃

Thanks for helping me, I appreciate it!