[Resolved] Linking from result to detail page

Kyrst

Here is the code to the page that pulls up the main query:


include('connect.php');

$sql = 'SELECT `track_name` , `track_artist` , `track_vol` , `track_id` '
        . ' FROM `track` '
        . ' WHERE 1  '
        . ' ORDER BY `track_name` ASC';

$res = mysql_query($sql);

<center><table width=100% cellpadding="1" cellspacing="1">
<tr><td align=left valign=top width=45% class=th>Track Title</td><td align=left valign=top width=45% class=th>Track Artist</td><td align=right valign=top class=th>Volume</td></tr>

   

function myquery ($query) {
       $result = mysql_query($query);
       if (mysql_errno())
           echo "MySQL error ".mysql_errno().": ".mysql_error()."\n<br>When executing:<br>\n$query\n<br>";
       return $result;
   } 
while($track = mysql_fetch_array($res)) {
$id = $track['track_id'];
$name = $track['track_name'];
$artist = $track['track_artist'];
$volume = $track['track_vol'];
  echo "
<TR>
<td align=left><a href='details.php?id=" . $track["track_id"] . "'>".$track['track_name']."</a></td>
<td align=left>".$track['track_artist']."</td>
<td align=right>".$track['track_vol']."</td>
         </tr>"; 
}

now here is the code to the details.php (which is where I get the following error, also bolded in the code):

Warning: mysql_fetch_array(): supplied argument is not a valid MySQL result resource in /home/designo/public_html/musiclib/details.php on line 24

include('connect.php');
$query = mysql_query("SELECT * FROM track WHERE id='" . $_GET['id'] . "'");

   

function myquery ($query) {
       $result = mysql_query($query);
       if (mysql_errno())
           echo "MySQL error ".mysql_errno().": ".mysql_error()."\n<br>When executing:<br>\n$query\n<br>";
       return $result;
[B]}[/B]
while($track = mysql_fetch_array($res)) {
$id = $track['track_id'];
$name = $track['track_name'];
$album = $track['track_album'];
$year = $track['track_year'];
$volume = $track['track_writer'];
$lyric = $track['track_lyric'];

echo "<TR><td align=left>".$track['track_name']."</td></tr>"; 
echo "<TR><td align=left>".$track['track_album']." - ".$track['track_year']."</td></tr>";
echo "<TR><td align=right>".$track['track_writer']."</td></tr>";
echo "<TR><td align=right>".$track['track_lyric']."</td></tr>";
}

</table></center>

If someone could lead me to where I am going wrong on this I would be grateful.

Thanks in advance!

olaf

most of the time the error occurs if a result is empty...

where do call your function?

Kyrst

here is the new code as well as a new error

Parse error: parse error in /home/designo/public_html/musiclib/details.php on line 13

(line 13 is

. ' WHERE id = $_GET['track_id'] ';

)

include('connect.php');
$sql = 'SELECT `track_name` , `track_album` , `track_year` , `track_writer` , `track_lyric` '
        . ' FROM `track` '
        . ' WHERE id = $_GET['track_id'] ';

$res = mysql_query($sql);

   

function myquery ($query) {
       $result = mysql_query($query);
       if (mysql_errno())
           echo "MySQL error ".mysql_errno().": ".mysql_error()."\n<br>When executing:<br>\n$query\n<br>";
       return $result;
   } 
while($track = mysql_fetch_array($res)) {
$id = $track['track_id'];
$name = $track['track_name'];
$album = $track['track_album'];
$year = $track['track_year'];
$volume = $track['track_writer'];
$lyric = $track['track_lyric'];

echo "<TR><td align=left>".$track['track_name']."</td></tr>"; 
echo "<TR><td align=left>".$track['track_album']." - ".$track['track_year']."</td></tr>";
echo "<TR><td align=right>".$track['track_writer']."</td></tr>";
echo "<TR><td align=right>".$track['track_lyric']."</td></tr>";
}

</table></center>

olaf

This error is strange but could happen (diff. single quotes)

i handle sql statements like this:

$id = $_GET['track_id'];
$sql = "SELECT track_name, track_album, track_year, track_writer, track_lyric FROM track WHERE id = $id"; ?>

about the rest there is still no function called...

Kyrst

This language is a bit new to me...

track
track_id
track_name
track_artist
track_album
track_year
track_writer
track_lyric

what I am attempting to do is first pull up the query which lists
track name - artist name - volume
which pulls up fine.

track name links to a details.php using the track_id.

it is getting the details I want to display on the details page which is the issue.

track name
track album - track year
track writer (s)
track lyric

Kyrst

main.php (pulls up track name, track artist and track volume)

include('connect.php');

$sql = 'SELECT `track_name` , `track_artist` , `track_vol` , `track_id` '
        . ' FROM `track` '
        . ' WHERE 1  '
        . ' ORDER BY `track_name` ASC';

$res = mysql_query($sql); 

 function myquery ($query) {
       $result = mysql_query($query);
       if (mysql_errno())
           echo "MySQL error ".mysql_errno().": ".mysql_error()."\n<br>When executing:<br>\n$query\n<br>";
       return $result;
   } 
while($track = mysql_fetch_array($res)) {
$id = $track['track_id'];  

$name = $track['track_name'];
$artist = $track['track_artist'];
$volume = $track['track_vol'];
  echo "
<TR>
<td align=left><a href='details.php?id=".$id."' target='main'>".$name."</a></td>
<td align=left>".$artist."</td>
<td align=right>".$volume."</td>
         </tr>"; 
}

details.php ( will pull up track name, track album, track year, track writer(s) and track lyric)

<?php 
include('connect.php');

$id = $_GET['track_id'];

<!-- the line below is line 15, where the error is coming from -->

$sql = "SELECT track_name, track_album, track_year, track_writer, track_lyric FROM track WHERE track_id = $_GET['track_id']";
$res = mysql_query($sql); 
 function myquery ($query) {
       $result = mysql_query($query);
if (!$result = mysql_query($sql)) {    

    print "Invalid query ($sql) : " . mysql_error();    

    exit;    

}


while($row = mysql_fetch_array($res)) {  

$name = $row['track_name'];
$album = $row['track_album'];
$year = $row['track_year'];
$volume = $row['track_writer'];
$lyric = $row['track_lyric'];
  echo "
<TR><td align=center>".$row['track_name']."</td></tr>
<TR><td align=center>".$row['track_album']."</td></tr>
<TR><td align=center>".$row['track_year']."</td></tr>
<TR><td align=center>".$row['track_writer']."</td></tr>
<TR><td align=center>".$row['track_name']."</td></tr>
<TR><td align=center>".$row['track_lyric']."</td></tr>"; 
}
?> 
</table></center>
</body>
</html>

the error I am now getting when pulling up details.php is

Parse error: parse error, expecting T_STRING' orT_VARIABLE' or `T_NUM_STRING' in /home/designo/public_html/musiclib/details.php on line 15

Kyrst

I have decided that maybe this would work best with 2 different tables storing this info.

track
track_id
track_title
track_band
track_volume

tinfo
tinfo_id
track_id
tinfo_ alb
tinfo_year
tinfo_writer
tinfo_lyric

olaf

if you seperate code inside a function you have to call the function like:

myquery ($sql);

Kyrst

I will fix that then...

Thank you for the help... currently I am doing a little more studying before trying to run something as complicated. Working towards the baby steps now.

Will mark resolved at this point.