GD Library Image in Browser has wrong File ... Save As Name

ClevaTreva

See this page:

http://207.44.137.103/gdtest.htm

It has one small png image created by the GD Library.

If you right mouse click on it to save the image, in IE it gives you the name:

centercolbg

and the filetype of png.

Opera gives you the right filetype and the name:

centercolbg.png

In Mozilla it gives you the same filetype, but it names the file:

centercolbg.php.png

I have been told that in Safari (I think that was it) or at least some other browser it gave a filetype of bmp.

Is there any way to fix this behavior or is it a browser issue. What I mean is, can I fix it from my end in php?

this is the gdtest page code:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"
 "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html lang="en" xml:lang="en" xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-type" content="text/html; charset=utf-8" />
<title>GD Test</title>
</head>
<body>
<img class="saveimages" src="centercolbg.php?color=ADD8E6&x_size=478&y_size=20
" height="50" width="50" alt="" />
</body>
</html>

and this is the code for the centercolbg php file:

<?php
header ("Content-type: image/png");
$newImg = ImageCreate($_GET['x_size'],$_GET['y_size']);
$color = imagecolorallocate($newImg,hexdec(substr($_GET['color'],0,2)),hexdec(substr($_GET['color'],2,2)),hexdec(substr($_GET['color'],4,2)));
ImageFill($newImg,0,0,$color);
ImagePNG($newImg);
ImageDestroy($newImg);
?>

Trevor

olaf

Think about... where do you tell php the filename? or give the command to copy the file to the server?

ClevaTreva

Hi Olaf

Your reply was a bit cryptic. But ...

The name comes from the source in the html image tag.

As the gd library file (centercolbg.php) has to be outside the normal php or html files (ie the file can only contain gd functions) I had to pass it the variables needed to make the image, hence the src looking like this:

src="centercolbg.php?color=ADD8E6&x_size=478&y_size=20"

Ideally, I would make this:

src="centercolbg.png?color=ADD8E6&x_size=478&y_size=20"

so that it uses an image name, but then how would apache know to send this to the php parser?

A bright light 🆒

Edit httpd.conf to parse png through the php module, editing the line to this:

AddType application/x-httpd-php .php .php3 .php4 .phtml .png

Now, check if a real png will still open in the browser, yes.

Now, try gdtest file to see if browsers now think it is a png file.

Yes, yes and yes. Cool.

I wonder whether this will place any major load on the server?

AND, I can get it to work on my local server, but it won't on the shared server on the web coz I can't edit the httpd.conf, or can I, or can this be done via the htaccess file?

Trevor

ClevaTreva

And the htaccess answer was to add this line to my htaccess:

AddType application/x-httpd-php .png

I will try this after lunch.

Trevor

ClevaTreva

Originally posted by ClevaTreva
And the htaccess answer was to add this line to my htaccess:

AddType application/x-httpd-php .png

I will try this after lunch.

Trevor

Hi All

A few sandwiches later (but at least one short of a picnic).

Edited the htaccess for my server online and it doesn't do it. In fact, if you try to access a REAL png directly, it now 500's.

Any ideas?

ClevaTreva

Well, finally, after much googling, I found that the if the source html requesting the gd image was this:

<img class="saveimages" src="centercolbg.php?color=ADD8E6&x_size=478&y_size=20&pngname=centercolbg" height="50" width="50" alt="" />

and the gd function file had a header like this:

header ("Content-type: image/png\nContent-Disposition: inline; filename={$_GET['pngname']}.png");

The browser will behave and get the filename right when asked to save it.

That took a lot of discovering. It isn't even in the php manual I've got, but since finding this I can now find it in the user comments part of the php.net site page for header(). Ah well.

Trevor

olaf

Sorry for my "unfriendly" first post. I want to point you to something. After all the header was the breakpoint. The bad point on your solution for naming the file is, if you use the script twice you get the same name for two files.

ClevaTreva

Hi Olaf

On a point of semantics, offense (or unfriendliness) has to be received, and I never take offence or get upset about anything anyone says to me. I always smile 🙂

I'm sure your intent was to help, and indeed you did 😃 Thankyou for that.

In fact, whilst I showed just html for clarity, the variable pngname (and the others) is actually set by php and changes for each request, so no problem with using the same name twice, but thanks for the warning!

Trevor