Select Update

[treeleaf20]

Ok I have it loop through and try and update all of the records, it doesn't know which ones are checkboxed though and those are the ones that I need to be updated. Also I want it to replace the old vaule with the new value on the UnitNum that is passed. Right now it is trying to update the UnitNum. The code I am using is:

if(!empty($column)){
    //if(!empty($unitnum)){
        $query = "UPDATE master set  ";
        for($i=0;$i<sizeof($unitnum);$i++){
            if($i == sizeof($unitnum)-1){
                $query .= $unitnum[$i];
                $query .= "=";
                $query .= '$newvalue';
                $query .= " WHERE ";
                $query .= $unitnum[i];
                $query .= "=";
                $query .= '$oldvalue';
            }else{
                $query .= $unitnum[$i];
                $query .= "=";
                $query .= '$newvalue';
                $query .= " WHERE ";
                $query .= $unitnum[i];
                $query .= "=";
                $query .= '$oldvalue';
            }
        }
    }
    //}
    }
if(!empty($_GET[region])){
$query.= " AND RegionName='$region'";
}

The output of this is:
Query is: UPDATE master set 1600=$newvalue WHERE =$oldvalue3677=$newvalue WHERE =$oldvalue8737=$newvalue WHERE =$oldvalue11348=$newvalue WHERE =$oldvalue11347=$newvalue WHERE =$oldvalue11346=$newvalue WHERE =$oldvalue1603=$newvalue WHERE =$oldvalue3684=$newvalue WHERE =$oldvalue1958=$newvalue WHERE =$oldvalue11354=$newvalue WHERE =$oldvalue11345=$newvalue WHERE =$oldvalue11352=$newvalue WHERE =$oldvalue1607=$newvalue WHERE =$oldvalue11355=$newvalue WHERE =$oldvalue1908=$newvalue WHERE =$oldvalue1770=$newvalue WHERE =$oldvalue1775=$newvalue WHERE =$oldvalue1779=$newvalue WHERE =$oldvalue1769=$newvalue WHERE =$oldvalue1781=$newvalue WHERE =$oldvalue1910=$newvalue WHERE =$oldvalue1780=$newvalue WHERE =$oldvalue1782=$newvalue WHERE =$oldvalue1793=$newvalue WHERE =$oldvalue11744=$newvalue WHERE =$oldvalue2017=$newvalue WHERE =$oldvalue7958=$newvalue WHERE =$oldvalue2461=$newvalue WHERE =$oldvalue2479=$newvalue WHERE =$oldvalue7849=$newvalue WHERE =$oldvalue2449=$newvalue WHERE =$oldvalue9299=$newvalue WHERE =$oldvalue7851=$newvalue WHERE =$oldvalue7954=$newvalue WHERE =$oldvalue2448=$newvalue WHERE =$oldvalue1898=$newvalue WHERE =$oldvalue2167=$newvalue WHERE =$oldvalue1905=$newvalue WHERE =$oldvalue2729=$newvalue WHERE =$oldvalue10132=$newvalue WHERE =$oldvalue2728=$newvalue WHERE =$oldvalue6984=$newvalue WHERE =$oldvalue1934=$newvalue WHERE =$oldvalue1935=$newvalue WHERE =$oldvalue9734=$newvalue WHERE =$oldvalue1936=$newvalue WHERE =$oldvalue8546=$newvalue WHERE =$oldvalue8162=$newvalue WHERE =$oldvalue11379=$newvalue WHERE =$oldvalue2715=$newvalue WHERE =$oldvalue6560=$newvalue WHERE =$oldvalue9740=$newvalue WHERE =$oldvalue9741=$newvalue WHERE =$oldvalue9742=$newvalue WHERE =$oldvalue2662=$newvalue WHERE =$oldvalue8538=$newvalue WHERE =$oldvalue8111=$newvalue WHERE =$oldvalue1913=$newvalue WHERE =$oldvalue1788=$newvalue WHERE =$oldvalue1790=$newvalue WHERE =$oldvalue1789=$newvalue WHERE =$oldvalue11402=$newvalue WHERE =$oldvalue11403=$newvalue WHERE =$oldvalue1784=$newvalue WHERE =$oldvalue1786=$newvalue WHERE =$oldvalue1771=$newvalue WHERE =$oldvalue1772=$newvalue WHERE =$oldvalue1836=$newvalue WHERE =$oldvalue1837=$newvalue WHERE =$oldvalue1838=$newvalue WHERE =$oldvalue1839=$newvalue WHERE =$oldvalue1840=$newvalue WHERE =$oldvalue1841=$newvalue WHERE =$oldvalue2838=$newvalue WHERE =$oldvalue1791=$newvalue WHERE =$oldvalue
You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near '1600=$newvalue WHERE =$oldvalue3677=$newvalue WHERE =$oldvalue8

I hope someone can please help me out

[swr]

It's kind of hard to tell what you're trying to do from the code you've posted, but I'm pretty sure you can't update all the data you want to update using a single SQL update statement.

Instead of repeatedly appending to $query inside the loop and calling mysql_query on the huge $query variable, call mysql_query inside the loop, updating one record each time.

There are other errors in your code too, namely using single quotes like this:

$query .= '$newvalue';

That will append the literal string $newvalue, not the value of the $newvalue variable. Use double quotes to get PHP to process the variable:

$query .= "$newvalue";

Or, because you're only appending the contents of the variable with nothing else, drop the quotes entirely:

$query .= $newvalue;

[treeleaf20]

I changed the code to this:

 if(!empty($column)){
	if(!empty($unitnum)){
        //$query = "UPDATE master set  ";
        for($i=0;$i<sizeof($unitnum);$i++){
            if($i == sizeof($unitnum)-1){
			$query = "UPDATE master set  ";
                $query .= $field;
				$query .= "=";
				$query .= $newvalue;
				$query .= " WHERE ";
				$query .= $field;
				$query .= "=";
				$query .= $oldvalue;
				echo "$query";
            }else{
			$query = "UPDATE master set  ";
                $query .= $field;
				$query .= "=";
				$query .= $newvalue;
				$query .= " WHERE ";
				$query .= $field;
				$query .= "=";
				$query .= $oldvalue;
				$query .= " AND UnitNum=";
				$query .= $unitnum[i];
				echo "$query";
            }
        }
    }
	}
	}
if(!empty($_GET[region])){
$query.= " AND RegionName='$region'";
}
echo "Query is: ".$query."<br>\n\n";

The output is this:
UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=X AND UnitNum=UPDATE master set Pepsi=X WHERE Pepsi=XQuery is: UPDATE master set Pepsi=X WHERE Pepsi=X
Unknown column 'X' in 'where clause',

So it tries to update all of the UnitNum's that are in that region, I want it only to try and update the values that I selected with the checkboxes on the previous page. I'm not sure why it says Unknown column X either, that is the value that I'm trying to replace.

[mrhappiness]

maybe 'X' instead of X would be better since i guess it's a string and not a number?