crazy syntax problem

[oxman]

This script is supposed to upload a couple of images and insert the names of the images into the database.

Stupid syntax error that i just cant see..could just be stupid me.

<?
global $DOCUMENT_ROOT;

$img_low = $HTTP_POST_FILES['low']['name'];
$img_high = $HTTP_POST_FILES['high']['name'];

require('../functions.inc');

require('header.php');

$server = "localhost"; 
$username = "username"; 
$password = "password"; 
$dbase = "dbase";

//connect

		$link = mysql_connect($server, $username, $password) or die ("Could not connect");

		mysql_select_db ("db") or die ("Could not select database");

		$mystring = "INSERT INTO ".$dbase." (desc, img_small, img_big) VALUES ('$desc', '$img_low', '$img_high')";

		$query = mysql_query($mystring); 

		if(!$query) 
		{ 
		echo "The database is temporarily unavailable: contact your server administrator ". mysql_error(); 
		exit; 
		} 
		else 
		{ 
				if(!empty($low))
				{

					if (is_uploaded_file($HTTP_POST_FILES['low']['tmp_name'])) {

						$fulldoc = $HTTP_POST_FILES['low']['tmp_name'];

						$newdoc = $DOCUMENT_ROOT."/resources/".$HTTP_POST_FILES['low']['name']; 

						move_uploaded_file($fulldoc, $newdoc); 

					} else {

						echo "Possible file upload attack: filename ".$HTTP_POST_FILES['low']['name'].".";
					}
				}

				if(!empty($high))
				{

					if (is_uploaded_file($HTTP_POST_FILES['high']['tmp_name'])) {

						$fulldoc = $HTTP_POST_FILES['high']['tmp_name'];

						$newdoc = $DOCUMENT_ROOT."/resources/".$HTTP_POST_FILES['high']['name']; 

						move_uploaded_file($fulldoc, $newdoc); 

					} else {

						echo "Possible file upload attack: filename ".$HTTP_POST_FILES['high']['name'].".";
					}
				}

				echo "list all images now";
			}

require('footer.php');

?>

INSERT query gives me a sytax error?

[nemonoman]

$mystring = "INSERT INTO ".$dbase." (desc, img_small, img_big) VALUES ('$desc', '$img_low', '$img_high')";

Probably you want the tablename, not the database name...replace $dbase with the name of the table where you're inserting the row.

[oxman]

I wish it was that but its not. The table name is correct.

Makes no sense to me why this spits out an error message.

[nemonoman]

do this:

echo $mystring;
echo mysql_error;

also post the structure of your table 'dbase'

You can do this with the DESCRIBE command:

DESCRIBE dbase

[oxman]

echo mystring is:

INSERT INTO dbase (desc, img_small, img_big) VALUES ('first one', 'banner_03.jpg', 'banner_04.jpg')

echo mysq_error() is:

You have an error in your SQL syntax near 'desc, img_small, img_big) VALUES ('first one', 'banner_03.jpg', 'banner_04.jpg')' at line 1

Describe table is:

Array
(
[0] => Array
(
[0] => img_id
[Field] => img_id
[1] => int(11)
[Type] => int(11)
[2] =>
[Null] =>
[3] => PRI
[Key] => PRI
[4] =>
[Default] =>
[5] => auto_increment
[Extra] => auto_increment
)

[1] => Array
    (
        [0] => desc
        [Field] => desc
        [1] => text
        [Type] => text
        [2] => YES
        [Null] => YES
        [3] => 
        [Key] => 
        [4] => 
        [Default] => 
        [5] => 
        [Extra] => 
    )

[2] => Array
    (
        [0] => img_small
        [Field] => img_small
        [1] => text
        [Type] => text
        [2] => YES
        [Null] => YES
        [3] => 
        [Key] => 
        [4] => 
        [Default] => 
        [5] => 
        [Extra] => 
    )

[3] => Array
    (
        [0] => img_big
        [Field] => img_big
        [1] => text
        [Type] => text
        [2] => YES
        [Null] => YES
        [3] => 
        [Key] => 
        [4] => 
        [Default] => 
        [5] => 
        [Extra] => 
    )

)

[nemonoman]

desc is a reserved word: DESC. That's what's causing the error.
You need to enclose the column_name in backquotes desc , or better yet, change it to a non-reserved word like description to avoid future heartache.

[oxman]

neomonoman,

You are a true legend.

Many many thanks.😃