A problem with isset

ATLien

Hey, I am trying to create a page that will look up a individual news article if the link is news.php?newsid=(news article id) and if it is just news.php it will show all of them in decending order. What am I doing wrong. When I just goto news.php it shows only one article.

<?PHP
include ('header.php');


if (isset($newsid)){
$query = "SELECT * FROM news WHERE id='$newsid'";
$result = mysql_query("$query") or die();
$sqlnews = mysql_fetch_array($result);
?>
<table cellpadding=5 cellspacing=0>
<tr>
	<td><span class="newsdate">~<?PHP echo $sqlnews['date']; ?>~</span></td>
<tr>
<tr>
	<td><span class="news"><?PHP echo $sqlnews['news']; ?></span></td>
</tr>
<tr>
	<td><hr></td>
</tr>
</table>
<?PHP
}else{
$query = "SELECT * FROM news ORDER BY id DESC";
$result = mysql_query("$query") or die();
$sqlnews = mysql_fetch_array($result);
while ($sqlnews = mysql_fetch_array($result)) {
?>
<table cellpadding=0 cellspacing=0>
<tr>
	<td><span class="newsdate">~<?PHP echo $sqlnews['date']; ?>~</span></td>
<tr>
<tr>
	<td><span class="news"><?PHP echo $sqlnews['news']; ?></span></td>
</tr>
<tr>
	<td><hr></td>
</tr>
</table>
<?PHP
}
}
include ('footer.php');
?>

ATLien

<?PHP
include ('header.php');

$query = "SELECT * FROM news ";

if (isset($_GET['newsid'])){

$query .= "WHERE id = " . $_GET['newsid'] . " ";
$result = mysql_query("$query") or die();
$sqlnews = mysql_fetch_array($result);
?>
<table cellpadding=5 cellspacing=0>
<tr>
	<td><span class="newsdate">~<?PHP echo $sqlnews['date']; ?>~</span></td>
<tr>
<tr>
	<td><span class="news"><?PHP echo $sqlnews['news']; ?></span></td>
</tr>
<tr>
	<td><hr></td>
</tr>
</table>
<?PHP
}else{

$query .= "ORDER BY id DESC";
$result = mysql_query("$query") or die();
$sqlnews = mysql_fetch_array($result);
while ($sqlnews = mysql_fetch_array($result)) {
?>
<table cellpadding=0 cellspacing=0>
<tr>
	<td><span class="newsdate">~<?PHP echo $sqlnews['date']; ?>~</span></td>
<tr>
<tr>
	<td><span class="news"><?PHP echo $sqlnews['news']; ?></span></td>
</tr>
<tr>
	<td><hr></td>
</tr>
</table>
<?PHP
}
}
include ('footer.php');
?>

thespear

fixed:

Originally posted by ATLien

<?PHP
include ('header.php');

$query = "SELECT * FROM news ";
$newstype = 0;
if (isset($_GET['newsid'])){
  $newstype = 1;
  $query .= "WHERE id = " . $_GET['newsid'] . " ";
}
$query .= "ORDER BY id DESC";
$result = mysql_query("$query") or die();
while ($sqlnews = mysql_fetch_array($result)) {
  if ($newstype == 0) {
    echo "<table cellpadding=0 cellspacing=0>";
    echo "<tr><td><span class=\"newsdate\">~" . $sqlnews['date'] . "~</span></td></tr>";
    echo "<tr><td><span class=\"news\">" . $sqlnews['news'] . "</span></td></tr>";
    echo "<tr><td><hr></td></tr></table>";
  } else {
    echo "full stuff here";
  }
}
include ('footer.php');
?>

[/B]