Parse Error - why?

[erikhillis]

Hey,
Can someone tell me why I'm getting a parse error?

Parse error: parse error in /home/uc/public_html/buildings.php on line 380

This is line 380 (Bold):

if(!isset($GET['order'])){
$order = 1;
} else {
$order = $GET['order'];
}

<?php 
$db = mysql_connect("localhost","uc_site","xxx");
mysql_select_db (uc_site);
if(!isset($_GET['order'])){ 
    $order = 1; 
} else {
    $order = $_GET['order']; 
} 
$max_results = 50; 
$from = (($order * $max_results) - $max_results); 

$sql = mysql_query("SELECT * FROM buildings where id='{$_REQUEST['id']}' and STATUS='{$_REQUEST['STATUS']}' order by height_m DESC LIMIT $from, $max_results");

while($row = mysql_fetch_array($sql)) { 

for($i=1;$row=mysql_fetch_array($sql);$i++)
echo('<table border=0 width=100% cellspacing=0 cellpadding=0>
        <tr onmouseover=\"this.bgColor='#FFFFFF'\" onmouseout=\"this.bgColor='#ededed'\">
          <td width=35% valign=top><p align=left><img src= 'http://www.urbancanada.com/images/$STATUS.jpg' alt='Building Status: $STATUS - Click for more info!' border= '0'> <B>'.$i.'</B> <a href=urbanca.php?page=building&buildingid='.$row["buildingid"].'><font face=Arial style= 'font-size: 8pt'>'.$row["name"].'</B></a></font></b></td>
          <td width=13% valign=top><font face= 'Arial' style= 'font-size: 8pt'><center>'.$row["height_m"].' m</font></b></td>
          <td width=13% valign=top><center><font face=Arial style= 'font-size: 8pt'>'.$row["floors"].'</font></b></td>
          <td width=13% valign=top><center><font face=Arial style= 'font-size: 8pt'>'.$row["STATUS"].'</font></b></td>
          <td width=13% valign=top><center><font face=Arial style= 'font-size: 8pt'>'.$row["structural_type"].'</font></b></td>
          <td width=13% valign=top><center><font face=Arial style= 'font-size: 8pt'>'.$row["year"].'</font></b></td>
        </tr>
      </table>');
}
?>

[weekender]

i think the error is in the following line

mysql_select_db (uc_site);

firstly, there is a space between the function name and the bracket.

mysql_select_db(uc_site);

secondly, the parameter passed to the function, which in this case is the name of the db to select, is neither a string or a variable in your code. In fact, you've put it as a constant, which it is not.

it needs to be

mysql_select_db("uc_site");
// or
$uc_site = "dbname";
mysql_select_db($uc_site);

hope this helps

adam

[erikhillis]

Thanks, but it still dosn't seem to wanna work 🙁

[LordShryku]

Only problem I see is on this line:

echo('<table border=0 width=100% cellspacing=0 cellpadding=0>
<tr onmouseover=\"this.bgColor='#FFFFFF'\" onmouseout=\"this.bgColor='#ededed'\">

You're slashing the wrong quotes. Since ou're echoing with single quotes, you need to slash the single quotes and not the double quotes. But you obviously have a lot of code preceeding this chunk, and a parse error often times occurs somewhere before the line it tells you.

[erikhillis]

I took the onmouseover=\"this.bgColor='#FFFFFF'\" onmouseout=\"this.bgColor='#ededed'\" out, and still parse error.

I'll keep trying

[Weedpacket]

Cut-and-paste to a file and going:

php -l -f test.php

Parse error: parse error, unexpected T_STRING in test.php on line 19

Where line 19 is the one that starts

          <td width=35% va

But looking at the syntax highlighting it is clear what the problem is; everything in that echo should be red to indicate that it is all one string, not what it is now. Seeing as the string is single-quoted, the single quotes should be escaped, not the double quotes. But then the variables wouldn't work any more.

There are at least three other options; here's one:

echo <<<EOF
<table border=0 width=100% cellspacing=0 cellpadding=0>
	<tr onmouseover="this.bgColor='#FFFFFF'" onmouseout="this.bgColor='#ededed'">
		<td width=35% valign=top><p align=left><img src= 'http://www.urbancanada.com/images/$STATUS.jpg' alt='Building Status: $STATUS - Click for more info!' border= '0'> <B>$i</B> <a href=urbanca.php?page=building&buildingid=$row[buildingid]><font face=Arial style= 'font-size: 8pt'>$row[name]</B></a></font></b></td>
		<td width=13% valign=top><font face= 'Arial' style= 'font-size: 8pt'><center>$row[height_m] m</font></b></td>
		<td width=13% valign=top><center><font face=Arial style= 'font-size: 8pt'>$row[floors]</font></b></td>
		<td width=13% valign=top><center><font face=Arial style= 'font-size: 8pt'>$row[STATUS]</font></b></td>
		<td width=13% valign=top><center><font face=Arial style= 'font-size: 8pt'>$row[structural_type]</font></b></td>
		<td width=13% valign=top><center><font face=Arial style= 'font-size: 8pt'>$row[year]</font></b></td>
		</tr>
	</table>
EOF;