[Resolved] Function returns wrong answer

[k994519]

Hi guys

Ive written a function which checks if the user is admin or not...

function checkadmin($login)
	{
global $link;
$login = $_SESSION["login"];
$query="SELECT login, admin_type FROM admin WHERE login='$login' and admin_type='yes'";
$result=mysql_query($query, $link)
	or die("checkPass fatal error: ".mysql_error());

// Check exactly one row is found:
if(mysql_num_rows($result)==1)
	{
	$row=mysql_fetch_array($result);
	return true;
}
//not admin:
return false;
}

and to test this system I have writen this if statement

if (checkadmin(true))
	{
	print "U are admin user  ";
	print("<BR>");

}
else 
{	
print "u are not admin user";
}

when refering back the database the user created keeps on get the 2nd message and I have not got a clue as to why?

any help would be much appreciated........

[goldbug]

Is 'true' (boolean) the username?

If not then that's probably the issue.

try:

if (checkadmin())
{
    print "U are admin user  ";
}
else 
{    

    print "u are not admin user";
}

If you are reading the login name from the session like you currently have it inside the function, there's absolutely no reason to have a function parameter (remove $login as parameter), because you are always overwriting it with what you currently have in the code.

[goldbug]

Man, that function looks goofy,.... i just went ahead and cleaned it up (you forgot an else as well)

function checkadmin()
{
    global $link;
    $login = $_SESSION["login"];
    $query="SELECT login, admin_type FROM admin WHERE login='$login' and admin_type='yes'";
    $result=mysql_query($query, $link)
        or die("checkPass fatal error: ".mysql_error());

// Check exactly one row is found:
if(mysql_num_rows($result)==1)
{
    $row=mysql_fetch_array($result);
    return true;
}
else
{
    //not admin:
    return false;
}
}

[k994519]

HI goldbug

It worked perfectly.... thanks alot....