fopen() error

BareKnuckles

I am new to php and I could use some advice.

I'm running php 4.3.4 and abyss server on a win98 machine.
php is installed correctly as I have tested it using phpinfo().
I get this error when executing a certain script that I wrote...

Warning: fopen(undeliverable email.txt): failed to open stream: No such file or directory in C:\Program Files\Abyss Web Server\htdocs\php\sendmixed.php on line 6
Warning: fread(): supplied argument is not a valid stream resource in C:\Program Files\Abyss Web Server\htdocs\php\sendmixed.php on line 7

What needs to be done to fix this?

just so you know:
register_globals=on
safemode=off

thanks!🙂

AdamBrill

Does C:\Program Files\Abyss Web Server\htdocs\php\email.txt exist? If not, then that is probably your problem. The error that you are receiving is normally the one that you would receive if you specified a file that doesn't exist.

You also may want to make sure that the file(email.txt) is not read-only.

BareKnuckles

You are correct. That file does no exist in that particular location. The script that I wrote is for an upload form and that file "email.txt" happens to be the file that I tried to upload.

So, if I'm not mistaken, it appears that the script is looking in it's own location, (the scripts location) for a file that I want to upload to the server.

I hope that made any sense?

AdamBrill

My guess is that you have something wrong with the your uploading script. Try using this one and see if you have better results. 🙂

The form:

<form enctype="multipart/form-data" action="formhandler.php" method="post">
 Send this file: <input name="userfile" type="file">
 <input type="submit" value="Send File">
</form>

formhandler.php:

<?PHP

$dir = 'C:/test/'; //directory to put the file in after it uploads
$filename = (isset($_FILES['userfile']['name']))?$_FILES['userfile']['name']:""; //checks to make sure that the filename variable is set
$file = $dir.$filename; //adds the name that the uploaded file will be named onto the end of the folder

if ($filename != ""){
	if(move_uploaded_file($_FILES['userfile']['tmp_name'], $file)) { //this and the above line are both on one line...
		echo "File uploaded successfully! Here is some info:<br>\n";
		echo "<pre>";
		print_r($_FILES);
		echo "</pre>";
	} else {
		echo "Error! File upload failed! Here is some info:<br>\n";
		echo "<pre>";
		print_r($_FILES);
		echo "</pre>";
	}
}else{
	echo "No file was uploaded...";
}

?>

lives4him06

i have a similar question:

Regarding the uploading of images. I am using iluj.jpg as my test image.

File size: 27,568 bytes

I have the following two pages of code:

The first page displays the form:

the following page, "imageupload2.php", is supposed to move the image into the folder images:

 if (is_uploaded_file($_FILES['userfile']['tmp_name'])) {
    copy($_FILES['userfile']['tmp_name'], "../images");
} else {
    echo "Possible file upload attack. Filename: " . $_FILES['userfile']['name'];
}

The following error message is presented:
"Possible file upload attack. Filename: iluj.jpg"

what am i doing wrong?

AdamBrill

Originally posted by lives4him06
what am i doing wrong?

You are specifying the name of the image to be ../images, which is probably the problem. Try this code instead(or use the other code which I provided in my last post):

<?PHP
if  (is_uploaded_file($_FILES['userfile']['tmp_name'])) { 
    copy($_FILES['userfile']['tmp_name'], "../images/". $_FILES['userfile']['name']); 
	echo "Success!";
} else { 
    echo "Possible file upload attack. Filename: " . $_FILES['userfile']['name']; 
}
?>

lives4him06

i copied that section of the code directly from the manual section of this site and it said that the directory in which i wanted to put the picture was supposed to be there. Any comments?

AdamBrill

Originally posted by lives4him06
i copied that section of the code directly from the manual section of this site and it said that the directory in which i wanted to put the picture was supposed to be there. Any comments?

Well, could you provide a direct link to where you found that? I personally do not have the access necessary to change that, but I can at least write them and let them know that there is a problem.

dalecosp

Originally posted by lives4him06
i copied that section of the code directly from the manual section of this site and it said that the directory in which i wanted to put the picture was supposed to be there. Any comments?

Yeah, I've got some, but I'm not sure that I can do 'em right now. Has anybody ever browsed this site with lynx? Not much fun 🙁
Anyway, is "../images" writeable by the web server's id? (Not sure that really matters, tho...)

Basically, the problem is that the first condition isn't being met. If we can figure out why ... 🙂

lives4him06

do you mind helping me figure out why the first condition is not met?

link to where i found the code snippet: link

lives4him06

does anyone have any ideas?

dalecosp

Well, for starters, show us your code, and let us know a tad about the system it's on, if it's not obvious from reading your code.

Secondly, in the future, try not to hijack other people's threads 🙂 ...

Now, to the problem at hand ... if the "temp" file is not an uploaded file, could it be possible that it's not being placed in the temporary location? That's the primary reason why an if call to [man]is_uploaded_file[/man] would fail ... unless, of course, your browser is simply not POSTing the data correctly...

What is your temp dir (check php.ini...)? If you're on some 3rd party hosting site, is it possible that you don't have access to the PHP default temp dir?

Also, be sure and check what Adam told you. It's possible that by using a bad pathname (for example, no trailing slash) you could put a file where you don't want to...

lives4him06

php.ini file:

; php.ini for PEAR tests
include_path=..
[mail function]
SMTP= localhost ; for Win32 only
sendmail_from= me@localhost.com ; for Win32 only
upload_tmp_dir = C:\PHP\uploadtemp ; temporary directory for HTTP uploaded files (will use system default if not specified)
[Session]
session.save_path= C:\PHP\sessiondata ; argument passed to save_handler
error_reporting= E_ALL; display all errors, warnings and notices
[/QUOTE] 

what do i need to update/add?



the server is set up on my personal windows laptop, i am running apache. 

I chose the picture i wanted to up load by (in the form on the first page) clicking browse. I then selected the iluj.jpg file in the directory "my documents". I then clicked send file and was directed to the second page where the following was displayed:

[QUOTE]Possible file upload attack. Filename: iluj.jpg[/QUOTE]

If you look in the code this is the messages that is displayed if the 'if' statement is not satified.

AdamBrill

lives4him06: You still didn't provide us with your code... Also, did you try using the code that I posted? It is possible that there is something wrong with your code and simply using my code instead would make it work. At least try it and let us know the results.

BareKnuckles: Is it working correctly for you now?

lives4him06

Success!!

thank you, AdamBrill!

Sorry about taking over your post, BareKnuckles it was not my original intent.

BareKnuckles

Thanks for helping Adam. I was able to get your script working so there is most certainly something wrong about my code. Now I'm trying to find a way to combine your code with my existing code. My desired goal is to allow users to upload to my server while a message is sent to my email address notifiying me of the transaction.

If you have any ideas about this I sure would like to hear them. Thanks for checking back in to see how I was cominig along. 🙂

No prob about cutting in on my post either. Hopefully we can all get our problems fixed.

AdamBrill

Try the following code:

<?PHP

$dir = 'C:/test/'; //directory to put the file in after it uploads
$filename = (isset($_FILES['userfile']['name']))?$_FILES['userfile']['name']:""; //checks to make sure that the filename variable is set
$file = $dir.$filename; //adds the name that the uploaded file will be named onto the end of the folder

if ($filename != ""){
	if(move_uploaded_file($_FILES['userfile']['tmp_name'], $file)) {
		$to = "you@yourdomain.com";
		$subject = "New File Upload!";

	$headers  = "MIME-Version: 1.0\r\n";
	$headers .= "Content-type: text/html; charset=iso-8859-1\r\n";
	$headers .= "From: File Upload Notifier\r\n";

	$message = "The following file was uploaded: <strong>".$_FILES['userfile']['name']."</strong>";

	mail($to,$subject,$message,$headers);


	echo "File uploaded successfully! Here is some info:<br>\n";
	echo "<pre>";
	print_r($_FILES);
	echo "</pre>";
} else {
	echo "Error! File upload failed! Here is some info:<br>\n";
	echo "<pre>";
	print_r($_FILES);
	echo "</pre>";
}
}else{
	echo "No file was uploaded...";
}

?>

Notice that you will have to change the $to variable to the e-mail address that you want to send the notification.

Also, it is a very bad idea to allow anyone to upload any file type. You should use regex to only allow the certain file types that you want people to be able to upload.

BareKnuckles

Awesome!, thank you Adam for your help. I do infact want to limit users to uploading .zip files only. I know there is a way to do that but I myself don't know how. You mentioned something called regex. Is that a program you download?

AdamBrill

No, regex is not a seperate program, it is built into PHP. Try this code:

<?PHP

$dir = 'C:/test/'; //directory to put the file in after it uploads
$filename = (isset($_FILES['userfile']['name']))?$_FILES['userfile']['name']:""; //checks to make sure that the filename variable is set
$file = $dir.$filename; //adds the name that the uploaded file will be named onto the end of the folder

if ($filename != ""){
	if(ereg("\.zip$", $filename)){
		if(move_uploaded_file($_FILES['userfile']['tmp_name'], $file)) {
			$to = "you@yourdomain.com";
			$subject = "New File Upload!";

		$headers  = "MIME-Version: 1.0\r\n";
		$headers .= "Content-type: text/html; charset=iso-8859-1\r\n";
		$headers .= "From: File Upload Notifier\r\n";

		$message = "The following file was uploaded: <strong>".$_FILES['userfile']['name']."</strong>";

		mail($to,$subject,$message,$headers);


		echo "File uploaded successfully! Here is some info:<br>\n";
		echo "<pre>";
		print_r($_FILES);
		echo "</pre>";
	} else {
		echo "Error! File upload failed! Here is some info:<br>\n";
		echo "<pre>";
		print_r($_FILES);
		echo "</pre>";
	}
}else{
	echo "I'm sorry, only .zip files are accepted.";
}
}else{
	echo "No file was uploaded...";
}

?>

Notice this line:

if(ereg(".zip$", $filename)){

This will make sure that the $filename ends in ".zip". You will notice that I had to put a \ before the . since .'s are special characters in regex. Also, $ matches the end of the string, so that is how it makes sure that .zip is at the end.

I hope that helps!

EDIT:Here is a link to the regex reference section of php.net if your interested: http://us4.php.net/manual/en/ref.regex.php

BareKnuckles

U da man Adam . Thanks for your help. 🆒