help with php

[metro]

I've been trying to edit phpbb, in sessions.php

function append_sid($url, $non_html_amp = false){
global $SID;
if ( !preg_match('/php?/', $url) ){
$hehehe = "?forum=";
}
else{
$hehehe = "&forum=";
}
if ( !empty($SID) && !preg_match('#sid=#', $url) ){
$url .= ( ( strpos($url, '?') != false ) ? ( ( $non_html_amp ) ? '&' : '&' ) : '?' ) . $SID;
}
$xstuffx1 = "?forum=";
$xstuffx2 = "&forum=";
return $url.$hehehe.$_SESSION["forumnameforurl"];
}

Basicly I want to add a variable at the end of all links, it seems to do so except if theirs already a variable it shows like this:

mydomain.com/somepage.php?variable=alreadyone

then it just ads ?after=that

I want it so whens theres already a variable I need it to be &after=that.

Any help?

[swr]

Here's your problem:

if ( !preg_match('/php?/', $url) ){

The ? is a special character, it means the previous character is optional. So any URL that contains "ph" will match and append ?forum=.

Put a backslash () before the question mark to escape it. Then it will match a literal question mark.

[edit]
By the way... because you are matching a literal string instead of something more complex, you could just use [man]strpos[/man] instead.

[metro]

it worked except when theirs a "$sid" in the url it doesnt seem to do & it just adds ?=variable at the end.

[Weedpacket]

Where is "$SID" coming from? You sure you don't mean "SID"?
Hm..another contender for my "dumb subject lines" list.