Checking file type on upload

[Sharif]

Wouldn't this code check to see if the file being uploaded through a form field named "icon"is a jpg, jpeg, or a gif. Meaning if it isn't, it would display something:

if($_FILES['icon']['type'] != 'image/jpg' || $_FILES['icon']['type'] != 'image/jpeg' || $_FILES['icon']['type'] != 'image/gif')

Even IF the files are the correct extension, I still get an error. Why?

[jackiw]

The file extension for JPG images has to be image/pjpeg and this is what you should do:

if(($_FILES['icon']['type'] != 'image/pjpeg') || ($_FILES['icon']['type'] != 'image/gif')) { do something... }

Now, do you have the upload form and the script on the same file or they are separate? 'Cause on my case, if I have them in two different files, the upload form isn't passing the vars to the script, but if they're on the same file, it works great.

[Sharif]

The form is a different file, that is included in another file that has the PHP in it. Also, the form doesn't seem to be passing variabls correctly.

Here is the whole code:

//Uploads new news icons
function upload_icon()
{
	global $STAFF;
	global $ERROR;

$upload_dir = $SITE['images'] . 'news_icons/';
$max_width = 80;
$max_height = 80;

if(isset($_POST['submit']) && $_POST['submit'] == 'Upload Icon')
{
	$file = $_FILES['icon']['tmp_name'];
	$dimensions = getimagesize($file);
	$width = $dimensions[0];
	$height = $dimensions[1];

	//Check image type
	if($_FILES['icon']['type'] != 'image/pjpeg' || $_FILES['icon']['type'] != 'image/gif')
	{	
		unlink($file);
		unset($_FILES);

		//Get da form!
		echo '<p><font color="#FF0000">';
		echo 'The file selected was not a in .jpg, .jpeg, or .gif format!';
		echo '</font></p>';
			include($STAFF['forms'] . 'upload_icon.php');
	}
	//Check image dimensions
	elseif($width != $max_width || $height != $max_height)
	{
		unlink($file);
		unset($_FILES);

		//Get da form!
		echo '<p><font color="#FF0000">';
		echo 'The image selected is not 80x80 pixels!';
		echo '</font></p>';
		include($STAFF['forms'] . 'upload_icon.php');
	}
	else
	{
		echo '...copying...';
	}
}
else
{
	//Get da form!
	echo '<p style="text-align: left;">';
	echo 'You can use this form to upload new news icons. Remember that the image MUST be in either .jpg, .jpeg or .gif format. ';
	echo 'Also note that the image must be 80x80 pixels.';
	echo '</p>';
	include($STAFF['forms'] . 'upload_icon.php');
}
}