unique hit counter

aksival

I've looked everywhere for an answer to this problem...in fact, I've been working on this (rather small) piece of code for a couple of hours now (researching, etc.). I give up for tonight.

Basically, what I am trying to do is make a unique hit counter with minimal lines of code. It will store all the IP addresses in a text file.

First, it checks to see if the current user's IP address is in the text file. If so, it prints the current number of visitors. If not, it adds the new user's IP to the end of the file and displays the new number of visitors. Here's the code:

<?php

$file = "hits.txt";
$ip_list = file($file);
$visitors = count($ip_list);

if (in_array($_SERVER['REMOTE_ADDRESS'], $ip_list))
{
exit ($visitors);
} else {

$fp = fopen($file,"a");
fwrite($fp, "\n$REMOTE_ADDR");
fclose($fp);
echo $visitors++;

}

For some reason, in_array fails to make a match. I've tried to use TRIM and/or STRIPSLASHES just to be safe, but it didn't affect the outcome. It's probably something really simple, I just can't see it.

Any ideas? ~yawn~ Thank! 🙂

drew010

in your in array check you are using $SERVER['REMOTE_ADDRESS'] instead of $SERVER['REMOTE_ADDR'] so since remote_address doesnt exist its searching for nothing.

Weedpacket

Originally posted by drew010
in your in array check you are using $SERVER['REMOTE_ADDRESS'] instead of $SERVER['REMOTE_ADDR'] so since remote_address doesnt exist its searching for nothing.

And also there's a chance that $REMOTE_ADDR doesn't exist either, so writing that instead of $_SERVER['REMOTE_ADDR'] probably isn't a good idea.

aksival

Ok, I've changed the $REMOTE_ADDRESS to $REMOTE_ADDRESS, and it does exist as my correct IP address...so that's not the problem.

It's wierd because I can ECHO $REMOTE_ADDR and ECHO $ip_list[140] and get the same result...so it should make the match.

laserlight

<?php

$file = "hits.txt";
$ip_list = file($file);
$visitors = count($ip_list);

//assume Unix end of line sequence
if (in_array($_SERVER['REMOTE_ADDR'] . "\n", $ip_list))
{
	echo $visitors;
	exit;
} else {
	$fp = fopen($file,"a");
	fwrite($fp, $_SERVER['REMOTE_ADDR'] . "\n");
	fclose($fp);
	$visitors++;
	echo $visitors;
}

?>

It is a newline problem, read the docs on [man]file/man

I modified the code so that the newline is inserted after each IP address, rather than inserting when the next IP address enters.

EDIT:
using exit the way you did probably wouldnt work, since $visitors would be interpreted as an exit code rather than a string to be output.