Help with Search Results

[8mycsh]

Hi there,

I have a search form that they can search with. It has a drop down box to either select and search by either artist or cd. The problem I am getting is it will search and if a result is found diplays it. But if no result I want it to display sorry no items found.
Right now it loads the page correctly and doesn't display anything. Also if I leave the field blank hit the search button it will do a search. How do I stop that?

Thanks for your input / help.

Here is the code for the search results page.

function searchResults( $option, $search_value, $search_in ) {
?>

<table cellpadding="2" cellspacing="0" width="100%" style="border-color: #0D406B; border-style: inset; border-width: 1px; ">
  <tr>
  <td height="27" align="left"  bgcolor="#607996" class="directorytext">Search Results</td>
  <tr>
  <td align="left" height="20" bgcolor="#0D406B" class="directorytext2">Your search results</td>
  </tr>
 <tr>
  <td align="left" valign="top">
<?
	switch($search_in) {
	  case "artists":
		global $database;
		$query = "SELECT id, name FROM #__artdir_artists WHERE name LIKE '%$search_value%'";
		$database->setQuery( $query );
		$rows = $database->loadObjectList();
		foreach($rows as $row) {
			echo "<a href=\"index.php?option=$option&amp;task=singleArtist&amp;id=$row->id\">$row->name</a><br />";
		}


	break;

  case "cds":
	global $database;
	$query = "SELECT id, cd_name FROM #__artdir_cds WHERE cd_name LIKE '%$search_value%'";
	$database->setQuery( $query );
	$rows = $database->loadObjectList();
	foreach($rows as $row) {
		echo "<a href=\"index.php?option=$option&amp;task=showCD&amp;id=$row->id\">$row->cd_name</a><br />";
	}
	break;
}

?>

[Natty_Dreadlock]

hi, u can change your code like this:

if(trim($search_value) == "")
{
    echo "No search query has been submitted";
}
else
{
     $search_value = addslashes($search_value);
     switch($search_in) {
        case "artists":
	global $database;
	$query = "SELECT id, name FROM #__artdir_artists WHERE name LIKE '%$search_value%'";
	$database->setQuery( $query );
	$rows = $database->loadObjectList();
                if(sizeof($rows) <= 0)
                {       

                      echo "No matching rows";
                      break;
                }
	foreach($rows as $row) {
		echo "<a href=\"index.php?option=$option&task=singleArtist&id=$row->id\">$row->name</a><br />";
	}
        break;
        case "cds":
	global $database;
	$query = "SELECT id, cd_name FROM #__artdir_cds WHERE cd_name LIKE '%$search_value%'";
	$database->setQuery( $query );
	$rows = $database->loadObjectList();
                 if(sizeof($rows) <= 0)
                {       

                      echo "No matching rows";
                      break;
                }

foreach($rows as $row) {
	echo "<a href=\"index.php?option=$option&task=showCD&id=$row->id\">$row->cd_name</a><br />";
}
break;
  }
}

note that i added a line that quotes critical chars, e.g. " etc. - however, since i do not know which db u r usin, i used addslashes, u should replce this with the appropriate function in your db library - if u do not, users might be able to perform sql-injection attacks, so check your app and use functions that mask special chars on user input that is used in your sql query.
hth