[Resolved] what does this error mean

[k994519]

Hi guys

I keep getting this error know

Notice: Undefined index: group_id in c:\program files\apache group\apache\htdocs\edit_staff.php on line 35

Notice: Undefined index: module_id in c:\program files\apache group\apache\htdocs\edit_staff.php on line 37

both errors marked with a *

what does it mean?

I have got these fields and i thought i have defined them at the end of the code.........

here is my code

<?php

doCSS();
error_reporting(E_ALL); 
if(isset($_POST["submit"]))
{
	// Info has been submitted, check it:
	// Check login, description and description2 are not empty:
	{
	field_validator("staff_id", $_POST["staff_id"], "alphanumeric", 4, 15);

field_validator("first_name", $_POST["first_name"], "string", 4, 35);

field_validator("last_name", $_POST["last_name"], "string", 3,35);

field_validator("faulty_id", $_POST["faulty_id"], "number", 3,7);

field_validator("date_started", $_POST["date_started"], "string", 8,12 );

*field_validator("group_id", $_POST["group_id"], "number", 1,2);

*field_validator("module_id", $_POST["module_id"], "number", 1,7);

field_validator("module_id2", $_POST["module_id2"], "number", 1,7);

field_validator("module_id3", $_POST["module_id3"], "number", 1,7);

// build query:
$query="SELECT staff_id FROM staff WHERE staff_id='".$_POST["staff_id"]."'";

// Run query:
$result=mysql_query($query, $link) or die("MySQL query $query failed.  Error if any: ".mysql_error());


// If a row exists with that username, issue an error message:
	if( ($row=mysql_fetch_array($result)) )


	{
		//$messages[]="staff_id\"".$_POST["staff_id"]."\" already exists.  Try another.";
	}

if(empty($messages)) 
		{
// update db with new info:

//global $link;
$query = "UPDATE `staff` SET `first_name`='{$first_name}',`last_name`='{$last_name}', `faulty_id`='{$faulty_id}' `date_started`='{$date_started}', `group_id`='{$group_id}', `module_id`='{$module_id}',`module_id2`='{$module_id2}', `module_id3`='{$module_id3}' WHERE `staff_id`='{$staff_id}'";

$result=mysql_query($query) or die ("died on updating staff details. error returned if any:" .mysql_error()); 

			//print "staff details modified to system";

		}
	else 
		{
		displayErrors($messages);
		}	
}

$query = "select * from staff order by staff_id"; 
$result = mysql_query($query); 
//will work. then to put all the results in textboxes 
// Run query:
$result=mysql_query($query, $link) or die("MySQL query $query failed.  Error if anyzzzz: ".mysql_error());
$data = mysql_fetch_array($result); 

print "<center>";

print"<H3>Edit details of staff memeber <H3>";
print"<table>";?> 
<form action="<?=$_SERVER["PHP_SELF"]?>" method="POST">
<?
print "<input type=\"text\" name=\"staff_id\" value=\"{$data[0]}\"><br />\n"; 
echo "</tr>";
echo "<input type=\"text\" name=\"first_name\" value=\"{$data[1]}\"><br />\n"; 

echo "<input type=\"text\" name=\"last_name\" value=\"{$data[2]}\"><br />\n"; 

echo "<input type=\"text\" name=\"faulty_id\" value=\"{$data[3]}\"><br />\n"; 

echo "<input type=\"text\" name=\"date_started\" value=\"{$data[4]}\"><br />\n"; 

echo "<input type=\"text\" name=\"group_id\" value=\"{$data[5]}\"><br />\n"; 

echo "<input type=\"text\" name=\"module_id\" value=\"{$data[6]}\"><br />\n"; 

echo "<input type=\"text\" name=\"module_id2\" value=\"{$data[7]}\"><br />\n"; 

echo "<input type=\"text\" name=\"module_id3\" value=\"{$data[8]}\"><br />\n"; ?>

<input name="submit" type="submit" value="Submit">
</TABLE>
</center>
</form>

[LordShryku]

It means those indexes don't exist in your array. ie. $_POST["group_id"]

[swr]

You can supress the message using @ like this:

field_validator("staff_id", @$_POST["staff_id"], "alphanumeric", 4, 15);

Only supress the message when you really expect the value may be undefined (like with user-supplied input, as is the case here). Most of the time when you are using a variable it should be defined, so when it isn't it's usually a bug, and PHP will tell you it's not defined (helping you find the bug) in those cases where you're not using @.

[k994519]

hi

tried what you have suggested; seems that it can read the value in "group_id" but i cant seem to get rid of the problem

after using the @ option

getting this error message
died on updating staff details. error returned if any:You have an error in your SQL syntax. Check the manual that corresponds to your MySQL server version for the right syntax to use near 'date_started='2002-01-09',group_id='11',module_id='8',m

the query is a thus

$query = "UPDATE staff SET first_name='{$first_name}',last_name='{$last_name}', faulty_id='{$faulty_id}' date_started='{$date_started}', group_id='{$group_id}', module_id='{$module_id}',module_id2='{$module_id2}', module_id3='{$module_id3}' WHERE staff_id='{$staff_id}'";

[drew010]

try placing
error_reporting(E_ERROR | E_PARSE);
at the top of the script.
or just editing you php.ini file and set error_reporting to E_ERROR since its a windows install and im guessing its one you have at home.

[k994519]

Whats the limit in the number of varibles that can be processed with the update query

[Weedpacket]

No limit; but you've discovered that suppressing error messages with '@' doesn't make the error go away. The original "undefined index" message is telling you that (in this case) the form fields for group_id and module_id were empty. Because they were empty, the browser didn't include them in the form submission, which meant that $POST['group_id'] and $POST['module_id'] were never set.

You should always check your form variables exist before trying to use them. There are functions [man]isset[/man] and [man]empty[/man] to do this.

As for your new error - it's coming from MySQL and my suspicious is that you should be a bit more careful about you quote which bits with what kinds of quotes. You've quoted field names that don't need quoting, you've quoted values that probably shouldn't be quoted, and you've got mismatched quotes.

[k994519]

thanks everyone for your help........

i mistyped the group_id, and module_id
(duh brain!!!!)

got it working now!!