voting script problems

[iceb]

Hi

My voting script cannot show the voting-page anymore and keeps

showing the results instead...

What is wrong ? How can it be corrected ??

LINK:

http://m.iceb.dk/vote/vote.php

SCRIPT :

<?php
function head() {
include('config.php');
echo "<center><table width=\"200\" border=\"0\" cellpadding=\"1\" cellspacing=\"1\">
<tr><td bgcolor=\"$tableborder\">
<table width=\"198\" border=\"0\" cellpadding=\"0\" cellspacing=\"\" align=\"center\">
<tr><td bgcolor=\"$bgcolor\">";
}
function foot () {
echo "</td></tr></table></td></tr></table>";
}
function record() {
include('config.php');
$fp=fopen("$ip_file", "a+");
fputs ($fp,$REMOTE_ADDR."][".time()."\n");
fclose($fp);
}
function check($ip)
{
include('config.php');
global $valid;

$data = file($ip_file);
$now = time();

foreach ($data as $record) {
$subdata = explode('][', $record);
if ($now < ($subdata[1] + 1 * $timeout)) {
if ($ip == $subdata[0]) {
$valid=0;
break;
}
}
}
}

//##################### Save data ##############################
function save($answer){
global $answer;
include('config.php');
$data=file($datafile);
$subdata=explode("][",$data[$answer]);
$subdata[2]+=1;
$data[$answer]=implode("][", $subdata);
$data[$answer]=$data[$answer]."\n";
$fp=fopen($datafile,"w+");
$a=0;
do{
fputs($fp,$data[$a]);
$a++;
}while($a<count($data));
fclose($fp);
}
//########################## Show Form ############################
function form($PHP_SELF){
include('config.php');
head();
echo "<font size=\"$fontsize\" face=\"$font\" color=\"$textcolor\"><form method=\"post\" action=\"$PHP_SELF\"><p align=\"center\">";
$data=file($datafile);
$question=$data[0];
$nb_options=count($data)-1;
echo "<b>$question</b></p>";
for($nb=1;$nb <= $nb_options; $nb++){
$option=explode("][","$data[$nb]");
echo "<input type=\"radio\" name=\"answer\" value=\"$nb\"> ";
echo "$option[0]<br>";
}
echo "<input type=\"hidden\" name=\"save\" value=\"yes\">";
echo "<p align=\"center\"><input type=\"submit\" name=\"Submit\" value=\"Send\"></form></font>";
echo "<font size=\"$fontsize\" face=\"$font\" color=\"$textcolor\"><a href=\""; echo $PHP_SELF; echo "?action=results\">Vis mig resultaterne.</font></p>";

foot();
}
//################## Function to show results ########################
function results(){
include('config.php');
head();
$data=file($datafile);
$nb_answers=count($data);
$votes=0;
$a=1;
do{
$subdata=explode("][",$data[$a]);
$votes += $subdata[2];
$a++;
}while($a < $nb_answers);
$a=1;
$b="answerv";
$v=100/$votes;
echo "<p align=\"center\"><font size=\"$fontsize\" face=\"$font\" color=\"$textcolor\"><b>$data[0] ($votes Stemmer.)</b><br><br>";
do{
$subdata=explode("][",$data[$a]);
$av = $subdata[2] * $v;
echo "<font size=\"$fontsize\" face=\"$font\" color=\"$textcolor\">$subdata[0] -"; printf(" %01.1f", $av); echo"%<br>";
$p2v = 100-$av;
echo "<img src=\"$subdata[1]\" width=\"$av\" height=\"10\"><img src=\"$image\" width=\"$p2v\" height=\"10\"><br>";
$a++;
} while ($a < $nb_answers);
echo "<br>";

echo "<br><center><a href=\"javascript:history.go(-1)\">Gå Tilbage.</a><br>\n";

foot();
}
//###################### Engine ####################################
check($SERVER['REMOTE_ADDR']);
$action = (!empty($GET['action'])) ? $_GET['action'] : '';

if ($valid == 0 || $action == 'results') {
results();
} elseif ($save == 'yes' && $valid != 0) {
save($Answer);
record();
results();
} elseif ($action == 'save' && !empty($valid)) {
results();
} elseif ($action != 'save' && $valid != 0){
form($_SERVER['PHP_SELF']);
}
?>

[sidney]

try this hope it helps

 //###################### Engine #################################### 
$valid=1;
check($_SERVER['REMOTE_ADDR']); 
$action = (!empty($_GET['action'])) ? $_GET['action'] : ''; 

if ($save == 'yes' && $valid ==1) 
   { 
    save($Answer); 
    record();
     results();
    }
    elseif($valid == 0 || $action == 'results') 
    { 
     results();  

    } 
    else
    {
    form($_SERVER['PHP_SELF']); 
    {
?>
 

[iceb]

Hi

Well now there is an error in the last line of the code

How to fix it ?

Parse error: parse error in /var/www/epoxy/web2/icebdk/docs/vote/vote.php on line 127

[iceb]

Hi

I corrected it myself.....

Now it WILL show the voting page AND the results too.

Now the only problem is it will not vote how come ?

When somebody votes it writes the data to a txt file.

THE CORRECTED CODE :

<?php
function head() {
include('config.php');
echo "<center><table width=\"200\" border=\"0\" cellpadding=\"1\" cellspacing=\"1\">
<tr><td bgcolor=\"$tableborder\">
<table width=\"198\" border=\"0\" cellpadding=\"0\" cellspacing=\"\" align=\"center\">
<tr><td bgcolor=\"$bgcolor\">";
}
function foot () {
echo "</td></tr></table></td></tr></table>";
}
function record() {
include('config.php');
$fp=fopen("$ip_file", "a+");
fputs ($fp,$REMOTE_ADDR."][".time()."\n");
fclose($fp);
}
function check($ip)
{
include('config.php');
global $valid;

$data = file($ip_file);
$now = time();

foreach ($data as $record) {
$subdata = explode('][', $record);
if ($now < ($subdata[1] + 1 * $timeout)) {
if ($ip == $subdata[0]) {
$valid=0;
break;
}
}
}
}

//##################### Save data ##############################
function save($answer){
global $answer;
include('config.php');
$data=file($datafile);
$subdata=explode("][",$data[$answer]);
$subdata[2]+=1;
$data[$answer]=implode("][", $subdata);
$data[$answer]=$data[$answer]."\n";
$fp=fopen($datafile,"w+");
$a=0;
do{
fputs($fp,$data[$a]);
$a++;
}while($a<count($data));
fclose($fp);
}
//########################## Show Form ############################
function form($PHP_SELF){
include('config.php');
head();
echo "<font size=\"$fontsize\" face=\"$font\" color=\"$textcolor\"><form method=\"post\" action=\"$PHP_SELF\"><p align=\"center\">";
$data=file($datafile);
$question=$data[0];
$nb_options=count($data)-1;
echo "<b>$question</b></p>";
for($nb=1;$nb <= $nb_options; $nb++){
$option=explode("][","$data[$nb]");
echo "<input type=\"radio\" name=\"answer\" value=\"$nb\"> ";
echo "$option[0]<br>";
}
echo "<input type=\"hidden\" name=\"save\" value=\"yes\">";
echo "<p align=\"center\"><input type=\"submit\" name=\"Submit\" value=\"Send\"></form></font>";
echo "<font size=\"$fontsize\" face=\"$font\" color=\"$textcolor\"><a href=\""; echo $PHP_SELF; echo "?action=results\">Vis mig resultaterne.</font></p>";

foot();
}
//################## Function to show results ########################
function results(){
include('config.php');
head();
$data=file($datafile);
$nb_answers=count($data);
$votes=0;
$a=1;
do{
$subdata=explode("][",$data[$a]);
$votes += $subdata[2];
$a++;
}while($a < $nb_answers);
$a=1;
$b="answerv";
$v=100/$votes;
echo "<p align=\"center\"><font size=\"$fontsize\" face=\"$font\" color=\"$textcolor\"><b>$data[0] ($votes Stemmer.)</b><br><br>";
do{
$subdata=explode("][",$data[$a]);
$av = $subdata[2] * $v;
echo "<font size=\"$fontsize\" face=\"$font\" color=\"$textcolor\">$subdata[0] -"; printf(" %01.1f", $av); echo"%<br>";
$p2v = 100-$av;
echo "<img src=\"$subdata[1]\" width=\"$av\" height=\"10\"><img src=\"$image\" width=\"$p2v\" height=\"10\"><br>";
$a++;
} while ($a < $nb_answers);
echo "<br>";

echo "<br><center><a href=\"javascript:history.go(-1)\">Gå Tilbage.</a><br>\n";

foot();
}

//###################### Engine ####################################
$valid=1;
check($SERVER['REMOTE_ADDR']);

$action = (!empty($GET['action'])) ? $_GET['action'] : '';

if ($save == 'yes' && $valid ==1)

{

save($Answer);

record();
results();
}
elseif($valid == 0 || $action == 'results')

{

results();

}

else
{
form($_SERVER['PHP_SELF']);

}
?>

[sidney]

it doesnt show both on my test server but i havent got config.php running with it

maybe theres somthing in config causing problems

[iceb]

ok now I get these errors

Warning: file(ip.txt): failed to open stream: Permission denied in /var/www/epoxy/web2/icebdk/docs/vote/vote.php on line 23

Warning: Invalid argument supplied for foreach() in /var/www/epoxy/web2/icebdk/docs/vote/vote.php on line 26

how come ??

THESE ARE LINE

23-24:

$data = file($ip_file);
$now = time();

26-27:

foreach ($data as $record) {
$subdata = explode('][', $record);

[iceb]

ok here is config.php

any errors ?

<?php
$textcolor='#000000';
$linkcolor='#FFFFFF';
$bgcolor='#FFFFFF';
$tableborder='#336699';
$timeout='1';
$ip_file='ip.txt';
$font='Verdana, Arial, Helvetica, sans-serif';
$fontsize='2';
$datafile='data.txt';
?>

[sidney]

$ip_file is posibly not got the correct location of file, the file dosent exsist or file has not got right permission

if on unix it would need to be chmod 666 the file to read and write

this would also cause the foreach to be invalid as $data would not be an array

[iceb]

ok thanks now it works .......