[Resolved] Looping through an array?

[rupertbj]

Having problems getting this code to work:

            <?php
			$sql = "SELECT event_id FROM galleryTable";
			$result = mysql_query( $sql, $link );
			while ( $newArray = mysql_fetch_array($result) )
				{
				$event_id = $newArray['event_id'];
				print "$event_id";
				foreach ( $event_id as $val )
					{
					$sql = "SELECT * FROM galleryTable WHERE event_id = '$val' ORDER BY RAND() LIMIT 0,1";
					$result = mysql_query( $sql, $link );
					while ( $newArray = mysql_fetch_array($result) )
						{
						$title = $newArray['title'];
						$val = $newArray['event_id'];
						$fupload = $newArray['fupload'];
						include("event_name.php");
						print "<a href=\"gallery.php?event_id=$val&title=$title&fupload=$fupload\"><img src=\"/images/$val/$fupload\"></a></td><td width=58% align=left valign=top><p class=subtitle> $event_name </p>";
		  				}
					}
				}
		  	?>

I get the following error messages:

ruplex
Warning: Invalid argument supplied for foreach() in /users/rupertbj/domains/rupstar.co.uk/html/photos1.php on line 30
ruplex
Warning: Invalid argument supplied for foreach() in /users/rupertbj/domains/rupstar.co.uk/html/photos1.php on line 30
bellasgarden
Warning: Invalid argument supplied for foreach() in /users/rupertbj/domains/rupstar.co.uk/html/photos1.php on line 30

Line 30 is the foreach statement line. Obviously there is something wrong with my foreach statement, but I don't know what.

Any help most appreciated.

Many thanks in advance for your help.

Rupstar

[Weedpacket]

Nothing wrong with your foreach() statement; it's your $event_id - it's not an array. That's what makes it an invalid argument.

[sidney]

 <?php 
            $sql = "SELECT event_id FROM galleryTable"; 
            $result = mysql_query( $sql, $link ); 
            while ( $newArray = mysql_fetch_array($result) ) 
                { 
                $event_id = $newArray['event_id'];                 print "$event_id"; 
               // foreach ( $event_id as $val ) //event id is a string not an array so forach is invalid

              //  { 
                $sql1 = "SELECT * FROM galleryTable WHERE event_id = '$event_id' ORDER BY RAND() LIMIT 0,1"; //rename sqll because you used it before
                $result1 = mysql_query( $sql1, $link ); //rename result because you used it before

                while ( $newArray1 = mysql_fetch_array($result1) ) //rename newarray because you used it before

                    { 
                    $title = $newArray1['title']; 
                    $val = $newArray1['event_id']; 
                    $fupload = $newArray1['fupload']; 
                    include("event_name.php"); 
                    print "<a href=\"gallery.php?event_id=$val&title=$title&fupload=$fupload\"><img src=\"/images/$val/$fupload\"></a></td><td width=58% align=left valign=top><p class=subtitle> $event_name </p>"; 
                      } 
             //   } 
            } 
          ?> 
 

[rupertbj]

Weedpacket,

Thanks for that - but I now don't know how to get the variable $event_id to be an array so that I can apply the while statement to each item in the array.

I've tried a few things, but I think I'm drifting further off course.

Rupstar

[Weedpacket]

Originally posted by rupertbj
Weedpacket,

Thanks for that - but I now don't know how to get the variable $event_id to be an array so that I can apply the while statement to each item in the array.

I've tried a few things, but I think I'm drifting further off course.

Rupstar

In what way should $event_id be an array? Do you mean it to contain an array of all the event_ids from galleryTable? Or is it something that contains a bunch of event_ids delimited in some way?

I suspect it's either the former case or some third case entirely, but without knowing a fair bit more about what is supposed to be going on, it's a bit hard to suggest changes.

[rupertbj]

weedpacket,

This is a photogallery for my website www.rupstar.com.
The current code is as follows:

        <?php 
            $sql = "SELECT event_id FROM galleryTable"; 
            $result = mysql_query( $sql, $link ); 
            while ( $newArray = mysql_fetch_array($result) ) 
                { 
                $event_id = $newArray['event_id']; 
                print "$event_id"; 
				foreach ( 'event_id' as $val)
					{
                    $sql1 = "SELECT * FROM galleryTable WHERE event_id = '$val' ORDER BY RAND() LIMIT 0,1"; 
                    $result1 = mysql_query( $sql1, $link ); 
                    while ( $newArray1 = mysql_fetch_array($result1) ) 
                        { 
                        $title = $newArray1['title']; 
                        $val = $newArray1['event_id']; 
                        $fupload = $newArray1['fupload']; 
                        include("event_name.php"); 
                        print "
					        <tr bgcolor=#666666>
								<td width=21% align=right valign=top> 
									<a href=\"gallery.php?event_id=$val&title=$title&fupload=$fupload\"><img src=\"/images/$val/$fupload\"></a>
								</td>
								<td width=58% align=left valign=top>
									<p class=subtitle> $event_name </p>
								</td>
							</tr>
							<tr bgcolor=#666666>
								<td colspan=2 align=right valign=top>
									<hr noshade color=#CC3333>
								</td>
							</tr>
						"; 
                        } 
					}
                } 
              ?>

The current error message is as follows:

ruplex
Warning: Invalid argument supplied for foreach() in /users/rupertbj/domains/rupstar.co.uk/html/photos1.php on line 28
ruplex
Warning: Invalid argument supplied for foreach() in /users/rupertbj/domains/rupstar.co.uk/html/photos1.php on line 28
bellasgarden
Warning: Invalid argument supplied for foreach() in /users/rupertbj/domains/rupstar.co.uk/html/photos1.php on line 28

Line 28 is the foreach line.

So, from the output I can see that when I print $event_id on the line before the foreach statement that the output is ruplex, ruplex, bellasgarden (each of these being a page of photos in the photogallery).

What I want to be able to do is loop through the output code until all three outputs (ruplex, ruplex and bellasgarden) have been processed - basically assigning each output to $val once each.

I also want to strip out duplicates (i.e. just have one ruplex, although there are several entries under this $event_id in the DB table).

I hope that makes sense!

Rupstar

[Weedpacket]

Okay so $event_id is a string "ruplex, ruplex, bellasgarden" and you want to build an array('ruplex', 'bellasgarden') from that. As you've found, PHP isn't going to do that for you automatically (because how is it to know where one array entry leaves off and the next begins?). I don't know how consistent the use of spaces after the comma is, so I'll use regular expressions.

$event_ids = preg_split(",\\s*", $event_id);

will break the string into pieces at each point where there is a comma (possibly followed by some whitespace). If you are consistent about the "comma followed by one space" rule, then [man]explode[/man] will be a much more efficent method.

Either way, after that, [man]array_unique[/man] will do stuff for you.

[rupertbj]

Weedpacket,

I feel I'm making progress.

There was no delimiter (comma followed by whitespace) between the entries previously. The entries come from a MySql DB and I didn't want to rename them all so I amended the SELECT query.

Then I've used explode and array unique, but I appear to have created 3 arrays, one for each variable, and ruplex is still duplicated.

From

print_r "unique_id"; 

the following result is returned

Array ( [0] => ruplex, ) Array ( [0] => ruplex, ) Array ( [0] => bellasgarden, )

My code is below for your scrutiny. Thank you very much for all your help so far.

        <?php 
            $sql = "SELECT CONCAT(event_id,', ') AS event_id1 FROM galleryTable"; 
            $result = mysql_query( $sql, $link ); 
            while ( $newArray = mysql_fetch_array($result) ) 
                { 
                $event_id1 = $newArray['event_id1'];
				// print_r($event_id1);
				$event_ids = explode("/n", $event_id1);
				$unique_id = array_unique($event_ids);
				print_r($unique_id);
				foreach ( $unique_id as $val)
				{
                $sql1 = "SELECT * FROM galleryTable WHERE event_id = '$val' ORDER BY RAND() LIMIT 0,1"; 
                $result1 = mysql_query( $sql1, $link ); 
                while ( $newArray1 = mysql_fetch_array($result1) ) 
                    { 
                    $title = $newArray1['title']; 
                    $val = $newArray1['val']; 
                    $fupload = $newArray1['fupload']; 
                    include("event_name.php"); 
                    print "
			        <tr bgcolor=#666666>
						<td width=21% align=right valign=top> 
							<a href=\"gallery.php?val=$val&title=$title&fupload=$fupload\"><img src=\"/images/$val/$fupload\"></a>
						</td>
						<td width=58% align=left valign=top>
							<p class=subtitle> $event_name </p>
						</td>
					</tr>
					<tr bgcolor=#666666>
						<td colspan=2 align=right valign=top>
							<hr noshade color=#CC3333>
						</td>
					</tr>
					"; 
                    }
				} 
                } 
              ?>

Rupstar

[Weedpacket]

Originally posted by rupertbj
Weedpacket,

I feel I'm making progress.

There was no delimiter (comma followed by whitespace) between the entries previously. The entries come from a MySql DB and I didn't want to rename them all so I amended the SELECT query.

Then I've used explode and array unique, but I appear to have created 3 arrays, one for each variable, and ruplex is still duplicated.

Hoom, I'm starting to get confused; how are they being stored? From your earlier post I thought you meant that they were in a string "this, that, the other" (delimited somehow, because if you can't tell where one leaves off and the next begins...), but now they look like they're being stored one entry to a record, and you're wanting a list of all of the entries. That would just be a SELECT DISTINCT event_id FROM galleryTable", then loop through those putting each event_id into an array of event_ids

$event_ids = array();
while($row = mysql_fetch_array($event_id_query))
    $event_ids[]=$row['event_id'];

and then you can foreach() over $event_ids.

[rupertbj]

OK. So I've amended the code thus:

        <?php  

			$sql = "SELECT DISTINCT event_id FROM galleryTable";  

            $event_id_query = mysql_query( $sql, $link );  

			$event_id = array(); 
			print_r($event_id); 
			while($row = mysql_fetch_array($event_id_query)) 
    		$event_ids[]=$row['event_id'];
            foreach ( $event_ids as $event_id ) 
	            { 
                $sql1 = "SELECT * FROM galleryTable WHERE event_id = '$event_id' ORDER BY RAND() LIMIT 0,1";  

                $result1 = mysql_query( $sql1, $link );  

                while ( $newArray1 = mysql_fetch_array($result1) )  

                    {  

                    $title = $newArray1['title'];  

                    $event_id = $newArray1['event_id'];  

                    $fupload = $newArray1['fupload'];  

                    include("event_name.php"); 
                    print " 
                    <tr bgcolor=#666666> 
                        <td width=21% align=right valign=top> 
                            <a href=\"gallery.php?event_id=$event_id&title=$title&fupload=$fupload\"><img src=\"/images/$event_id/$fupload\"></a> 
                        </td> 
                        <td width=58% align=left valign=top> 
                            <p class=subtitle> $event_name </p> 
                        </td> 
                    </tr> 
                    <tr bgcolor=#666666> 
                        <td colspan=2 align=right valign=top> 
                            <hr noshade color=#CC3333> 
                        </td> 
                    </tr> 
                    ";  

                    } 
                }  

              ?> 

But $event_id always equals ruplex. What am I doing wrong now?

Rupert

[rupertbj]

Right!!!!!!!!!!!! Damn.................my include file is causing the problems!

This is the contents of the include file event_name.php:

<?php
if ($event_id = "bellasgarden") { $event_name = "Bellas's Garden (June 2003)"; }
if ($event_id = "ruplex") { $event_name = "Rupert and Lexi's birthday party at Tendido Cero and Fire House (June 2003)"; }
?>

But I don't know whay this affects the foreach loop to return $event_id as ruplex consistently, when the other variables do change?!?!

Any help much appreciated!

Rupert

[sidney]

  $sql = "SELECT DISTINCT event_id FROM galleryTable";   

            $event_id_query = mysql_query( $sql, $link );   

            $event_id = array();  

            print_r($event_id);  

            while($row = mysql_fetch_array($event_id_query)) 
			{ 
            //$event_ids[]=$row['event_id']; 

            $sql1 = "SELECT * FROM galleryTable WHERE event_id = '".$row['event_id']."' ORDER BY RAND() LIMIT 0,1";   
            $result1 = mysql_query( $sql1, $link );   
            while ( $newArray1 = mysql_fetch_array($result1) )   
                {   
                $title = $newArray1['title'];   
                $event_id = $newArray1['event_id'];   
                $fupload = $newArray1['fupload'];   
                include("event_name.php");  
                print "  
                <tr bgcolor=#666666> 
                    <td width=21% align=right valign=top> 
                        <a href=\"gallery.php?event_id=$event_id&title=$title&fupload=$fupload\"><img src=\"/images/$event_id/$fupload\"></a> 
                    </td> 
                    <td width=58% align=left valign=top> 
                        <p class=subtitle> $event_name </p> 
                    </td> 
                </tr> 
                <tr bgcolor=#666666> 
                    <td colspan=2 align=right valign=top> 
                        <hr noshade color=#CC3333> 
                    </td> 
                </tr> 
                ";   
                }  
            }     

[rupertbj]

Thanks for your alternative on the $row bit, but the other bit works now that I commented out include("event_name.php");

See above for what event_name.php contains. Not sure whay this is preventing the foreach loop functioning properly.

Thanks for all help so far!

Rupert

[sidney]

 <?php 
if ($event_id = "bellasgarden") { $event_name = "Bellas's Garden (June 2003)"; } 
if ($event_id = "ruplex") { $event_name = "Rupert and Lexi's birthday party at Tendido Cero and Fire House (June 2003)"; } 
?>  

you missed the extra = it should be

  <?php 
if ($event_id == "bellasgarden") { $event_name = "Bellas's Garden (June 2003)"; } 
if ($event_id == "ruplex") { $event_name = "Rupert and Lexi's birthday party at Tendido Cero and Fire House (June 2003)"; } 
?> 

[rupertbj]

sidney - you are a star!

Thanks for that!