[Resolved] foreach ?

[ejwf]

I am struggling with a foreach statement.......
Can you have a foreach statement followed by a query? e.g

foreach($_POST['size'] as $key => $value) 
{
$query = "INSERT INTO tblResults (MachineRef,sizes,colour,LoadedBy,LoadedWhen)
		VALUES ('$MachineID','$size','$colour','$Username',NOW())";
$result2 = mysql_query($query)
	or die(mysql_error());
}

I have tried this code but get the error message "Warning: Invalid argument supplied for foreach() ...." for the line with the foreach statement in it.

I have looked in the php manuals but i can only find the foreach statement being followed by echo or print.

thanks in advance for any advice....

[laserlight]

$_POST['size'] is not an array.

[ejwf]

thanks for the reply, but I

I have created an array in a form on a previous page

$query = "SELECT (Model) AS Model, (SerialNo) AS SerialNo, (CommonName) AS Location FROM `tblMachine` WHERE SectionRef = '$SectionRef' "; 
$result2 = mysql_query($query) 
or die(mysql_error());

if ($result2) 
{			
echo '<table align="centre" cellspacing="0" cellpadding="0"> 
<tr>
<td align="left"><b>Model</b></td>
<td align="left"><b>Serial Number</b></td>
<td align="left"><b>Location</b></td><td align="left"></td>
</tr>';	
while ($row2 = mysql_fetch_array($result2,MYSQL_NUM)) 
{ 
    echo "<form action=\"process.php\" method=\"post\"> 
<tr>    <font face=\"Arial, Helvetica, sans-serif\"> 
<td width=\"70\" align=\"left\"> {$row2[0]}</td> 
<td width=\"120\" align=\"left\"> {$row2[1]}</td> 
<td width=\"200\" align=\"left\"> {$row2[2]}</td> 
<td width=\"200\" align=\"left\"> {$row2[3]} Size <input type=\"text\" name=\"Size[]\"> </td> 
<td width=\"300\" align=\"left\"> {$row2[4]} Colour <input type=\"text\" name=\"Colour[]\"></td><br> 
</font></tr>\n"; 
}  // close while loop 
} 	// close if

I want the foreach statement to be in the file process.php to INPUT INTO the database the readings for Size and Colour that have been put in the form by the viewer, as I am expecting a number of records to be created, I wanted a foreach statement to loop all of the records into the database........

Can you advise how I do this........ thanks

[ahundiak]

Perhaps your code is being executed without the data being posted? Try something like

if (isset($POST['Size'])) {
foreach($POST['Size']...
}

[ejwf]

it is what comes after the

 foreach($_POST['size'] as $key => $value)  

{ 

that is the question!!
is it correct code to have a $query after the foreach statement? and what would be the correct structure for this statment......?

thanks guys

[mtimdog]

Your structure looks fine, I advise to re-read ahundiak's post since the error is complaining about the foreach and not the query itself.

[ejwf]

Thanks guys, I used anhundiaks' suggestion, it didn't work straight away (and to be honest I'm not sure what I changed in the code that made it work OK!) but it is now adding a record into the database for every record created by the query on the first page..........the code I ended up with is.....

if (isset($_POST['size'])) 
{ 
foreach($_POST['size']  as $key => $value)  

{
$query = "INSERT INTO tblResults (MachineRef,size,colour,LoadedBy,LoadedWhen)
		VALUES ('$MachineID','$size','$colour','$Username',NOW())";
$result2 = mysql_query($query)
	or die(mysql_error());
}}

.......having said that I am nearly there, but not quite!! because although it is adding the records, it isn't adding the results. I think this is something wrong in the way I have written the names of the values in the array so I am going to go back and check it all of the way through.

thanks again.🙂

[buck2bcr]

It may seem like a stupid question but...

Where do the variables for the query get set.

$MachineID  

$size
$colour
$Username

I'm assuming that $MachineID and $Username may be set above this loop, but what about $size and $color.

They could come out of the array that you are doing the foreach with, but don't they need to be set before the insert can do its thing?

It's late maybe I'm missing something.

[ejwf]

yes, thanks for this........but I have set the variables for all of the INSERT INTO query earlier in the code. I just need to make sure they are all spelt OK etc. etc.

[mtimdog]

May I ask why you are using the foreach since you're not using $key or $value??

[ejwf]

not sure exactly what you mean mtimdog.......
the reason (I think) I am using foreach is because I have a form on one page that say retreives a list of 4 different machines and the user inputs a reference for size and colour against each of these 4 machines. the code in process.php (to process the form results) that I had previously only added the results of the last machine into the database, not all 4, now I have added the foreach statement it adds a record for each of the machines, I just need to work out now how to get the results (size / colour etc.) of the form to show in the database aswell.........

[mtimdog]

post some code of the form if you still need some help. I asked that question because the query wasn't inserting anything that dealt with $_POST['size'], so I figured it wasn't quite done yet.

[ejwf]

thanks mtimdog.
I have got another thread open on the coding forum trying to deal with this problem.... it shows all the code I hav got for the form and for the form processing. If you could take a look that would be great - the thread is called 'problem setting variables ' on the coding forum.
Meantime I'm going to close this thread becuase you have answered my original query.
thanks again