problem setting variables

[ejwf]

hello

I have a form for users to input data into, and the results of this form go into the database. The code I am using 'works' OK in that it does not come up with any error messages, but whilst it created new records in the results table on the database it does not put the information into these records........

Code I have got so far is as follows;
1) form for users to input information.

$query = "SELECT `SectionRef` FROM `tblUser` WHERE `CLogIn` = '$username'"; 
$result = mysql_query($query) 
   or die(mysql_error());
$row = mysql_fetch_array($result); 
$SectionRef = $row["SectionRef"]; 

$query = "SELECT `List` FROM `tblMachine` WHERE `SectionRef` = '$SectionRef'"; 
$result1 = mysql_query($query) 
   or die ("no such info"); 
$row1 = mysql_fetch_array($result1); 
$List = $row1["List"]; 

echo "<font face=\"Arial, Helvetica, sans-serif\"><p><i> Hello <b>$username</b>, Please enter the metre readings here; </i></p></font>";

//list equipment
$query = "SELECT (Model) AS Model, (SerialNo) AS SerialNo, (CommonName) AS Location FROM `tblMachine` WHERE SectionRef = '$SectionRef' "; 
$result2 = mysql_query($query) 
or die(mysql_error());

if ($result2) 
{			
echo '<table align="centre" cellspacing="0" cellpadding="0"> 
<tr>
<td align="left"><b>Model</b></td>
<td align="left"><b>Serial Number</b></td>
<td align="left"><b>Location</b></td><td align="left"></td>
</tr>';

while ($row2 = mysql_fetch_array($result2,MYSQL_NUM)) 
{ 
    echo "<form action=\"process.php\" method=\"post\"> 
<tr>    <font face=\"Arial, Helvetica, sans-serif\"> 
<td width=\"70\" align=\"left\"> {$row2[0]}</td> 
<td width=\"120\" align=\"left\"> {$row2[1]}</td> 
<td width=\"200\" align=\"left\"> {$row2[2]}</td> 
<td width=\"200\" align=\"left\"> {$row2[3]} Size <input type=\"text\" name=\"Size[]\"> </td> 
<td width=\"300\" align=\"left\"> {$row2[4]} Colour <input type=\"text\" name=\"Colour[]\"></td><br> 
</font></tr>\n"; 
}  // close while loop 
} 	// close if

echo '</table></font>'; 

echo "<br><p align=\"center\"><input type=\"submit\" name=\"submit\" value=\"Submit\"> 
</form>"; 

2) process.php code

$query = "SELECT `SectionRef` FROM `tblUser` WHERE `CLogIn` = '$username'";
$result = mysql_query($query)
   or die(mysql_error());
$row = mysql_fetch_array($result);
$SectionRef = $row["SectionRef"];

$query = "SELECT (Model) AS Model, (SerialNo) AS SerialNo, (CommonName) AS CommonName FROM `tblMachine` WHERE SectionRef = '$SectionRef' "; 
$result1 = mysql_query($query) 
or die(mysql_error());
extract ($result1);

$Model = (Model);
$SerialNo = (SerialNo);
$CommonName = (CommonName);
$Size = ($_POST(Size);
$Colour = ($_POST(Colour);

$username = trim($username);
$username = strip_tags($username);
$Size = trim($Size);
$Size = strip_tags($Size);
$Colour = trim($Colour);
$Colour = strip_tags($Colour);

if (isset($_POST['Size'])) 
{ 
foreach($_POST['Size']  as $key => $value)  

{
$query = "INSERT INTO tblResults (MachineRef,Size,Colour,LoadedBy,LoadedWhen)
		VALUES ('$MachineID','$Size','$Colour','$username',NOW())";
$result2 = mysql_query($query)
	or die(mysql_error());
}}

echo "<p></p><p></p><p></p>
<p><div align=\"center\"><font face=\"Arial, Helvetica, sans-serif\" size=\"3\"><b><font color=\"#FF0000\">Thank you $username, <br> <br> your readings have been added.</font></b></font></div></p>"

3)I have set up $username as a session variable, back on the initial login page with the code

session_start();
		 $_SESSION['username'] = $row[1];
		 $_SESSION['user_id'] = $row[0];

and I have session_start(); at the very top of each subsequent page.

Can anyone see where I am going wrong........

[mtimdog]

1) You're echoing the <form ..> inside the while loop...try moving it outside the loop like </form>

2) since you're grouping both size and color (and machineid)...I think you should use a for loop in process.php

3) On the first page, try putting a hidden variable in the forloop with the machineid so you know which one the size/colors are linked to.

On to the for loop

<?

if (isset($_POST['size']){

$arr_size = count($_POST['size']);
for (int i = 0;$i < $arr_size; $i++){
    $size=strip_tags(trim($_POST['size'][$i]));
    $color=strip_tags(trim($_POST['color'][$i]));
    $machineid = strip_tags(trim($_POST['machineid'][$i]));
//don't have yet

//do your query here
$query = "INSERT INTO tblResults (MachineRef,Size,Colour,LoadedBy,LoadedWhen) 
        VALUES  ('$machineid','$size','$color','$_SESSION[username]',NOW())
"; 
$result2 = mysql_query($query) 
    or die(mysql_error()); 

}


}

HTH

[ejwf]

thanks for this mtimdog, I'm sure we are nearly there, however I have cut an pasted this code into process.php but I am getting a parse error on the line
for (int i = 0;$i < $arr_size; $i++)
seeing as I am not entirely sure what this line of code says, I am not sure if there is an error !! can you see anything - thanks

[mtimdog]

sorry...old c++ habit

for ($i=0;$i< $arr_size;$i++)

you don't need to say int i, plus i should be $i. in my defense, I corrected my language halfway through the for declaration:p

[ejwf]

thank you, it is now adding the size information to the database, and the NOW() function is working OK, but it isn't adding the colour, machineid, username into the database table. Is there something I can add to the code that can trigger this to happen?

another quick question, I added the hidden field to the form like you suggested, but it is showing it (it isn't hidden!) I have added into the form code;

<td width=\"10\" align=\"left\"> {$row2[3]} <input type=\"hidden\" name=\"MachineId[]\"></td> 

is this right?

sorry to keep asking questions but I get so frustrated when I can't work out what is going wrong and I don't know anywhere near enough php to work things out for myself.
with this in mind, if you have a minute, can you explain what

if (isset($_POST['Size'])) 
{ 
$arr_size = count($_POST['Size']); 
for ($i=0;$i< $arr_size;$i++) 
{ 

actually says and what / how it does it so I can learn for the future

a million thank yous..........

[mtimdog]

first thing is first....I write color, you write colour. That should fix color not being inserted. As for machineid, you have to set it like

<input type=\"hidden\" name=\"s\" value=\"{$row2[3]}\"> so it knows the value....that should take care of machineid.

Now, onto username.

if
echo $SESSION['username']...does it work? If it does...then it should be inserting it ok, but you could try something like

<?
$query="... username='" . $_SESSION['username'] . "' ...";

?>

to break it out of the query.

As for

if (isset($_POST['Size']))  

{  

$arr_size = count($_POST['Size']);  

for ($i=0;$i< $arr_size;$i++)  

{

All this does is say if there is a variable Size that has been posted do the following:

set a var (arr_size) to the size of an array ($_POST['Size'])

For loop loop from a variable (i) from 0 to less than var (arr_size). Increment by 1.

[ejwf]

I have worked on all of your suggestions but I still cannot get the results into the table.

I must admit I wasted a lot of time last night and this morning re-writting everything from scratch because I changed something and the next thing that happened was I could even get the results of the first query into the table on the first page....... it turns out (I think ?!) that the session kept timing out whilst I was fiddling with the code and now if I log out completely and go back in it works OK (us newbies are hopeless I know!)

ANYHOW.........
this is what I have got so far

code for creating query on database and showing results in table format for user to add information.....

 session_start ();	
  $_SESSION['user_id'] = $row[0];
  $_SESSION['username'] = $row[1];

require_once ('../connect.php');   //connect to the database							
include ('header.php');	//show header

$query = "SELECT `SectionRef` FROM `tblUser` WHERE `CLogIn` = '$username'"; 
$result = mysql_query($query) 
   or die(mysql_error());
$row = mysql_fetch_array($result); 
$SectionRef = $row["SectionRef"]; 

$query = "SELECT (Model) AS Model, (SerialNo) AS SerialNo, (CommonName) AS Location, (MachineId) AS MachineId FROM `tblMachine` WHERE SectionRef = '$SectionRef' "; 
$result2 = mysql_query($query) 
or die(mysql_error());

if ($result2) 
{					
echo '<table align="centre" cellspacing="0" cellpadding="0"> 
<tr>
<td align="left"><b>Model</b></td>
<td align="left"><b>Serial Number</b></td>
<td align="left"><b>Location</b></td>
<td align="left"></td>
</tr>';

while ($row2 = mysql_fetch_array($result2,MYSQL_NUM)) 
{ 
echo "<form action=\"process.php\" method=\"post\"> 
<tr>    <font face=\"Arial, Helvetica, sans-serif\"> 
<td width=\"70\" align=\"left\"> {$row2[0]}</td> 
<td width=\"120\" align=\"left\"> {$row2[1]}</td> 
<td width=\"200\" align=\"left\"> {$row2[2]}</td> 
<td width=\"20\" align=\"left\"> {$row2[3]} <input type=\"hidden\" name=\"s\" value\"{$row2[3]}\"> </td> 
<td width=\"200\" align=\"left\"> {$row2[4]} Size <input type=\"text\" name=\"Size[]\"> </td> 
<td width=\"300\" align=\"left\"> {$row2[5]} Colour <input type=\"text\" name=\"Colour[]\"></td><br> 
</font></tr>\n"; 
}  // close while loop 
} // close if

echo '</table></font>'; 

echo "<br><p align=\"center\"><input type=\"submit\" name=\"submit\" value=\"Submit\"> 
</form>"; 

code for page process.php to put the results of the form into a results table in the database.......

session_start ();

require_once ('../connect.php');   //connect to the database
include ('header.php');	//show header

echo "machineid = '$MachineId' <br>
Size= '$Size' <br>
Colour = '$Colour' <br>
Username = '$username' ";

if (isset($_POST['Size'])) 
{ 
$arr_size = count($_POST['Size']); 
for ($i=0;$i< $arr_size;$i++) 
{ 
    $Size = strip_tags(trim($_POST[Size][$i])); 
    $Colour = strip_tags(trim($_POST[Colour][$i])); 
    $MachineId = strip_tags(trim($_POST[MachineId][$i])); 
    $username =  strip_tags(trim($_SESSION[username][$i])); 

$query = "INSERT INTO tblResults (MachineRef,Size,Colour,LoadedBy,LoadedWhen)
VALUES ('$MachineId','$Size','$Colour','$username',NOW())";
$result2 = mysql_query($query)
	or die(mysql_error());

}
}

echo "<p></p><p></p><p></p>
<p><div align=\"center\"><font face=\"Arial, Helvetica, sans-serif\" size=\"3\"><b><font color=\"#FF0000\">Thank you '$username', <br> <br> your details have been added.</font></b></font></div></p>"

I have added the echo on the 4 fields of information I want to add to the database (Size,Colour,MachineId,Username) to test if they work. The output I am getting is - Size = 'Array' Colour = '' MachineID = '' username = 'John.Lennon' .
- From this I know that the username variable works, but it still isn't going into the database.
- The Size information is being added
- Colour and MachineId are not being added
However on $username, I am also trying to put this variable in the echo thank you message, but it does not work.

So I know I am asking a lot here, but things I am stuck on are;
- how to get all 4 fields / variables into the table for each record created in the very first query?
- why won't the username variable work on the last echo thankyou message?
- on the table in the first code, why isn't the hidden field hidden (i can see the information in the table) ?

If anyone can have a look at this and see where I am going wrong I would be very grateful. (mtimdog has been a great help so far, but I feel as if I am taking up far too much of his time 😉 )

thanks in advance to anyone who has a look......

[mtimdog]

The machine id is not hidden because you are echoing out {$row2[3]} before the hidden statement.

Since the form is inside the while loop...it is creating multiple forms instead of just one. You should put the form outside of the while loop. Also, you have the beginning of the form inside of the table, but the ending of the form outside....You should probly choose which one.

For the MachineID--- you currently have

<input type=\"hidden\" name=\"s\" value\"{$row2[3]}\"> 

//you need

<input type=\"hidden\" name=\"MachineId\" value\"{$row2[3]}\"> 

I made a mistake--delete this out of the for loop

$username = strip_tags(trim($_SESSION[username][$i]));
(I got carried away)

Not sure why Colour isn't working....try this and get back to us.

[ejwf]

thanks for getting back to me on this........

1) I have removed the echo prior to the hidden field and have given it the correct name - that is OK now.

2) I have moved the form to outside the while loop and outside of the table..... but it isn't finding the file process.php when you click on submit - getting the HTTP file not found error message, is this a case of me not having the correct code?
I have put

echo '<form action=\"process.php\" method=\"post\"> ';

while ($row2 = mysql_fetch_array($result2,MYSQL_NUM)) 
{ 
echo "<tr><font face=\"Arial, Helvetica, sans-serif\"> 
<td width=\"70\" align=\"left\"> {$row2[0]}</td> 
<td width=\"120\" align=\"left\"> {$row2[1]}</td> 
<td width=\"200\" align=\"left\"> {$row2[2]}</td> 
<td width=\"20\" align=\"left\"> <input type=\"hidden\" name=\"MachineId\" value\"{$row2[3]}\">  </td> 
<td width=\"200\" align=\"left\"> {$row2[4]} Size <input type=\"text\" name=\"Size[]\"> </td> 
<td width=\"300\" align=\"left\"> {$row2[5]} Colour <input type=\"text\" name=\"Colour[]\"></td><br> 
</font></tr>\n"; 
}  // close while loop 
} 	// close if

echo '</table></font>'; 
echo "<br><p align=\"center\"><input type=\"submit\" name=\"submit\" value=\"Submit\"> 
</form>"; 

3) I have taken out the striptags / trim on $username as you suggested.

but because it now can't find the process.php file I can't tell what effect all of this is having on submitting the results to the database !!!

thanks in advance,

[mtimdog]

I meant to tell you to have the form like

<form>

<table>
(while loop)
</table>
<submit button>
</form>

....also, you could make the submit button inside of the table to have the same effect.

[ejwf]

I've still not got it right....... it is forwarding the page in the URL - http://domain.com/"process.php/"?PHPSESSID=c8265ba3e731e3af12cb537bc7eb9cd6&MachineId=&Size%5B%5D=22&Colour%5B%5D=33&MachineId=&Size%5B%5D=44&Colour%5B%5D=55&MachineId=&Size etc.etc.etc.

I have got the code as follows;

$query = "SELECT (Model) AS Model, (SerialNo) AS SerialNo, (CommonName) AS Location, (MachineId) AS MachineId FROM `tblMachine` WHERE SectionRef = '$SectionRef' "; 
$result2 = mysql_query($query) 
or die(mysql_error());

if ($result2) 
{		
echo '<form action=\"process.php\" method=\"post\"> ';

echo '<table align="centre" cellspacing="0" cellpadding="0"> 
<tr>
<td align="left"><b>Model</b></td>
<td align="left"><b>Serial Number</b></td>
<td align="left"><b>Location</b></td>
<td align="left"></td>
</tr>';

while ($row2 = mysql_fetch_array($result2,MYSQL_NUM)) 
{ 
echo "<tr><font face=\"Arial, Helvetica, sans-serif\"> 
<td width=\"70\" align=\"left\"> {$row2[0]}</td> 
<td width=\"120\" align=\"left\"> {$row2[1]}</td> 
<td width=\"200\" align=\"left\"> {$row2[2]}</td> 
<td width=\"20\" align=\"left\"> <input type=\"hidden\" name=\"MachineId\" value\"{$row2[3]}\">  </td> 
<td width=\"200\" align=\"left\"> {$row2[4]} Size <input type=\"text\" name=\"Size[]\"> </td> 
<td width=\"300\" align=\"left\"> {$row2[5]} Colour <input type=\"text\" name=\"Colour[]\"></td><br> 
</font></tr>\n"; 
}  // close while loop 
} 	// close if		
echo '</table></font>'; 
echo "<br><p align=\"center\"><input type=\"submit\" name=\"submit\" value=\"Submit\"> 
</form>";