Topsites Site

ste_h

Hi everyone,

Im working on a site for a friend and its a topsites site.
But i cant seem to get the ranking script right.

This is the script:

<?php

function _rank()
{
  $pos = "SELECT * FROM site";
  $pos = mysql_query($pos);

  if ($pos)
  {
    while ( $a = mysql_fetch_array($pos) )
    {
      $pos = "SELECT * FROM site";
      $pos = mysql_query($pos);

  if ($pos)
  {
    while ( $b = mysql_fetch_array($pos) )
    {
      if ($a[avarage_1] > $b[avarage_1] AND $a[avarage_2] > $b[avarage_2])
      {
        $move = mysql_query("UPDATE site SET rank = rank - 1, oldrank = '$a[rank]' WHERE ID = '$a[ID]'");
        $move = mysql_query("UPDATE site SET rank = rank + 1, oldrank = '$b[rank]' WHERE ID = '$b[ID]'");
      }
      elseif ($a[avarage_1] < $b[avarage_1] AND $a[avarage_2] < $b[avarage_2])
      {
        $move = mysql_query("UPDATE site SET rank = rank + 1, oldrank = '$a[rank]' WHERE ID = '$a[ID]'");
        $move = mysql_query("UPDATE site SET rank = rank - 1, oldrank = '$b[rank]' WHERE ID = '$b[ID]'");
      }
    }
  }
}
  }
}

?>

Heres the site:
http://www.rs.pauliohosting.net/topsites

jpmoriarty

you can't put things like "$a[ID]" into a query, you need to break out first.

NOT

$move = mysql_query("UPDATE site SET rank = rank - 1, oldrank = '$a[rank]' WHERE ID = '$a[ID]'");

but

$move = mysql_query("UPDATE site SET rank = rank - 1, oldrank = '".$a[rank]."' WHERE ID = '".$a[ID]."'");

ste_h

Its not that you cant because that parts working fine.

Thats why i posted the site. If you look at it every time you click
go to the home page it moves the rank up or down.

I only want it to do this once sortof thing.

So it doesnt move everytime you go on the page.

jpmoriarty

okay then you'll need to set a cookie or something when someone clicks on a link, and then see if they have that cookie set next time they click on the link. if they have, then don't increase the counter, if they don't have the cookie, then increase it.

ednark

you will have to track which specific user is looking at each page... so that you can't have someone simply sit on a page and hit refresh

you can do this with sessions in php

give each visitor's SESSION an array of page names or uri's,

if the current pages name is in the list {
they have already visited it, and skip the ranking
}

if the current page is not in the list {
do the ranking and add page to the list
}

if ( in_array('this_page','$_SESSION['visited']) ) {
    /// Do nothing
} else {
    $_SESSION['visited'][] = 'this_page';
    do_ranking('this_page');
}

session's aren't untrickable, but i think this is what you are looking for

cvsherri

if you wanted, and this would take up some DB space, but you could ue IP address tracking.. that would make it a bit harder to cheat... then set a datateime stamp so any given IP can only incriment any given page every so often... say like 5 days or somthing..

That is how I did it in ASP anyway...

Basicaly, we set a script to clean the DB of any records older then 5 days, (helps manage DB size too) and when a user click thru, simply look to see if that IP is in the DB for that site ID and viola..

but thats just my opinion... 🙂 G/L