[Resolved] [Resolved] MySQL errors

hunkyjack

I am trying to make a simple php member script, but when I rty to login I get these errors

Warning: mysql_select_db(): Access denied for user: 'ma135yh@localhost' (Using password: NO) in /home/ma135yh/public_html/zone/member/login.php on line 39

Warning: mysql_select_db(): A link to the server could not be established in /home/ma135yh/public_html/zone/member/login.php on line 39

Warning: mysql_query(): Access denied for user: 'ma135yh@localhost' (Using password: NO) in /home/ma135yh/public_html/zone/member/login.php on line 41

Warning: mysql_query(): A link to the server could not be established in /home/ma135yh/public_html/zone/member/login.php on line 41

Warning: mysql_num_rows(): supplied argument is not a valid MySQL result resource in /home/ma135yh/public_html/zone/member/login.php on line 42

Can anyone help me sort this out?

Thanks
Matt

csousley

It looks like you're not getting connected to mysql at all, and that's going to cause problems for all your mysql statements.

Do you have a connection to mysql in your script? Something like:

mysql_connect("localhost", "user", "pass");

hunkyjack

Thats what i'm missing 😃, but how do I find my mysql server host, and which password am i using? My default login passowrd? Or my ftp password? And whats stopping people from viewing the source and finding the password?

hunkyjack

Wait, sorry, didnt understand your post. Ok thanks, im now connected 😃, and it turns it doesnt show the password in the script, but is it possible at all for someone to find the password? And is there anything you can do to prevent it.

csousley

Your password is safe. PHP is a server side language, therefore by the time the browser gets anything, all that's left is plain HTML. Anything between your <? ?> tags will be parsed and not shown. Well unless you print something from your code with echo or print obviously.

Now I guess someone could strip your FTP info sometime when you connect, go in and download your page, and then screw with you. But I wouldn't worry too much. And keep FTP access off unless you need it. Use a secure method of file transfer instead.

Hope that helps.

hunkyjack

Ok, thanks

hunkyjack

My login script now works, however that was the easy part. What I'm now finding i hard to do is create a script to add useres to the databse. Can anyone point me in the direction of a good tutorial?

csousley

Here is a very basic script that will insert something into a database. There are a million ways to code this action, this is just one of them.

<?
if (isset($_GET['happy'])) {
	$db = mysql_pconnect("localhost", "user", "pass");
	mysql_select_db("databaseName");
	if (!$db) {
		echo "Could Not Connect To Database";
		exit;
	}
	$query = "insert into tableName (id, something) values (0, '".$_GET['happy']."')";
	$result = mysql_query($query);
	echo "Inserted '".$_GET['happy']."' into the database<p>";
	echo "<a href='test2.php'>Run test again</a>";
}else{
	echo "<h2>Submit Something To Database</h2>";
	echo "<form action='test2.php' method='get'>";
	echo "<input type='text' name='happy' value=''>";
	echo "<input type='submit' name='s' value='Submit'>";
	echo "</form>";
}
?>

Good Luck

hunkyjack

Thanks for your help.

hunkyjack

I used the information you gave me, and tried to make a page, but it didnt appear to work. Although I got no errors the database wasn't affected. So then I tried making this simple script, and used that. Again I got no errors, but it didn't modify the databse. Below is the script I used. Any ideas why it didn't work?

<?
$db = mysql_pconnect("localhost", "ma135yh_tf", "*******");
mysql_select_db("forums");
if (!$db) {
echo "Databse connection error. Will now die.";
exit;
}
$username = ('hello2123');
$password = ('pass123321');
$query = "INSERT INTO users (username, password) VALUES ('".$username."' '".$password."')";
mysql_query($query);
?>

csousley

Looks like you're missing a , in your query between $username and $password.

$query = "INSERT INTO users (username, password) VALUES ('".$username."', '".$password."')";

That should take care of it.

hunkyjack

I tried the code again, like this (with the , ) but I still had a blank page with no errors, and the databse was not modified. I have checked, and I'm definatley accessing the right databse, with the right fields. Heres the code I'm using.

<? 
$db = mysql_pconnect("localhost", "ma135yh_tf", "*******"); 
mysql_select_db("forums"); 
if (!$db) { 
echo "Databse connection error. Will now die."; 
exit; 
} 
$username = ('hello2123'); 
$password = ('pass123321'); 
$query = "INSERT INTO users (username, password) VALUES ('".$username."', '".$password."')"; 
mysql_query($query); 
?>

csousley

add the line:

echo $query;

at the end of the script, then run it again. Take what it shows you and run it against the database directly and see if it works. We're just testing to see if it's the code or the query causing problems.

Not that this would kill the script because it is a real way of connecting, but you may want to change mysql_pconnect to mysql_connect.

hunkyjack

Ok, I ran what it showed me

INSERT INTO users (first, last) VALUES ('hello2123', 'pass123321')

and it worked.

csousley

It worked when you ran it against the database directly or on the page?

hunkyjack

Against the database directly. Still not on the page though.

csousley

Well that sucks, sorry. I wrote that page real quick as an example, I didn't test it against a real DB.

OK one difference I found from the code I sent you to what you're using is this:

mysql_query($query);

change to:

$result = mysql_query($query);

give that a try, If that doesn't work I'll grab some code from something that I know works.

hunkyjack

Nope, it still wont work

laserlight

You may have to quote the field and table names if they might be reserved in the database system, e.g. password()
$query = "INSERT INTO users (username, password) VALUES ('{$username}', '{$password}')";

Also, you may wish to use mysql_error() in your case to check for database errors when debugging
e.g.
mysql_query($query) OR die(mysql_error());
A more graceful method should be used in a production website, of course.

hunkyjack

Quoting the password and username didn't help, however the mysql_error came up with:

No Database Selected

which doesn't really make any sense. I checked, and I'm definatley selecting the right database, I even tried using a different one, but I still got the error.