seperating query string values from urls

frizzo

hi, im trying to make a 'print this page' feature in php.

using this code:

$print_link  = $SERVER["PHP_SELF"] . "?" . $SERVER["QUERY_STRING"]  .  "&page_view=print" ;

I'm trying to tack on the command to show the printer friendly page. problem is, it doesn't seem to be acknowledging the rest of the query string, which has some commands for other aspects of the page. so if, for insance, you're viewing the page inside a gallery where the query string has the info for what gallery page you're on, when you click the print this page link, it dumps you out at the top of the gallery 🙁

this is inside a function, and $HTTP_GET_VARS, $HTTP_POST_VARS have been globaled.

Any suggestions? Thanks

Frizzo

sneakyimp

Are you using POST or GET to get the values to this page? I'm pretty sure $_SERVER["QUERY_STRING"] (remember the underscore character!) refers only to GET arguments....arguments appended to the end of the URL.

also, have you tried inspecting exactly what value you're getting for $print_link?

i would start there.

frizzo

yes -- the values are sent with a GET.

For instance, say the page is this:

mypage.php?bar1=foo&var2=bar

then I click on "print this page"

and the code is executed as stated:

$print_link = $SERVER["PHP_SELF"] . "?" . $SERVER["QUERY_STRING"] . "&page_view=print" ;

and $print_link becomes:

mypage.php?page_view=print

sneakyimp

OK...i think you are forgetting the UNDERSCORE character ('') in $SERVER. Also, you are just assuming that $print_link has 'myfile.php' in it. you should try inspecting the source that results from your code rather than just clicking the link. (apologies if you already are). You might just find that your link looks like this:

that's what would happen if you put $SERVER instead of $_SERVER.

this works just grand for me...try copying and pasting it...if that doesn't work, it may be some strange server or PHP config issue:

$print_link = $_SERVER["PHP_SELF"] . "?" . $_SERVER["QUERY_STRING"] . "&page_view=print";

frizzo

NICE! 😃

Yep I was forgetting the underscore.

Thanks!!

It's weird that the $SERVER["PHP_SELF"] was grabbing the whole string though.... I'm glad it works now...

Frizzo

sneakyimp

PHP_SELF probably wasn't working either. that's what i mean about looking in your code.