Silly noob question

move3rd

I know there is a simple error in my syntax somwhere though i'm unable to find it.

<?

$text1 = "Field \"username\" or \"password\" is empty! Please fill in the form.";
$text2 = "Incorrect \"username\" or \"password\"!";
$members_area = "members_area.php";						 			//enter file to logon to

//username and password
##############################################################################
$username[1] = "demo";                // user1: demo
$password[1] = "demo";
##############################################################################


?>
<html><head></head>
<body bgcolor="#EFEFEF">
<form action="<? $PHP_SELF ?>" method="GET">
<table width="300" align="Center" cellpadding="0" cellspacing="0" bgcolor="#ADC6D3" border="1" bordercolor="#3C9ED1"><tr><td>
<table align="Center" border="0" cellpadding="2" cellspacing="0">
<tr><td><font face="Verdana" size="-1">Username:</font></td><td><input name="user" type="Text" size="10"></td></tr>
<tr><td><font face="Verdana" size="-1">Password:</font></td><td><input name="pass" type="Password" size="10"></td></tr>
<tr><td colspan="2" align="right"><input name="submit" type="submit" name="submit" value="GO"></td></tr>
</table></td></tr></table>
</form></body></html>
<?
if (!$submit) {
} else {
  //check if fields are empty
  if ($user == null || $pass == null) {
   echo "<h4 align=center>$text1</h4>";
  }
  //check if username and passwords are correct
  else {
   if (
       $user == $username[1] && $pass == $password[1]
      ) {
      include ("$members_area");
   }     

   //wrong username and password
   else {
    echo "<h4 align=center>$text2</h4>";
   }
  }
}
?>

tekky

maybe im forgetting some obscure PHP fact here... but...

<form action="<? $PHP_SELF ?>" method="GET">

probably isnt doing anything....

I would think you would need

<form action="<? echo $_SERVER['PHP_SELF'] ?>" method="GET">

$PHP_SELF was deprecated or however its spelt, when they turned REGISTER GLOBALS off by default in 4+

move3rd

Thanks!

That wasnt the error though. It still aint workking.

buck2bcr

In the bottom if else loop change the check to

if (!isset($submit)) {
} else { // rest of your code

HTH

move3rd

That didnt work either... I'm V confused now

buck2bcr

what error are you getting.

I'm running the code locally and do not get any parse errors.

I get a login box asking for username and password with a go button.

move3rd

I get the login box with no errors.

When I type demo/demo it should take me to members_area.php but it just reloads the login page.

buck2bcr

Try this for your bottom username password check

if (!isset($_GET['submit'])) {
} else {
  //check if fields are empty
  if ($_GET['user'] == null || $_GET['pass'] == null) {
   echo "<h4 align=center>$text1</h4>";
  }
  //check if username and passwords are correct
  else {
   if ($_GET['user'] == $username[1] && $_GET['pass'] == $password[1]){
       include ($members_area);
   }     

   //wrong username and password
   else {
    echo "<h4 align=center>$text2</h4>";
   }
  }
}

move3rd

Thanks,

You added $_GET before the form variables.

I need to do some reading I think!

laserlight

What buck2bcr did can be explained by what tekky said.

Read up the PHP Manual appendix on reserved words -> predefined variables