[Resolved] First row does not appear in results

voll

I am using the following code to display results, but for some reason, the first row does not appear in my results. Can anyone tell me what is wrong here?

<?php
include "dbconnect.php";
$db = db_connect();

	printf("<table width=\"500\" border=\"1\" align=\"center\" cellpadding=\"1\" cellspacing=\"1\" bordercolor=\"#630031\">\n");
	printf("<tr bgcolor=\"#630031\" class=\"title\">\n");
	printf("<td colspan=\"2\"><div align=\"center\">Current listings for %s</div></td>\n", "$category");
	printf("</tr>\n");
 // print the list
	$result = mysql_query("SELECT * FROM jobs WHERE category='$category' ORDER BY title");
	$myrow = mysql_fetch_array($result);
	   printf("<tr bgcolor=\"#630031\" class=\"copy2\"\n align=\"left\">");
	   printf("<td width=\"250\" class=\"copy1\" align=\"left\">Title</td>\n");
	   printf("<td width=\"250\" class=\"copy1\" align=\"left\">Location</td>\n");
	   printf("</tr>\n");
	while ($myrow = mysql_fetch_array($result)) {
	  printf("<tr><td width=\"250\" class=\"grey\" align=\"left\"><a href=\"%s?id=%s\">%s </a></td> \n", "details.php", $myrow["id"], $myrow["title"]);
	  printf("<td width=\"250\" class=\"copy1\" align=\"left\">%s %s</td> \n", $myrow["city"], $myrow["state"]);
	} 
		printf("</table>");
?>

eoghain

The problem is you are getting the row outside of your loop and not displaying any of that data, here:

// print the list 
    $result = mysql_query("SELECT * FROM jobs WHERE category='$category' ORDER BY title"); 
    $myrow = mysql_fetch_array($result);   /// <---------------- Right here you get the 1st row
       printf("<tr bgcolor=\"#630031\" class=\"copy2\"\n align=\"left\">"); 
       printf("<td width=\"250\" class=\"copy1\" align=\"left\">Title</td>\n"); 
       printf("<td width=\"250\" class=\"copy1\" align=\"left\">Location</td>\n"); 
       printf("</tr>\n"); 
    while ($myrow = mysql_fetch_array($result)) {  /// <------------ Right here you get the second and start printing the rows

voll

Thanks, but that did not work either. Here is the code again, a little neater. The other row was just a header row for title and location, it is out of the way now, and I still cannot show the first record.

<?php
include "dbconnect.php";
$db = db_connect();

	printf("<table width=\"500\" border=\"1\" align=\"center\" cellpadding=\"1\" cellspacing=\"1\" bordercolor=\"#630031\">\n");
	printf("<tr bgcolor=\"#630031\" class=\"title\">\n");
	printf("<td colspan=\"2\"><div align=\"center\">Current listings for %s</div></td>\n", "$category");
	printf("</tr>\n");
    printf("<tr bgcolor=\"#630031\" class=\"copy2\"\n align=\"left\">");
    printf("<td width=\"250\" class=\"copy1\" align=\"left\">Title</td>\n");
    printf("<td width=\"250\" class=\"copy1\" align=\"left\">Location</td>\n");
    printf("</tr>\n");
 // print the list
	$result = mysql_query("SELECT * FROM jobs WHERE category='$category' ORDER BY title");
	$myrow = mysql_fetch_array($result);
	while ($myrow = mysql_fetch_array($result)) {
	  printf("<tr><td width=\"250\" class=\"grey\" align=\"left\"><a href=\"%s?id=%s\">%s </a></td> \n", "details.php", $myrow["id"], $myrow["title"]);
	  printf("<td width=\"250\" class=\"copy1\" align=\"left\">%s %s</td></tr> \n", $myrow["city"], $myrow["state"]);
	} 
	  printf("</table>");
?>

eoghain

You missed my point.

You are calling [man]mysql_fetch_array/man once and then you are calling it again as the start of your loop. This means that you've gotten the 1st record then as soon as you enter the loop you throw that away and get the 2nd record.

If you comment out your first call to [man]mysql_fetch_array/man then you will get all of your records displayed.

voll

I did miss your point. I thought I had to call mysql_fetch_array() first before i used it. Sorry, I'm still kinda new to php. It works fine now. Thanks alot for your help.

eoghain

Not a problem, I was new once, and will be new again. ;->

I just don't solve peoples problems I try to point out where they wen't wrong so they can learn from the mistake instead of just getting an easy answer and not knowing what went wrong or how to fix it when it happens again.

Steveo31

In addition, there are MUCH cleaner and more efficient ways of displaying HTML code via PHP.

http://www.onlamp.com/pub/a/php/2003/04/10/php_heredocs.html

eoghain

Personally I'd do a lot of looking around for the type of coding solution that fits you best. I agree with Steveo31 that you need to separate your PHP from your HTML, personally I like Smarty for a template engine. But there are lots of them out there.

Also I look at my PHP as a program, not an HTML script, so all of my pages start and end with <?php ?> and have no native HTML in them. Sometimes I have to build an HTML string, but I do it in a variable and print that to the browser. It makes it much easier to figure out what my code is doing when I don't have to wade through all the HTML junk that I don't really care about.