If - Else conditionals in while loop.

jldbeck

For some reason, some things work, and others don't. The complete elseif containing 'include ("body.php");' works, but none of the other ones seem to.

while ($row = mysql_fetch_array($rs))
{
//Check for field completion
if ( (!$email) or (!$pass) )
{
$PageTitle = "Missing Information";
echo ("<br><center>One or more of the required fields have not been completed.<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");
}
//Login attempt
elseif ($email==$row[user_email] and $epass==$row[user_password])
{
$PageTitle = "Logged In";
include ("body.php");
}
//Email check
elseif ($email != $row[user_email])
{
$PageTitle = "Verification Failed";
echo ("<br><center>The <b>email</b> entered was incorrect. Please check your information and try again.<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");
}
//Password check
else
{
$PageTitle = "Verification Failed";
echo ("<br><center>The <b>password</b> entered was incorrect. Would you like it sent to your <a href=\"sendpass.php?email=$email\">email</a>?<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");
}
}

laserlight

Have you read the forum FAQ?

There is also another little mistake, and that is your associative array indices should be written as strings, not as constants, unless you really intend it as that.
i.e. use $row['user_email'] not $row[user_email]

Aside from these, you need to provide more information, e.g. what are you trying to do, how does it not work

jldbeck

Fixed that, still doesn't work. Basically it's a login script, checks the values against a mySQL database. It checks the values correctly, and includes the body.php file, as well as sets the $PageTitle variable. In the section I provided, only one thing works. And that is this part;

//Login attempt
elseif ($email==$row[user_email] and $epass==$row[user_password])
{
$PageTitle = "Logged In";
include ("body.php");
}

None of the other conditionals seem to do anything. The title doesn't get set and nor does it echo any message. It just goes to a blank page, unless the email and password are correct, then it includes the body.php file, as aforementioned.

ahundiak

You might try adding
error_reporting(E_ALL);
To the top of your script. I suspect this is a typo:
$epass==$row[user_password]

jldbeck

Nope, no typo. And the error_reporting, said I have an undefined variable in line 54. But, it looks defined to me.

ahundiak

perhaps I being too subtle.
if ( (!$email) or (!$pass) )
$epass==$row[user_password])

Why do you have $pass in one statement and $epass in another?

jldbeck

$epass is my variable set earlier to md5 the user's password ($pass). $pass is the variable from the HTML form.

ahundiak

Fair enough. Then what is line 54? When php says something is undefined then it's often worth investigating.

jldbeck

That should be, '$PageTitle = "Verification Failed";'. So, I'm not sure what could be wrong with it. I just wanna get this thing working. I posted this in a couple other forums before coming here, you guys have helped me way more than any of them did, so thanks.

Here's the whole script if that helps.

<?php
$epass = md5($pass);

//Connect

$conn=mysql_connect ("localhost", "USER", "PASWORD")
	or die ("<br><center>Error.<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");

//Select DB

$rs = mysql_select_db ("DB", $conn)
	or die ("<br><center>Error.<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");

//Create query for authentication

$sql="select * from users where user_email=\"$email\" and user_password=\"$epass\"";

//Execute query

$rs=mysql_query ($sql, $conn)
	or die ("<br><center>Error.<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");

while ($row = mysql_fetch_array($rs))
{
//Check for field completion
if ( (!$email) or (!$pass) )
{
$PageTitle = "Missing Information";
echo ("<br><center>One or more of the required fields have not been completed.<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");
}
//Login attempt
elseif ($email==$row['user_email'] and $epass==$row['user_password'])
{
$PageTitle = "Logged In";
include ("body.php");
}
//Email check
elseif ($email != $row['user_email'])
{
$PageTitle = "Verification Failed";
echo ("<br><center>The <b>email</b> entered was incorrect. Please check your information and try again.<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");
}
//Password check
else
{
$PageTitle = "Verification Failed";
echo ("<br><center>The <b>password</b> entered was incorrect. Would you like it sent to your <a href=\"sendpass.php?email=$email\">email</a>?<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");
}
}
?>
<html>
<head>
<title><?php echo($PageTitle); ?></title>
<style>a { text-decoration : none }</style>
</head>
<body bgcolor="#000000" text="#FFFFFF" link="blue" alink="blue" vlink="blue">
</body>
</html>

ahundiak

Lot's of things wrong not the least of which is that you put out the body before the html header elements.

Here is some major surgery. Not tested but maybe it will give you a starting point. I am assuming that you have register globals on and have verified that $email and $pass are being set.

<?php
error_reporting(E_ALL);
/* --------------------------------
 * Forget about adjusting the title for now.
 */
?>
<html>
<head>
<title>The Title</title>
<style>a { text-decoration : none }</style>
</head>
<body bgcolor="#000000" text="#FFFFFF" link="blue" alink="blue" vlink="blue">
<?php
/* -----------------------------------------------
 * Use a function here to make the nested if's go away
 */
function process($email,$pass)
{
    // Check parameters
    if ((empty($email) || empty($pass))
    {
        echo 'Missing data';
        return;
    }
    $epass = md5($pass);

//Connect
$conn=mysql_connect ("localhost", "USER", "PASWORD")
    or die ("<br><center>Error.<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");

//Select DB
$rs = mysql_select_db ("DB", $conn)
    or die ("<br><center>Error.<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");

//Create query for authentication
/* ------------------------------------------------------------------
 * Note that this will only return the record that actually matches
 * If no records then no match */
$sql="select * from users where user_email=\"$email\" and user_password=\"$epass\"";

//Execute query
$rs=mysql_query ($sql, $conn)
    or die ("<br><center>Error.<br><br>[ <a href=\"http://www.allbeta.com\">back</a> ]</center>");

$row = mysql_fetch_array($rs);
if (!$row)
{
    echo 'Invalid username/password etc';
    return;
}
include ("body.php");
return;
}
process($email,$pass);
?>
</body>
</html>

jldbeck

Thanks. That helps a lot.