if if else not happening

[har_dick]

hi.

this piece of code is originally inside a function i built:

<?php
do
{	
?>
<td width=20%>
<div align="center">
<?php
@	$size = getimagesize(images/$s[folderg]/$s[poster]);
	$width = $size[0];
	$height = $size[1];
	if ( $width > $height )
		{
			$thumbwidth = "200";
			$thumbheight = "120";
		} else {
			$thumbwidth = "120";
			$thumbheight = "200";
		}
?>
<p><a href="javascript:popUp('galleries/comment.php?imageid=<? echo $s[id]; ?>')"><img src="images/<?php echo $s[folderg]; ?>/<?php echo $s[poster]; ?>" width="<?php echo $thumbwidth; ?>" height="<?php echo $thumbheight; ?>"></a></p>    

i put the if in order to choose if the image was taken horizontally or vertically, but all images output is 120 x 200.....

i thank all responses plz. 🙂

[yelvington]

@ $size = getimagesize(images/$s[folderg]/$s[poster]);

Begin by taking out the @, which supresses error reporting.

Then fix the string.

[har_dick]

THanks for answering, i turned a debug statement into:

<?php		
@	$size = getimagesize(images/$s[folderg]/$s[poster]);
	$width = $size[0];
	$height = $size[1];
	echo $size[0];
	echo $size[1];
	if ( $width > $height )
	{
		$thumbwidth = "200";
		$thumbheight = "120";
		echo '$width > $height';
	} else {
		$thumbwidth = "120";
		$thumbheight = "200";
		echo '$width < $height';
}
echo '<br>thumbwidth = '.$thumbwidth ."<br>";
echo '<br>thumbheight = '.$thumbheight ."<br>";
echo 'validation = ' . $size[3];		
	?>

and i get an output as follows for all images:

$width < $height
thumbwidth = 120

thumbheight = 200
validation =

so there're two issues here,,, there is no echoing of size[0] and [1] and the if still is not happening. I wonder if it's something on the usage of getimagesize function or is it that the code is inside a function ???

oh i forgot to tell you... if i surpress the @ i get the following warning:

Warning: Division by zero in /home/website/public_html/imagesadmin/functions.php on line 539

[yelvington]

Again,

Your problem is here:

@ $size = getimagesize(images/$s[folderg]/$s[poster]);

Remove the @ sign and leave it removed. Of course you get a "division by zero" error. getimagezize() requires a valid path string. You are passing nonsense. Strings MUST be enclosed by quotation marks.

Since you are passing nonsense to getimagesize(), it can't figure out anything about the image and returns zero for both height and width.

[har_dick]

working perfectly. thanks man 🙂