Insert into db form not working, why?

skeetley

Here is my form:

<html>
<head>
<title>Untitled Document</title>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
</head>

<body>
<form method="post" action="inputrts.php">
  <table width='100%' cellspacing='0' dwcopytype="CopyTableRow">
    <tr> 
      <td>&nbsp;</td>
      <td>&nbsp;</td>
    </tr>
    <tr> 
      <td width='22%'> <div align="left"><strong><font color="#FF0000" face="Georgia, Times New Roman, Times, serif">Station 
          Name: </font></strong></div></td>
      <td width='78%'><input name="station_name" type="text" id="station_name" size="30" maxlength="5"> 
      </td>
    </tr>
    <tr> 
      <td><strong><font color="#FF0000" face="Georgia, Times New Roman, Times, serif">Location:</font></strong></td>
      <td><input name="station_location" type="text" id="station_location" size="30" maxlength="30"> 
      </td>
    </tr>
    <tr> 
      <td><strong><font color="#FF0000" face="Georgia, Times New Roman, Times, serif">Logger:</font></strong></td>
      <td><input name="station_logger" type="text" id="station_logger" value="FWS12S" size="30" maxlength="6"></td>
    </tr>
    <tr> 
      <td><strong><font color="#FF0000" face="Georgia, Times New Roman, Times, serif">Phone:</font></strong></td>
      <td><input name="station_phone" type="text" id="station_phone" size="30" maxlength="10"> 
      </td>
    </tr>
    <tr> 
      <td><strong><font color="#FF0000" face='Georgia, Times New Roman, Times, serif'>Radio 
        Modem #:</font></strong></td>
      <td><input name="station_rm" type="text" id="station_rm" size="30" maxlength="4"></td>
    </tr>
    <tr> 
      <td><strong><font color="#FF0000" face="Georgia, Times New Roman, Times, serif">Modem 
        Type:</font></strong></td>
      <td><input name="station_modem" type="text" id="station_modem" size="30" maxlength="6"></td>
    </tr>
    <tr>
      <td><strong><font color="#FF0000" face="Georgia, Times New Roman, Times, serif">Caller:</font></strong></td>
      <td><input name="station_caller" type="text" id="station_caller" size="30" maxlength="30"></td>
    </tr>
    <tr> 
      <td><strong></strong></td>
      <td>&nbsp; </td>
    </tr>
    <tr> 
      <td colspan="2"><div align="center"><strong></strong> 
          <input name="submit" type="submit" value="Submit station">
        </div></td>
    </tr>
  </table>
</form>

and here is my form action php that should throw that data in the db

<?
$DBhost = "localhost";
$DBuser = "uuu";
$DBpass = "ppp";
$DBName = "ops_db";
$table = "RTS_Stations";
mysql_connect($DBhost,$DBuser,$DBpass) or die("Unable to connect to database");

@mysql_select_db("$DBName") or die("Unable to select database $DBName");

$sqlquery = "INSERT INTO RTS_Stations (station_name, station_location, station_logger, station_phone, station_rm, station_modem, station_caller) 
VALUES ('$_POST[station_name]', '$_POST[station_location]', '$_POST[station_logger]', '$_POST[station_phone]',  '$_POST[station_rm]',  '$_POST[station_modem]',  '$_POST[station_caller]')";

$results = mysql_query($sqlquery);

mysql_close();

header('location: [url]http://www.yahoo.com[/url]);}
?>

I fill in the data, press sumbit, and I get stranded at an empty inputrts.php page. no errors, no nothing. And nothing is added to the db. Did I make a mistake somewhere?

Note: that last line is actually header('location: address.com');} not what it says above

skeetley

OK, I noticed that I had used the form variable names in my sql query when I should have used the db column names. I fixed that up, same problem.

So I went into phpmyadmin, which uses the same u/p as this script, and entered a station manually. I got the php code and put it in the script, see below. I then called the page and it still hangs. Is it something with my code or the permissions of my user/pass? I don't think it is permissions since I can add the records in phpmyadmin with the same u/p, but this code looks good to me.

<?
$DBhost = "localhost";
$DBuser = "uuu";
$DBpass = "ppp";
$DBName = "ops_db";
$table = "RTS_Stations";
mysql_connect($DBhost,$DBuser,$DBpass) or die("Unable to connect to database");

@mysql_select_db("$DBName") or die("Unable to select database $DBName");

//$sqlquery = "INSERT INTO RTS_Stations (FMFP_ID, Location, Logger, Phone, RM_NUM, Modem, Caller) 
//VALUES ('$_POST[FMFP_ID]', '$_POST[Location]', '$_POST[Logger]', '$_POST[Phone]',  '$_POST[RM_NUM]',  '$_POST[Modem]',  '$_POST[Caller]')";
$sqlquery = 'INSERT INTO `RTS_Stations` ( `FMFP_ID` , `Location` , `Logger` , `Phone` , `RM_NUM` , `Modem` , `Caller` ) '
        . ' VALUES ( \'MCLNN\', \'McLennan Lake\', \'FWS12S\', NULL , \'0360\', \'RM\', \'La Ronge\' );'
        . ' '; 

$results = mysql_query($sqlquery);

mysql_close();

header('location: url.ca/');}
?>

sidney

check out the colour highlights between my example and yours above

 $sqlquery = "INSERT INTO `RTS_Stations` ( `FMFP_ID` , `Location` , `Logger` , `Phone` , `RM_NUM` , `Modem` , `Caller` ) " 
        . " VALUES ( 'MCLNN', 'McLennan Lake', 'FWS12S', NULL , '0360', 'RM', 'La Ronge' );"

 
$sqlquery = "INSERT INTO RTS_Stations (FMFP_ID, Location, Logger, Phone, RM_NUM, Modem, Caller) 
VALUES ('".$_POST[FMFP_ID]."', '".$_POST[Location]."', '".$_POST[Logger]."', '".$_POST[Phone]."',  '".$_POST[RM_NUM]."',  '".$_POST[Modem]."',  '".$_POST[Caller]."')";

skeetley

Sid,
Thanks for the snippets. I tried both and the thing still hangs. Just curious, but what would happen if i tried inserting a row using a u/p that did not have these privilages? The same thing, a hanging program?

sidney

no if password or username is wrong you would get a mysql error
and script would continue

skeetley

the u/p are right, i just don't know if the system admin has given this set of u/p insert privilages. I can use this u/p in phpmyadmin to do that, but in this script it won't work.

sidney

if the password works in phpadmin its fine

what happens when you remove @ error supression

skeetley

I took out the @ and nothign changes. I just get a blank screen.

If I type characters before the php begins they print. If I put an echo line anywhere in the php it won't print.

sidney

try that i tested and the NULL seemed to be the culprit

 $sqlquery = "INSERT INTO `RTS_Stations` ( `FMFP_ID` , `Location` , `Logger` , `Phone` , `RM_NUM` , `Modem` , `Caller` ) "  

        . " VALUES ( 'MCLNN', 'McLennan Lake', 'FWS12S', '', '0360', 'RM', 'La Ronge' );";

skeetley

Thanks for you help Pete, I got it working. The problem wasn't the null, but rather the header line at the bottom of the code. Your comment about the null somehow got me thinking to check that line.

If I take out that header line it works. If I take out all the php except that header line i get the dreaded Headers already sent message. Why? I have done that header redirect in other code the same way and it works fine. The php.net website even shows this header("Location: http://www.example.com/"); Is there a better way to make a redirect?

sidney

the header has to be outputted before any html ,
echo, print or white space is sent to the browser

brownpauls

Your code worked for me.

The only thing I did was remove the:

header('location: address.com');}

skeetley

So if putting header('location [url]http://.....[/url]') is not the way to make the page redirect after executing a bunch of code, what do you do?

sidney

header is the way to go just make sure location exsists