displaying Multiple rows?

[move3rd]

I would like to print all CD's from my db by $artist.

Why does it only print out 1 CD by the artist and not all of them?

<?
 // start the session 
session_start(); 
header("Cache-control: private"); //IE 6 Fix 

echo "<strong>Members Area</strong><br>";
$name = $_SESSION['username'];

?> 

<table width="100%" border="0" cellpadding="5">
  <tr>
    <td width="23%">&nbsp;</td>
    <td width="46%">&nbsp;</td>
    <td width="31%"><div align="right">Welcome <? echo $_SESSION['username']; ?> </div></td>
  </tr>
  <tr>
    <td height="29">&nbsp;</td>
    <td>&nbsp;</td>
    <td><div align="right"><a href="logout.php">Log-out</a></div></td>
  </tr>
</table>
<table width="100%" border="0" cellpadding="5">
  <tr bgcolor="#F2F2F2"> 
    <td width="46%">Title
      <? $sql = "SELECT * FROM `cds` WHERE `artist` = '$artist'";

$result = mysql_query($sql);

if (!$result) {
   echo "Could not successfully run query ($sql) from DB: " . mysql_error();
   exit;
              }

if (mysql_num_rows($result) == 0) {
	echo "<h4 align=center>There is a problem please contact the webmaster and quote this ref number (1)</h4>";  

   exit;
                                  }

while ($row = mysql_fetch_array($result)){
extract($row);
                                         }?>
    </td>

<td width="8%"><div align="left">Status</div></td>
<td width="16%">Promotion</td>
<td width="8%">Price</td>
<td width="7%">&nbsp;</td>
<td width="15%">&nbsp;</td>
  </tr>

<? if ($cd_title = NULL) { echo "No CD's Available";}
	  else { print "
  <tr> 
    <td>$cd_title</td>
    <td width='10%'>$cd_status</td>
    <td width='11%'>$cd_promotion</td>
    <td width='6%'>$cd_price</td>
    <td width='7%'><div align='right'>Edit</div></td>
    <td width='13%'><div align='right'>View Sales Stats</div></td>
  </tr>
"; }?>
</table>

<p>&nbsp;</p>

[mabz]

Hi,
Try replacing

while ($row = mysql_fetch_array($result))

with

while ($row = mysql_fetch_assoc($result))

Basically I think by using mysql_fetch_array you are not interating through that array which is why it is printing only one result. Hovever thats from one newbie to another.

Cheers

[move3rd]

Thanks mabz

That wasnt it though. It still outputs only 1 CD.

[mabz]

You have got your curly brace in the wrong place for the while loop.

while ($row = mysql_fetch_array($result)){
extract($row);
                                         }?> 

The Curly Brace to end your loop should be at the end of displaying your data and your column headings should be befor the while loop

<tr>

<td width="8%"><div align="left">Status</div></td>
<td width="16%">Promotion</td>
<td width="8%">Price</td>
<td width="7%">&nbsp;</td>
<td width="15%">&nbsp;</td>

</tr>

while ($row =    mysql_fetch_array($result)){
extract($row);
if ($cd_title = NULL) { echo "No CD's Available";}
      else { print "
  <tr>
    <td>$cd_title</td>
    <td width='10%'>$cd_status</td>
    <td width='11%'>$cd_promotion</td>
    <td width='6%'>$cd_price</td>
    <td width='7%'><div align='right'>Edit</div></td>
    <td width='13%'><div align='right'>View Sales Stats</div></td>
  </tr> 
"; }
} ?>

Try that.

[move3rd]

I understand the while statment now!

It's not printing $cd_title for some reason?

 <? while ($row = mysql_fetch_array($result))
  {
extract($row);
   if ($cd_title = NULL) { echo "No CD's Available";
                         }
	  else { print "<tr><td>$cd_title</td>
             <td width='10%'>$cd_status</td>
             <td width='11%'>$cd_promotion</td>
             <td width='6%'>$cd_price</td>
             <td width='7%'><div align='right'>Edit</div></td>
             <td width='13%'><div align='right'>View Sales Stats</div></td></tr>"; 
            }
 }
 ?>

[move3rd]

To avoid having to addslashes I did this:

<? while ($row = mysql_fetch_array($result))
  {
extract($row);



   if ($cd_title = NULL) { echo "No CD's Available";
                         }
	  else {

   echo "<tr><td>".$cd_title."</td>";
   echo "<td width='10%'>".$cd_status."</td>";
   echo "<td width='11%'>".$cd_promotion."</td>";
   echo "<td width='6%'>".$cd_price."</td>";
   echo "<td width='7%'><div align='right'>";
   echo "<form action='edit_cd.php' method='post'>";
   echo "<INPUT TYPE='hidden' NAME='cd_title' VALUE='".$cd_title."'>"; 
   echo "<input name='POST' type='submit' value='Edit'>";
   echo "</form></div></td>";
   echo "<td width='13%'><div align='right'>View Sales Stats</div></td></tr>"; 
        }
 } 

 ?>

All the variables are echoed execpt $cd_title. Where am I going rong?

[weevil]

if ($cd_title = NULL)

sets $cd_title equal to NULL
change it to

if ($cd_title == NULL)

[move3rd]

Thanks! 🙂

It seems I've made that mistake serveral times.