insert into database

susi

hi..

i was wondering if anyone could help me..
im trying to insert a full name into a table in the database from a php form

code is as follows:-

$student = "INSERT into students (forename, surname) values ($forename, $surname)";

mysql_query($student);

do u know wat im doin wrong or wat im missing??
any help wud be appreciated..

thanks
susi

AstroTeg

Because forename and surname are probably text fields, you need quotes around $forename and $surname (single quotes will work nicely).

susi

thanks for that... that was one error.. very silly!

only problem now is that it seems to go to the database but isn't printing the data to the database .. just leaving blank rows...

i don't tink im calling the variable right..

my code for the form is

<td>Enter Student Forename:</td>
<td><input type="text" size=15
maxlength=30
name=<"forename"></td>
</tr>

<tr><td>Enter Student Surname:</td>
<td><input type="password" size=15
maxlength=8
name="surname"></td>
</tr>
<tr>
<td><input type="submit" value="Log in"></td>

and then the insert to the database:-

$student = "INSERT into students (forename, surname) values ('$forename', '$surname')";

mysql_query($student);

Any suggestions would be appreciated..
thanks
susi

AstroTeg

I'm always a big fan of printing out the query until your 100% positive your query is 100% perfect. I'd predict your variables are empty when drop them into your query (print out the query and it will show you if that's true or not). Make sure you're using $_POST[] to get the form data.

susi

Thanks a million...

Its working now.. 🙂

Sxooter

You should probably look up mysql_escape_string as well. Otherwise you'll have issues when someone tries to insert a ' mark.