horizontal loop

pugs421

I found a script to display output like this

1 2
3 4
5 6

Here is the code:

//set number of columns

$columns = 2;

$num_rows = mysql_num_rows($result);
echo "<Table>";

for($i=0; $i < $num_rows; $i++) {
$row = mysql_fetch_array ($result);
if(i % $columns == 0) {
echo "<tr>";
}
echo"<td>".$row['stuff']."</td>";
if(($i % columns) == ($columns - 1) || ($i + 1) == $num_rows)
{
echo "<tr>";
}
}
echo "</table>";

The problem I have with it is that it doesn't close the <tr> tablerows with </tr>. It only places a <tr> when a new tablerow is needed. This seems to display correctly, but I don't usually write code without closing the tags. I would like to see if that could be fixed.

laserlight

It is a typo.

$columns = 2;
$columns_m1 = $columns - 1; //columns minus 1

$num_rows = mysql_num_rows($result);
$num_rows_m1 = $num_rows - 1; //num_rows minus 1

echo "<table>";
for ($i = 0; $i < $num_rows; $i++) {
	$row = mysql_fetch_array ($result);
	if (i % $columns == 0) {
		echo "<tr>";
	}
	echo "<td>" . $row['stuff'] . "</td>";
	if ($i % columns == $columns_m1 || $i == $num_rows_m1) {
		echo "</tr>";
	}
}
echo "</table>";

pugs421

Thanks for the reply but that didnt work.

The code provided in the last post output the following code:

Pests

Here you go. I tested it out and everything. Cleaned up your code, and added something to prevent HTML errors. You can see it in action over at: http://www.dotpests.com/phpb.php?col=5&amount=16

<?php
$columns = 2;
$count = 0;

$num_rows = mysql_num_rows($result);

echo "<table>";
echo "<tr>";

for($i=0; $i < $num_rows; $i++)
{
	$row = mysql_fetch_array ($result);
	if($i % $columns == 0 && $i != 0)
	{
		echo "</tr>";
		echo "<tr>";
		$count = 0;
	}
	echo "<td>" . $row['stuff'] . "</td>";
	$count++;
}

// This makes sure all the columns are filled
// Without this, when $num_rows % $columns does not equal 0
// There would be less columns in the last <tr> then $columns
if($columns != $count)
{
	for($i = 0; $i < ($columns - $count); $i++)
	{
 		echo"<td bgcolor=red>&nbsp;</td>"; //Change this if you want to fill it with something else
	}
}

echo "</tr>";
echo "</table>";
?>

pugs421

Thats great. Thanks a lot. Very helpful.

pugs421

Would it be very complex to in dispay the retrieved information in more than on cell for each result.

For example:

<Table>
<tr><td>result1 picture</td> <td>result2 picture</td> </tr>
<tr><td>result1 description</td><td>result2 description</td> </tr>
<tr><td>result3 picture</td><td>result4 picture</td> </tr>
<tr><td>result3 description</td><td>result4 description</td></tr>

</table>