download zip and exe

stonecourier

I have seen that downloading exe and winzip files can be a problem. I have used the search but all the solutions did not seem to work (at least for me).

What is the syntax for content etc to download and exe file and winzip. Thanks for any assistance.

I got this from one of the posts but it does not work for me.

Function Download($vFile)
{
$shortname = basename( $vFile );
$size = filesize($vFile);
header("Content-Type: application/save");
header("Content-Length: $size");
header("Content-Disposition: attachment; filename=$shortname");
header("Content-Transfer-Encoding: binary");
$fh = fopen("$vFile", "rb");
fpassthru($fh);
}

drew010

instead of
header("Content-Type: application/save");
try
header("Content-Type: application/octet-stream");

stonecourier

Sorry that does not work. Winzip file is still corrupt.

Any other ideas?

stonecourier

Currently these files are in a protected directory, so people can't just link to them directly.

Is there a way I can redirect them to the file and pass in the directory username/password as part of the location redirection in PHP?

If I could do this I know it would work as I can download them using this method.

Thanks again.

drew010

you could do something like this. pass them to download.php?file=something.zip

--part of download.php

$path = "/home/yoursite/www/protected/files/";

if(strpos($_GET['file'], "..") !== FALSE) {
    echo "HACKING ATTEMPT!";
    exit;
}

if(!file_exists($path . $_GET['file'])) {
    echo "invalid file!";
    exit;
}

header("Content-Type: application/octet-stream");
header("Content-Disposition: attachment; filename=$_GET['file']");
header("Content-Length: " . filesize($path . $_GET['file']);
readfile($path . $_GET['file']);

stonecourier

Thanks for the code.

I am already doing something very similar to this. It works fine for things like PDFs and word documents.

If I try downloading applications it seems to turn the exes into dos exes and winzip files into something unusable.

If I link to the files directly without using content encoding the files are fine.

Normal users can't do this because the directory is protected.

So I must be doing something wrong with the content encoding but from my looks here and in other threads I can't figure it out.

If I can't get content encoding to work, the linking to the file directory with a header with the username/password passed in somehow is the only alternative I can think of.

drew010

i wouldnt worry about putting content-transfer-encoding in because octet-stream is telling it to download the file as a binary executable.
if readfile is giving problems you can also try echo file_get_contents("file");

stonecourier

Function Download($vFile)
{
$shortname = basename( $vFile );
$size = filesize($vFile);
header("Content-Type: application/octet-stream");
header("Content-Disposition: attachment; filename=$shortname");
header("Content-Length: $size");

echo file_get_contents($vFile);

// $fh = fopen("$vFile", "rb");
// fpassthru($fh);
// header("Location :". $vFile);
}

if I try file_get_contents or

fopen with fpassthru

or header location

The file is unusable.

drew010

thats strange, because i use similar code and it works fine.

stonecourier

Finally figured it out.

All my pages use HTTP compression as a default.

I didn't think this page had it set up (but it did).

This is causing the problem. As soon as I turned this off, the problem went away.

Thanks for your help.