undefined variable: comments

[mike08]

i am trying to build a guestbook and keep getting this error at the moment - was hoping someone could have a look at my code to see where the problem lies.

the error is undefined variable: comments

code

//check a comment has been entered 
if (strlen($comments) > 0) { 
   $comments = stripslashes($comments); 
} else { // if there are no comments.. 
   $comments = NULL; 
   echo '<p><font color="red" size"+1">You forgot to enter your comments!</b</p>'; 
} 

//if everything was filled out ok 
if ($username && $email && $comments) { // if everything's ok 

//Add comments 
$query = "INSERT INTO guestbook (username, email, comments) VALUES ('$username','$email','$comments')"; 
$result = @mysql_query ($query); // run the query. 

if ($result) { // If it ran ok. 
echo '<h3>Thank you for leaving a comments!</h3>'; 
include ('includes/footer.html'); // include the HTML footer. 
exit(); 
} else { // If it did not run ok. 
echo '<p><font color="red" size="+1">You could not leave a comment due to a system error.  We apologise for any inconvenience.</font></p>'; 
} 
mysql_close(); // Close the database connection. 
} 
} 
?>

[mike08]

keep getting undefined index: comment and undefined variable comment:

can someone please help

code is below:

if (trim($_POST['comment'])){   

   $comment = escape_data($_POST['comment']);   

} else {   

   $comment = FALSE;   

   echo '<p><font color ="red" size="+1">Please enter comment!</font></p>';   

}
//if everything was filled out ok
if ($username && $email && $comments) { // if everything's ok

//Add comments
$query = "INSERT INTO guestbook (username, email, comments) VALUES ('$username','$email','$comments')";
$result = @mysql_query ($query); // run the query.

if ($result) { // If it ran ok.

echo '<h3>Thank you for leaving a comments!</h3>';
include ('includes/footer.html'); // include the HTML footer.
exit();
} else { // If it did not run ok.
echo '<p><font color="red" size="+1">You could not leave a comment due to a system error.  We apologise for any inconvenience.</font></p>';
}

mysql_close(); // Close the database connection.
}
}
?>

<h1>Guestbook</h1>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
<fieldset>

<p><b>User Name:</b> <input type="text" name="username" size"10" maxlength="20" 
value="<?php if (isset($_POST['username'])) echo $_POST['username']; ?>" /></p>

<p><b>Email Address:</b> <input type="text" name="email" size"40" maxlength="40" 
value="<?php if (isset($_POST['email'])) echo $_POST['email']; ?>" /></p>

<p><b>Comments:<b> <textarea name="comments" rows="5" cols="30"></textarea
"<?php if (isset($_POST['comments'])) echo $_POST['comments']; ?>" > </p>
</fieldset>

<div align="center"><input type="submit" name="submit" value="Submit" /></div> 

</form><!-- End of form -->  

[mike08]

code is below

$comments = $_POST["comments"];
//check comment has been entered
if (strlen($comments) > 0) { 
	$comments = stripslashes($comments);
} else { // if there are no comments..
	$comments = NULL;
	echo '<p><font color="red" size"+1">You forgot to enter your comments!</b</p>';
}
//if everything was filled out ok
if ($username && $email && $comments) { // if everything's ok

//Add comments
$query = "INSERT INTO guestbook (username, email, comments) VALUES ('$username','$email','$comments')";
$result = @mysql_query ($query); // run the query.

if ($result) { // If it ran ok.

echo '<h3>Thank you for leaving a comments!</h3>';
include ('includes/footer.html'); // include the HTML footer.
exit();
} else { // If it did not run ok.
echo '<p><font color="red" size="+1">You could not leave a comment due to a system error.  We apologise for any inconvenience.</font></p>';
}

mysql_close(); // Close the database connection.
}
}
?>

<h1>Guestbook</h1>
<form action="<?php echo $_SERVER['PHP_SELF']; ?>" method="post">
<fieldset>

<p><b>User Name:</b> <input type="text" name="username" size"10" maxlength="20" 
value="<?php if (isset($_POST['username'])) echo $_POST['username']; ?>" /></p>

<p><b>Email Address:</b> <input type="text" name="email" size"40" maxlength="40" 
value="<?php if (isset($_POST['email'])) echo $_POST['email']; ?>" /></p>

<p><b>Comments:<b> <textarea name="comments" rows="5" cols="30"></textarea
"<?php if (isset($_POST['comments'])) echo $_POST['comments']; ?>" > </p>
</fieldset>

<div align="center"><input type="submit" name="submit" value="Submit" /></div> 

</form><!-- End of form -->  

<?php // inlcude the HTML footer.
include ('includes/footer.html');
?>

[sidney]

the error is a notice and dosent affect the running of the script

its telling you that a var you checking hasnt been set

it should also give a line number so you should be able to find which var it is

it probably this line

$comments = $_POST["comments"];  

as its the first and the form hasnt been submitted $post will not be set

best thing to do is an isset

 if (isset($_POST['comments']))
     {
      $comments = $_POST["comments"]; 
     }
     else
     {
     $comments = NULL;
     }

 

[mike08]

Thanks for that

its got rid of that error

when i fill in my guest book i goes straight to my set error of

You could not leave a comment due to a system error.  We apologise for any inconvenience.</font></p>'; 

is this right

if (isset($_POST['comments'])) 
     { 
      $comments = $_POST["comments"];  

     } 
     else 
     { 
     $comments = NULL; 
    echo '<p><font color="red" size"+1">You forgot to enter your comments!</b</p>'; 
  } 
  //if everything was filled out ok 
  if ($username && $email && $comments) { // if everything's ok 

//Add comments 
$query = "INSERT INTO guestbook (username, email, comments)   VALUES ('$username','$email','$comments')"; 
$result = @mysql_query ($query); // run the query. 

if ($result) { // If it ran ok. 

  echo '<h3>Thank you for leaving a comments!</h3>'; 

 exit(); 
 } else { // If it did not run ok. 
  echo '<p><font color="red" size="+1">You could not leave a comment due to a system error.  We apologise for any inconvenience.</font></p>'; 
} 

mysql_close(); // Close the database connection. 
} 
  } 
?> 

[sidney]

is it inserting the comment into the database

you could remove @ to see any error

[dartcol]

Try using

if (isset($_POST['comment'])) {   

This checks to see whether the variable is set.