register_globals off but...

crawfd

Alrighty then. I turned off register_globals in my php.ini file and now the script below (that was working with it on) doesn't work anymore. The script displays the initial query with my lists of articles, however after clicking on a link it doesn't refresh and display its sub article. I tried $article = global $_REQUEST['article']; in the second query but it gave me a parse error.

<?

if (empty($offset)) {
    $offset=0;
}

if(!isset($action)){

// query code for list of articles

}

if($action == "newsfull"){

$article = $_REQUEST['article'];

// query code for full length of each individual article

}



?>

sidney

all vars that are posted or get need to
be extracted

this would include $action

a quick fix is to use extract at the beginning of the script

ie
extract($_POST);
would extract all post vars

extract($_GET);
would do the get vars

extract($_REQUEST);
would do get, post, cookie

you can do the individual vars
ie
$action=$_GET['action'];

swr

I would guess $offset and $action are supposed to come from $_REQUEST too...

$offset = $REQUEST['offset'];
$action = $REQUEST['action'];
$article = $_REQUEST['article'];

You could use [man]extract[/man] as sidney suggested, but that has the same security implications as leaving [man]register_globals[/man] on.