Error Message

niall_buckley

hi,

Can anyone tell me what this error message means..is it because the server doesn't support php....?

/*********************************************/
Notice: Undefined variable: title in E:\Webs\stylesheet.php on line 14
/*********************************************/

Thanks

laserlight

No, it just means that you need to check your incoming variables with [man]isset/man or [man]empty/man before using them.

Or you are using variables without initializing them.

niall_buckley

The same code is workin on my laptop...when i transfer the code to the server i get these error messages....I make no changes to the code at all...they are all initialized...

laserlight

Nope.

It just means that your laptop has error reporting set to E_ALL & ~E_NOTICE
while your server has error reporting set to
E_ALL

This is good for a development environment, as it can help you spot minor mistakes like unchecked incoming variables.
On the production website, it would make more sense to use E_ALL & ~E_NOTICE, then turn off display_errors and log errors instead.

niall_buckley

How do i go about doing this

Thanks for your help

laserlight

It depends on your script.

Generally, if the variable is from the $GET, $POST, $_COOKIE arrays, it usually should be checked for valid user data before use.
To start off, consider isset() or empty().

niall_buckley

Here is the code for my page

  <html>
  <head>
    <title>BSTL</title>
    <style>
      body { font-family: Arial, Helvetica, sans-serif; font-size: 13px; color: #000000 }
      li, td { font-family: Arial, Helvetica, sans-serif; font-size: 13px }
      hr { color: #3333cc; width=300; text-align=left}
      a { color: #000000 }
      .center { text-align: center }
      .image { text-align: center; background: #081B39 }
      .login { color: #FFFFFF; background: #081B39 }
      .right { text-align: right }

</style>

  </head>
<?php

 require_once("stylesheet.php");

 do_html_header();

 ?>

  <div class="center">
  <form method=post action="order.php">
  <table class="login">
   <tr>
     <td colspan=2>Please log in:</td>
   <tr>
     <td>Employee Number:</td>
     <td><input type=text name=username></td></tr>
   <tr>
     <td>Password:</td>
     <td><input type=password name=passwd></td></tr>
   <tr>
     <td colspan=2 align=center> 
     <input type=submit value='Log in'></td></tr>
 </table></div></form>

 <?php

 do_html_footer();
?>

and here is the stylesheet.php where the error is coming from....
what can i change to stop the message and will i have to do it for all of my pages

<?php
function do_html_header()
{
  // print an HTML header
?>

  <body>
  <div class="center">
  <table width="100%" border="0" cellpadding="0" cellspacing="0"><tr><td class="image">
  <img src="images\bschdr_tul.jpg" width=800 height=77 alt="Boston Scientific Tullamore" border="0">
  </td></tr></table></div><br><br>

<?php
  if($title)//gettin error here
    do_html_heading($title);
}
/******************************************************************************/
function do_html_footer()
{
  // print an HTML footer
?>
  </body>
  </html>
<?php
}
/******************************************************************************/
function do_html_heading($heading)
{
  // print heading
?>
  <!--<h2><?=$heading?></h2>-->
<?php
}
/********************************************************************************/
function login($username, $password)
// check username and password with db
// if yes, return true
// else return false
{
  // connect to db
  $conn = odbc_connect('Canteen' , '', '') or die("<h1>Error1</h1>");
  if (!$conn)
    return 0;

  // check if username is unique
  $strSQL = "select * from users where EmployeeNo='$username' and password = '$password'";
                         //and pass = password('$password')";
                         //echo $strSQL;

  //$result = odbc_exec($conn, $strSQL) or die("<h1>Error3</h1>"); 

  $result= odbc_exec( $conn, $strSQL);

    if (!$result) 
{ 
    exit("Error in query"); 
} 

  if (odbc_fetch_row($result)>0)
     return 1;
  else 
     return 0;

  odbc_free_result($result);
  odbc_close($conn);
}
?>

thank you so much

laserlight

Where in do_html_header() is $title first declared?

You would see that the first time you use it, you use it to check its value.
But it doesnt exist yet... so it doesnt make sense to check its value.

niall_buckley

I have the php.ini can i not change E_ALL to E_ALL & ~E_NOTICE

laserlight

Of course you can.

But that just hides from yourself a problem with your code, sort of burying your head in the sand.

niall_buckley

It will work though..will it will there be any long term problems

laserlight

It is your script, so you're in a better position to make that judgement.

In my case, I would fix the problem.