Links don't display properly

Radon3k

Here is the script in action. If you hit "Edit News" it brings up some more links. When you click one of these links, it should display a form field with the values filled in (the values are coming from a database), but it doesn't. Any idea as to why? Here is the code:

<html>
<head>
<title></title>
</head>
<body>

<?php

$db = mysql_connect("localhost", "user", "password") or die(mysql_error());
mysql_select_db("dbname", $db) or die(mysql_error());

if(empty($_GET['action']))
{
	echo("<a href='test4.php?action=submitnews'>Submit News</a><br />");
	echo("<a href='test4.php?action=editnews'>Edit News</a><br />");
}

if($_GET['action'] == "submitnews")
{
	echo("<form name='submitNews' method='post' action='$PHP_SELF'>");
	echo("Subject: <input type='text' name='subject'><br />");
	echo("News: <textarea name='subnews' rows='10' cols='45'></textarea><br />");
	echo("<input type='submit' name='submit' value='Submit'><br />");
	echo("</form>");

if($_POST['submit'] == "Submit")
{
	$insert = mysql_query("INSERT INTO news (ID, date, subject, news) VALUES ('', NOW(), '$subject', '$subnews')") or die(mysql_error());
	if($insert)
	{
		echo("Submitted.");
	} else {
		echo("Error.");
	}
}
}

if($_GET['action'] == "editnews")
{
	$getNews = mysql_query("SELECT * FROM news") or die(mysql_error());
	while($row = mysql_fetch_array($getNews))
	{
		$id = $row['ID'];
		$subject = $row['subject'];
		$news = $row['news'];
		echo("<a href='test4.php?action=editnews&newsid=$id'>Edit News ID# $id<br />");
	}

echo($id);
if(($_GET['action='] == "editnews") && ($_GET['newsid'] == $id))
{
	echo("<form name='newForm' method='post' action='$PHP_SELF'>");
	echo("Subject: <input type='text' name='newsubject' value='$subject'><br />");
	echo("News: <textarea name='newNewsBox' value='$news' rows='10' cols='45'></textarea><br />");
	echo("<input type='submit' name='newSubmit' value='Submit'><br />");
	echo("</form>");

	if($_POST['newSubmit'] == "Submit");
	{
		$update = mysql_query("UPDATE news SET subject = '$newsubject', news = '$newNewsBox' WHERE ID = '$id'") or die(mysql_error());
		if($update)
		{
			echo("Done.");
		} else {
			echo("Error updating.");
		}
	}
}
}

?>

Thanks. 🙂

drew010

its executing the first if statement:
if($_GET['action'] == "editnews")
every time, whether newsid is set or not.
you will want to do something this:

if($_GET['action'] == "editnews")  {
    if(isset($_GET['newsid'])) {
        //query for getting news stuff
    } else {
        //query to list the news id's
}

Radon3k

Thanks. Now I've managed to get the form fields to display but it only shows the form fields on the last ID link. I can't get it to display the form fields on any other links.

drew010

can you post the updated code so i can see whats going on?

Radon3k

Oddly enough, the code above is what worked. I just moved it to a different area and it worked fine. It may have had something to do with my cache.

Also, if I take that last bit about what to do if the form is submitted, it says "Done" (as in, the action has been performed successfully) all the time, even if the button hasn't been pressed. So not only does it only show the values for the last link, it only shows the title (and not the actual news part) and the form is somehow auto-submitting. Thanks for any help. 🙂

drew010

yeah it looked like some things were placed where they shouldnt be. you need to check the sequence of events and step thru the code in your head and make sure things dont get executed when they shouldnt be and that they get executed when they should be.