Foreach &amp; str_replace error

Foreach & str_replace error

dbr1066

I'm having problems combining a str_replace with a foreach statement.

Here's the situation: I want to retrieve data from a mysql database, strip out the spaces in the data and replace them with underscores (to create a URL without spaces). Then I want to print out a list of the data (this will be used for site navigation.

Here's the code (omitting the database connection)

                       [code=php] <?php

$towns = mysql_query("SELECT DISTINCT Town FROM all3 WHERE County = 'SomeCounty' ORDER BY Town asc");
echo ("SomeCounty Locations ");

//Here's where the spaces are replaced by underscores

$mytowns = str_replace(" ", "_", $towns);

//Now the $mytown variables are looped

foreach ($mytowns as $mytown);
{
echo ("<a href=\"/hotels/CountyName/$mytown" . ".htm\" class=\"mystyle\">");

//Here I want to print the $towns names WITHOUT underscores. I know that what I have here can't be right, but I'm not sure how to get the values I want without the underscores.

       echo ("$town");
	   echo ("</a><br>");

}
?>[/code]

Well, all I get is
parse error, unexpected ')' ... or
Invalid argument supplied for foreach() ...

It goes without saying that I'm new to this, and I'm obviously missing something basic :-)
Any help would be very gratefully received.

drew010

the problem is that $mytowns is a mysql resource identifier and you are str_replacing in it and then passing it to foreach. you really arent passing an array. first you will need a call to mysql_fetch_array or _row in a loop to get all the data from sql and then run the str_replace on them from there.

dbr1066

Thanks drew010

When you say I need to do a mysql_fetch_array or _row in a loop, I'm not sure I understand what you mean.

I gather that you're saying I need to create an array with my mysql query, then do str_replace on the array, and then follow that with my foreach statement. But am I not already creating an array with this line?

$towns = mysql_query("SELECT DISTINCT Town FROM all3 WHERE County = 'SomeCounty' ORDER BY Town asc");

Isn't $towns now an array of all the selected "Town" fields?

Sorry, I'll bet this is obvious to someone who knows what they're doing :-)

drew010

if you check out the manual, heres what it says about mysql_query:
resource mysql_query ( string query [, resource link_identifier])
doing mysql_query actually returns a resource id to the query. you then need to do something like this:

$towns = mysql_query("SELECT DISTINCT Town FROM all3 WHERE County = 'SomeCounty' ORDER BY Town asc");
while($data = mysql_fetch_row($result)) {
    $town = str_replace(" ", "_", $data[0]);
    echo "<a href=\"/hotels/CountyName/" . $town . ".htm\" class=\"mystyle\">$town</a><br>";
}

dbr1066

Thanks drew010,

Your help is very much appreciated. Your suggested code works great for my purposes. Thanks!