PHP_SELF Undifined

andoi

Hi
Can anybody help me. I am currently trying to write a php script which will allow a user to add a record to a database using sql. When the form first loads up it is supposed to just display the contents of the database and then if the user then clicks on the link "add a food" textboxes allowing them to add a record will be loaded. I cannot get it to work properly - an error appears 'Notice: Undefined variable: PHP_SELF in E:\Program Files\Apache Group\Apache2\htdocs\add.php on line 76'. The contents of the database are displayed but when I click on the 'add a food' link, nothing happens. There may be quite a few mistakes in the code coz im pretty new to this Php stuff! cheers

The script:

<FORM ACTION="?php echo($PHP_SELF);?>" METHOD="POST">
<P>Food name<BR>
<TEXTAREA NAME="Food" Rows="1" COLS="40" WRAP></TEXTAREA>
<P>Energy (Kcals)<BR>
<TEXTAREA NAME="Energy" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Protein (g)<BR>
<TEXTAREA NAME="Protein" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Fat (g)<BR>
<TEXTAREA NAME="Fat" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Carbohydrates (g)<BR>
<TEXTAREA NAME="Carbo" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Calcium (g)<BR>
<TEXTAREA NAME="Calcium" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Iron (mg)<BR>
<TEXTAREA NAME="Iron" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Sodium (mg)<BR>
<TEXTAREA NAME="Sodium" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Vitimin A (mmg)<BR>
<TEXTAREA NAME="VitA" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Vitimin C (mg)<BR>
<TEXTAREA NAME="VitC" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<INPUT TYPE="SUBMIT" NAME="Submitfood" VALUE="SUBMIT">
</FORM>

<?php
else:

//connect to the database server
$dbcnx = @mysql_connect();
if(!$dbcnx) {
echo("<P>Unable to connect</P>");
exit();
}

//select the food database
if(! @mysql_select_db("Foods")) {
echo("<P>Unable to locate the food database</P>");
exit();
}

//if a food has been submitted, add it in

if("SUBMIT" == "submitfood") {
$sql = "INSERT INTO breakfast SET".
"Food = '$food',".
"Energy = '$Energy',".
"Protein = '$Protein',".
"Fat = '$Fat',".
"Carbo = '$Carbo',".
"Calcium = '$Calcium',".
"Iron = '$Iron',".
"Sodium = '$Sodium',".
"VitA = 'VitA',".
"VitC = 'VitC'";
if(mysql_query($sql)) {
echo("<P>The food item has been successfully added</P>");
}else{
echo("<P>Error adding food to the database:" .mysql_error(). "<P>");

}
}

echo("<P>HERE ARE THE BREAKFAST FOODS IN THE DATABASE</P>");

$result=mysql_query(
"SELECT * FROM Breakfast");
while($row = mysql_fetch_array($result)){
echo("<P>" .$row["Food"]. "<P>");
}

echo("<P><A HREF='$PHP_SELF?addfood=1'>". "add a food!</A></P>");
endif;

?>
</BODY>
</HTML>

bubblenut

global_variables is switched off (as it should be) so you have to access PHP_SELF through the global array $_SERVER['PHP_SELF']

HTH
Bubble

andoi

ok thanks 4 your advice. I have changed these two lines of code:

<FORM ACTION="?php $_SERVER['PHP_SELF'];?>" METHOD="POST">

echo("<P><A HREF='$_SERVER['PHP_SELF']?addfood=1'>". "add a food!</A></P>");

but now i get this error:

Parse error: parse error, unexpected T_ENCAPSED_AND_WHITESPACE, expecting T_STRING or T_VARIABLE or T_NUM_STRING in E:\Program Files\Apache Group\Apache2\htdocs\add.php on line 76

what have I got wrong?

TruckStuff

what have I got wrong?

Poor programming style and no understanding of strings in PHP.

<FORM ACTION="<?php echo $_SERVER['PHP_SELF'];?>" METHOD="POST"> 

<?
echo('<P><A HREF="'.$_SERVER['PHP_SELF'].'?addfood=1">add a food!</A></P>'); 
?>

andoi

I never did claim to be an expert????

Anyway, I have made the changes suggested above and the script still doesnt work & I cant see why. Anyone?

<FORM ACTION="<?php echo $_SERVER
['PHP_SELF'];?>" METHOD="POST">

<P>Food name<BR>
<TEXTAREA NAME="Food" Rows="1" COLS="40" WRAP></TEXTAREA>
<P>Energy (Kcals)<BR>
<TEXTAREA NAME="Energy" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Protein (g)<BR>
<TEXTAREA NAME="Protein" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Fat (g)<BR>
<TEXTAREA NAME="Fat" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Carbohydrates (g)<BR>
<TEXTAREA NAME="Carbo" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Calcium (g)<BR>
<TEXTAREA NAME="Calcium" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Iron (mg)<BR>
<TEXTAREA NAME="Iron" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Sodium (mg)<BR>
<TEXTAREA NAME="Sodium" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Vitimin A (mmg)<BR>
<TEXTAREA NAME="VitA" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Vitimin C (mg)<BR>
<TEXTAREA NAME="VitC" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<INPUT TYPE="SUBMIT" NAME="Submitfood" VALUE="SUBMIT">
</FORM>

<?php
else:

//connect to the database server
$dbcnx = @mysql_connect();
if(!$dbcnx) {
echo("<P>Unable to connect</P>");
exit();
}

//select the food database
if(! @mysql_select_db("Foods")) {
echo("<P>Unable to locate the food database</P>");
exit();
}

//if a food has been submitted, add it in

echo("<P>HERE ARE THE BREAKFAST FOODS IN THE DATABASE</P>");

$result=mysql_query(
"SELECT * FROM Breakfast");
while($row = mysql_fetch_array($result)){
echo("<P>" .$row["Food"]. "<P>");
}

echo('<P><A HREF="'.$_SERVER['PHP_SELF'].'?addfood=1">add a food!</A></P>');

endif;
?>

</BODY>
</HTML>

laserlight

If you want to use PHP's alternative syntax for control structures, then stick to it.
i.e. use:
```
if (conditionA) {
	if (conditionB) {
	}
}
```
or
```
if (conditionA):
	if (conditionB):
	endif;
endif;
```
dont mix them up.
```
if("SUBMIT" == "submitfood") {
```
"SUBMIT" is a string literal, and so is "submitfood".
Since the strings are not the same, the conditional always evaluates to a false value.
What you probably want is to compare a variable, say $SUBMIT to a string literal.

tekky

first we start off with [ PHP] tags...

<HTML>
<BODY>
<?php
//note the colors... they are not here just for looks...
//they make things nice and easy to read...

if(isset($addfood)):
?>

<FORM ACTION="<?php echo $_SERVER
['PHP_SELF'];?>" METHOD="POST">

<P>Food name<BR>
<TEXTAREA NAME="Food" Rows="1" COLS="40" WRAP></TEXTAREA>
<P>Energy (Kcals)<BR>
<TEXTAREA NAME="Energy" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Protein (g)<BR>
<TEXTAREA NAME="Protein" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Fat (g)<BR>
<TEXTAREA NAME="Fat" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Carbohydrates (g)<BR>
<TEXTAREA NAME="Carbo" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Calcium (g)<BR>
<TEXTAREA NAME="Calcium" Rows=1 COLS="40" WRAP></TEXTAREA><BR> 
<P>Iron (mg)<BR>
<TEXTAREA NAME="Iron" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Sodium (mg)<BR>
<TEXTAREA NAME="Sodium" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Vitimin A (mmg)<BR>
<TEXTAREA NAME="VitA" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<P>Vitimin C (mg)<BR>
<TEXTAREA NAME="VitC" Rows=1 COLS="40" WRAP></TEXTAREA><BR>
<INPUT TYPE="SUBMIT" NAME="Submitfood" VALUE="SUBMIT">
</FORM>

<?php
else:

//connect to the database server
$dbcnx = @mysql_connect();
if(!$dbcnx) {							
echo("<P>Unable to connect</P>");
exit();
}; //note the added ; (per php.net user contribs it's needed)
/* you really should stick with one format, its easier
    and unless you have a special need of a particular format...
    nicer to read...
 */

//select the food database
if(! @mysql_select_db("Foods")) {
echo("<P>Unable to locate the food database</P>");
exit();
}; //heres that ; again...


//if a food has been submitted, add it in

if("SUBMIT" == "submitfood") {
$sql = "INSERT INTO breakfast SET".
	"Food = '$food',".
	"Energy = '$Energy',".
	"Protein = '$Protein',".
	"Fat = '$Fat',".
	"Carbo = '$Carbo',".
	"Calcium = '$Calcium',".				
	"Iron = '$Iron',".
	"Sodium = '$Sodium',".
	"VitA = 'VitA',".
	"VitC = 'VitC'";
/*
  holy hell, not going to try and decipher this mess anymore...
  per the user contrib... you need to add a ; after multi-line if
  statements inside of the shorthand if (check): else : endif;
  formats....  good luck from here on
 */

if(mysql_query($sql)) {
echo("<P>The food item has been successfully added</P>");
}else{
echo("<P>Error adding food to the database:" .mysql_error(). "<P>");					}
}

echo("<P>HERE ARE THE BREAKFAST FOODS IN THE DATABASE</P>");

$result=mysql_query(
"SELECT * FROM Breakfast");
while($row = mysql_fetch_array($result)){
echo("<P>" .$row["Food"]. "<P>");
}

echo('<P><A HREF="'.$_SERVER['PHP_SELF'].'?addfood=1">add a food!</A></P>');  

endif;
?>

</BODY>
</HTML>

[note: end of pretty colors.... sigh --]

andoi

Im still having problems with this script. I have tried all the suggested corrections and i cant get it to work properly. I now have a script almost identical to above - but when I click on the 'add a food!' link, nothing happens - I want the page to reload, displaying all of the textareas. Can anyone help??
thanks

laserlight

Create a separate script.

Use this in your script:

<?php
if ("SUBMIT" == "submitfood") {
	echo '"SUBMIT" == "submitfood"';
}
else {
	echo 'it doesnt make sense';
}
?>

Basically, you need to grasp some very basic concepts.
To help yourself understand, take out parts of your main script, and try them in a small test script, with nothing else to distract you.
Then learn from it.