[Resolved] Something wrong in my code

Daegalus

Well I figured out a way to do the Spoiler lists. but I can't get it to show up. When I run this query in MySQL it works. Just the PHP one won't.

					<a href="spoiler.php?set=MFC">MFC</a> - 
					<a href="spoiler.php?set=DCR">DCR</a> - 
					<a href="spoiler.php?set=IOC">IOC</a>
					<br /> <br />
					<?php
					mysql_connect (localhost,***,***) or die ( mysql_error ());
					mysql_select_db (cards)or die ( mysql_error ());
					$row = mysql_query('SELECT number,name,type,attribute,subtype,level,atk,def,rarity,cardtext FROM SETS WHERE 1 AND `SET` = `$set`')
					echo $row
					?>

Can anyone tell me what im doing wrong?

[Edit]

RESOLVED!!!!

eoghain

Read the manual on [man]mysql_query/man. Go on, I'll wait, and no this isn't a RTFM response.

When you look at what [man]mysql_query/man returns you'll see that is says resource. This means it's returning you a handle to something that you can use to get your data, not the data itself. What you need to do is use that resource to get the data (what if your query returned multiple rows?).

So what you want to do is this:

$result = mysql_query('SELECT  number,name,type,attribute,subtype,level,atk,def,r
arity,cardtext FROM SETS WHERE 1 AND `SET` = `$set`') 

while ($row = mysql_fetch_array($result,MYSQL_ASSOC)) {
   echo "Number = " . $row["number"] . "<br>";
   echo "Name = " . $row["name"] . "<br>";
   echo "Type = " . $row["type"] . "<br>";
   echo "Attribute = " . $row["attribute"] . "<br>";
   echo "SubType = " . $row["subtype"] . "<br>";
   echo "Level = " . $row["level"] . "<br>";
   echo "Atk = " . $row["atk"] . "<br>";
   echo "Def = " . $row["def"] . "<br>";
   echo "Rarity = " . $row["rarity"] . "<br>";
   echo "CardText = " . $row["cardtext"] . "<br>";
}

Ofcourse this code could be cleaned up alot, but it shows you how to properly use the [man]mysql_query/man function.

Daegalus

1 question:

How can I make the Fields at the TOP, and the information to be vertical.

Ex:

Number | Name | Type | Attribute | Subtype|

eoghain

Format it that way. Sorry for the pat answer, but you can do whatever you want with the data once you have it. I was just showing you how to get to the data. But since you ask (I really reccomend that you figure these things out on your own, how else are you going to learn?).

$rowcount  = 0;
echo "<table>";
while ($row = mysql_fetch_array($result,MYSQL_ASSOC)) { 
   echo "<tr>";
   if ($rowcount == 0) {
      foreach ($row as $key => $value) {
         echo "<th>$key</th>";
      }
      echo "</tr><tr>";
   }

   foreach ($row as $key => $value) {
      echo "<td>$value</td>";
   }
   echo "</tr>";
}
echo "</table>";

Daegalus

Thanks for all the help. All i need to do now is figure out why the results aren't showing up. I've tried 4 different ways to retrieve the results, and it still won't. If you want you can test it youself:

http://yc.servegame.com/spoiler.php

The results wont show. If you want i'll make a phps version of the page if you want to see the whole source.

eoghain

Well without seeing the exact code I wont be able to help you solve your display problem. So either put all of the code here, or make that .phps page and I'll take a look at it.

Daegalus

Ok the phps is at http://yc.servegame.com/spoiler.phps

Sorry it took a while, I forgot I turned off PHPS cause my stupid cousin kept on ripping off my source code, Especially on PHP heavy pages.

eoghain

Well the code you currently have in your .phps is the same as the code in your original post.

Daegalus

I know, I was testing it. And my original post didnt have the mysql_fetch_row thing. I did try yours also.

Its now with the code you provided.

eoghain

Are you positive that your $set value is being passed in through your frames?

If you look at the source of your page you will see that the <table> and </table> tags are being outputted, but nothing inside of them is. And looking at the code all the rest of the tags are inside the while loop, and if your query isn't returning any values then nothing would get printed.

I'd add an echo "<b>Set = $set</b><br>" line before the echo "<table>" line to double check that that value is set.

Also your query starts and ends with single quotes (') and you have single quotes inside your string. PHP won't convert variables inside single quotes so change your query line to this:

$sql = "SELECT   number,name,type,attribute,subtype,level,atk,def,rarity,cardtext FROM SETS WHERE 1 AND SET = '$set'";

$result = mysql_query($sql);

You should always build your queries into a separate variable so that if you have problems you can output that variable to the screen to see if you have any problems with the generation of the query.

Daegalus

Ok, I'll try that, and also there is a difference in the quotes. One of them is teh single quote that is on the same kwy as double quote. The other one is diagnal single quote next to the 1 key on the keyboard. On the same key as ~

But it seems that the ?set= isnt getting passed onto the rest of the script. How can I fix that?

I updated both pages on the server, php and phps.

[Edit] Do you use $_GET ?

eoghain

I don't use frames so if that is what is causing your variables to not appear then you'll need to ask someone else.

But if you are using a newer version of PHP and didn't specifically set the register_variables directive then $set won't exist and you'll have to use $_GET["set"].

Daegalus

I dont know where you got it that I use frames. I dont use frames, its all tables.

But I tried $_GET["set"] and it still wont work. Im using PHP 4.3.3 and Apache 1.3.28 so i think Im ok.

eoghain

I get that you are using frames because when I select to view source on your page I get this:

<HTML>
<!-- WEB REDIRECTION PROVIDED BY NO-IP.COM  [url]http://www.no-ip.com/[/url] -->
<HEAD>
<TITLE>Yu-Gi-Oh! Central</TITLE>


<meta name="keywords" content="">
<meta name="description" content="">

<script>

var popunder=new Array()
popunder[0]="http://www.no-ip.com/pop_u.php?h=yc.servegame.com"


var width = '500'; 
var height = '430';

var p = 'scrollbars=no,resizable=no,toolbar=no,' + 
'menubar=no,status=no,location=no,left=85,top=20,height=' +  

height + ',width=' + width;


var one_time=1



function get_cookie(Name) {
  var search = Name + "="
  var returnvalue = "";
  if (document.cookie.length > 0) {
    offset = document.cookie.indexOf(search)
    if (offset != -1) { 
      offset += search.length
      end = document.cookie.indexOf(";", offset);

if (end == -1) 
     end = document.cookie.length;
     returnvalue=unescape(document.cookie.substring(offset, end))
  }
   }
  return returnvalue;
}

function loadornot(){
if (get_cookie('popunder')==''){
load_pop_power()
var exp = new Date();
exp.setTime(exp.getTime() + (10800*1000) );

document.cookie="popunder=yes"+ "; expires=" + exp.toGMTString() 
}
}

function load_pop_power(){
win2=window.open(popunder[Math.floor(Math.random()*(popunder.length))],"bw",p)
win2.blur()
window.focus()
}

if (one_time==0)
load_pop_power()
else
loadornot()



</script>



</HEAD>
<FRAMESET  ROWS="100%,*" FRAMEBORDER=NO FRAMESPACING=0 BORDER=0>

<FRAME SRC="http://64.81.52.220:81/spoiler.php" NAME="redir_frame">

</FRAMESET>
<NOFRAMES>
Sorry, your browser does not support frames.  Click <A HREF="http://64.81.52.220:81/spoiler.php" TARGET=_top>here</A>
</NOFRAMES>

</HTML>

So you probably aren't the one using frames, but something is. And if you can't get the variables in your source then you will never be able to make this work.

Daegalus

I use No-IP.com as a port redirector. My dad is using port 80 for his stuff and i use port 81 for mine. No-ip.com put those frames in.

But even when i use my lan ip it wont work.

The thing is, My dad has 3 domains. But he has no clue how to make a subdomain to point to my server. Cause internally my server is also running on port 80, I just do a quick port forwarding on my router from port 81 to port 80 for my server. If i can only get a subdomain on port 80 to point to port 81 then everything would be easy peasy.

eoghain

I just checked your source and you are still using $set and not $_GET["set"].

I'd suggest that you build this page somewhere:

<?php
php_info();
?>

And try calling it with ?set=test and see if you can find where that variable is being set. Don't leave this page in existance once you solve your problem because it gives out too much information to people to be safe, but it's useful for debugging.

I've got to go now, so good luck.

Daegalus

Thanks, I finally figured it out and its working great. Try it yourself! Thanks again for all the help.