Creating a login... help?

[Litninfingers63]

I'm creating a login script. This is with out cookies or sessions right now. I'm new 😉

So here is what I have.

$uname = $_POST['uname'];
$pass = $_POST['pass'];
$submit = $_POST['submit'];

if (isset($submit)) {
	$login = mysql_query("SELECT * FROM clients WHERE uname = '$uname' AND pass = '$pass'") or die ("What happend was ". mysql_error());
	$row = mysql_fetch_row($login) or die ("What happend was this: ". mysql_error());

$unamedb = $row['uname'];
$passdb = $row['pass'];

	if ($unamedb = $uname && $passdb = $pass) { 
	echo "logged in"; 
	} else { 
	echo "not logged in"; 
	}
}

So right now, when you log in correctly, it works. It says "logged in", but if you do not login correctly, or do not put a valid username or pass it just says "what happend was" and that's it.

I think it has to do with the array, but I'm not exactly sure what i need to do to check? 🙁

[dalecosp]

Looks like it simply craps out because $row is FALSE, and there's nothing by "What happened was" 'cause there's no error, just a null (FALSE) return value.

How about

$uname = $_POST['uname']; 
$pass = $_POST['pass']; 
$submit = $_POST['submit']; 

if (isset($submit)) { 
    $login = mysql_query("SELECT * FROM clients WHERE uname = '$uname' AND pass = '$pass'") or die ("What happened was ". mysql_error()); 

if (mysql_num_rows($login) ==1) {
      echo "logged in";
      exit();
 } else {
      echo "login failed";
 }

} else {

ShowLoginForm();  // or whatever your form code is

} 

[mmilano]

Originally posted by dalecosp
Looks like it simply craps out because $row is FALSE, and there's nothing by "What happened was" 'cause there's no error, just a null (FALSE) return value.

well yea, cause u are telling it to die 🙂

try taking the 'die' out.

$pass = $_POST['pass']; 
$submit = $_POST['submit']; 

if (isset($submit)) { 
    $login = mysql_query("SELECT * FROM clients WHERE uname = '$uname' AND pass = '$pass'"); 

if (mysql_num_rows($login) ==1) {
      echo "logged in";
      exit();
 } else {
      echo "login failed";
 }

} else {

ShowLoginForm();  // or whatever your form code is