(!empty($file)) not working???

[darthmahon]

Hi,

I have a script that lets users upload files etc, but I have also put in place an option for them to edit the file, i.e replace it with a new one.

The data is all stored in a db.

Now, I have set up the following simple script here as my other page is quite long, but as you can see, it doesn't actually work...

<?

if (!$submit)

{

?>

<form action="<? echo $PHP_SELF; ?>" method="POST" enctype="multipart/form-data">
<input name="file" type="file" id="file">
<input type="Submit" name="submit" value="Update">
</form>

<?
}

// form submitted

// start processing it

else

{

if (!empty($file)) {

	echo "EMPTY";

} else {

	echo "NOT EMPTY";

}


}

?>

Why is it telling me the file is empty, even when I have choosen something using the browse?

Any ideas?

Cheers,
Chris

[leatherback]

You are checking whether it is NOT empty: Note the "!" in front of empty

J.

[darthmahon]

Removed the ! and it is still giving me the wrong information...

Basically, I need something that does:

if (empty($file)) {

upload new file

} else {

do nothing

}

So if the file select box is empty and I haven't chosen anything, do nothing. If I have chosen something then upload new file.

I've no idea why this is giving me this weird data?

[leatherback]

Did you try:

If(isset($file))
{
}
else
{
}

[darthmahon]

No but I just tried it, same thing.

This is very odd, the solutions above work on everything but a file select.??

[Strings]

How about:

if($_FILES['userfile']['size']==0)
{
 echo 'File is empty';
}
else
{
 //put the upload file function here...
}

[darthmahon]

That did the trick strings, thanks a bunch 🙂