If statements doing my head in...

[darthmahon]

Got a lot of if statements in other if statements. Now, problem is I don't want things updating in the database if other things haven't been selected to be changed.

This is the code for the SQL:

if ($Type == "networkuni") {

						if (empty($city) || empty($country)) {

							$query = "UPDATE NETWORKUNI SET picture = '$picture', title = '$title', shorttext = '$shorttext', `text` = '$text', level = '$level', `url` = '$url' WHERE networkuniid = '$id'";

						} else {

							$query = "UPDATE NETWORKUNI SET picture = '$picture', title = '$title', shorttext = '$shorttext', `text` = '$text', level = '$level', `url` = '$url', filecat = '$country', filesubcat = '$city' WHERE networkuniid = '$id'";

						}

						if (empty($picture)) {

							$query = "UPDATE NETWORKUNI SET title = '$title', shorttext = '$shorttext', `text` = '$text', level = '$level', `url` = '$url' WHERE networkuniid = '$id'";

						} else {

							$query = "UPDATE NETWORKUNI SET picture = '$picture', title = '$title', shorttext = '$shorttext', `text` = '$text', level = '$level', `url` = '$url', filecat = '$country', filesubcat = '$city' WHERE networkuniid = '$id'";

						}

} else if ($Type == "venue") {

						$query = "UPDATE MEETINGS_VENUES SET title = '$title', directions = '$directions', map = '$map', area = '$area', address = '$address' WHERE venueid = '$id'";

					}

The problem seems to be the if statements in the networkuni $Type...

I want to do a check. Because if I use the form, and I leave one of those options blank, for example $picture, but I select something in both $city and $country, then I want it to update the $city and $country fields, but not the picture field and vice versa, if I select a $picture but nothing else, then only update the $picture field.

If I select both then update both fields. If I select nothing, don't update anything.

I'm not sure which is the best way about this, any ideas guys?

Cheers,
Chris

[dnast]

You could query the record before hand to get the previous results, using them as defaults.

Like:

$query = "SELECT * FROM NETWORKUNI WHERE networkuniid = '$id'";
$result = mysql_query($query);
$row = mysql_fetch_array($result);

$picutre = empty($picture) ? $row['picture'] : $picture;
$title = empty($title) ? $row['title'] : $title;
$shorttext = empty($shorttext) ? $row['shorttext'] : $shorttext;
...

Then just update all fields.

[darthmahon]

Hmm tried that, doesn't seem to be working.

Could you explain what exactly it is mean to be doing.

I'm getting the query and making it into an object:

$row = mysql_fetch_object($result);

And then using:

$picture = empty($picture) ? $row->picture : $picture;

$country = empty($country) ? $row->filecat : $country;

$city = empty($city) ? $row->filesubcat : $city;

Is it doing the following:

declare variable, if empty use $row->picture else use $picture??

It seems that when I leave something blank, it's not picking up the correct $row->variablename.

So it looks like something is wrong with the empty($variable) ? $row->variable section perhaps?

[darthmahon]

Ahh ok got it working, I wasn't carrying over the $row set properly, now I have another question.

This is how my code works:

<?

$id = $_REQUEST['id'];

$query = "SELECT * FROM $SelectTable WHERE $SelectField = $id";

$result = mysql_query($query) or die ("Error in query: $query. " . mysql_error());

// form not yet submitted

// display initial form with values pre-filled

if (!$submit)

{

// if a result is returned

if (mysql_num_rows($result) > 0)

{

	// turn it into an object

	$row = mysql_fetch_object($result);

	// print form with values pre-filled

?>

Form Code goes here

<?

}

// no result returned

else

{

	echo "<p>That Record could not be located in the database.<br><br><a href=javascript:history.back(-1)>Go back and try again.</a></p>";

}

}

// form submitted

// start processing it

else

{

$keepdataquery = "SELECT * FROM $SelectTable WHERE $SelectField = $id";
$keepdataresult = mysql_query($keepdataquery);
$keepdatarow = mysql_fetch_object($keepdataresult);	

$picture = empty($picture) ? $keepdatarow->picture : $picture;
$country = empty($country) ? $keepdatarow->filecat : $country;
$city = empty($city) ? $keepdatarow->filesubcat : $city;

// perform other actions

?>

As you can see, I have to have two querys to get the value of the data in the table.

Now I can't have the bottom part of the code before the submit button, because how can it check if something is empty if it hasn't been submitted?

How could I do this so I don't have to have two different query's? Some hidden fields that pass the variable contained in those fields?