[Resolved] Preg Problem

[webmasternovis]

Hi all,

I'm searching the source of a webpage, and trying to echo all links that start with http onto another page. So if the link just leads to "resource.html" or something, it shouldn't be echoed.

Here's my code:

$file_lines = file('http://www.example.com');

foreach($file_lines as $file) {
    if(preg_match_all('#<a\s+?href=["\'](http)(.+?)["\'].*?>#', $file, $matches)) {
        for ($i = 0; $i < count($matches[1]); $i++) 
            echo $matches[1][$i] . '<br />';
}
}

All that happens though is that it just echos "http", the number of times there is a link that starts with that.

It somehow works on this tester though -> http://www.samuelfullman.com/team/php/tools/regular_expression_tester_p2.php

Please could somebody help?

Thanks a lot,
Mike

[PyroX]

Give this a shot if you want, it actually pulls ALL full URL's not just links.

<?
/*
Simple HTML HTTP URL Grabber
This very simple function pulls URLs from
html and returns the results.
(Limited Usefulness)
@Author: Justin R Carlson, justin(AT)w3abode.com
@Date: 04/30/2004
@param html string
@return array links
*/
function linkparse($code)
{
    $code=ereg_replace("\n","",$code);
        preg_match_all('/(http:\/\/[^\s\"\']*)/is',$code,$out);
        $savedLinks=$out[0];
return $savedLinks;
}
?>

[webmasternovis]

Hi, thanks very much for your reply.

I seem to be getting a parse error though, on line 5?

<?php
function linkparse($code) 
{ 
    $code=ereg_replace("\n","",$code); 
        preg_match_all('/([url]http://[/url][^s\"']*)/is',$code,$out); 
        $savedLinks=$out[0]; 
return $savedLinks; 
} 
?>

It's the preg_match_all line that seems to be wrong, but I'm not too sure on what it is.

Please could anybody help?

Thanks very much,
Mike

[Weedpacket]

Generally speaking, parse errors are the easiest to fix because they're the most blatant. Unless your version is particularly old, PHP will say what it was expecting and/or what it saw when it realised there was an error. Also, parse errors can cause syntax highlighting of PHP code to go haywire - as has happened in your case, where you can see that you escaped the wrong quote.

[webmasternovis]

Yep, that was it 🙂 Thanks Weedpacket!

I've got a harder problem to fix now though, as nothing is being returned. Below is my code:

<?php
$file_lines = file('http://www.example.com');
function linkparse($code) {
foreach($file_lines as $file)
    $code=ereg_replace("\n","",$file);
preg_match_all('/([url]http://[/url][^s\"\']*)/is',$file,$out);
        $savedLinks=$out[0]; 
return $savedLinks;
}
echo $savedLinks;
?>

Sorry to ask again, but please could somebody help?

Thanks very much,
Mike

[webmasternovis]

Anyone know?

Thanks,
Mike

[poison]

$data=join('', file('http://www.phpbuilder.com/'));
preg_match_all('/<a\s+?[^>]*?[^<]*?<\/a>/smi',$data, $result);
for ($i=0; $i<count($result[0]); ++$i) {
	echo $result[0][$i] . "\n";
}

have fun

[webmasternovis]

Heh, thanks very much poison🙂