return results EXCEPT for certain variables - not working

[horstuff]

What I am trying to do is return results EXCEPT if $pid is 195 or 196 or 197. That is not working - it just ignores that first part and shows it anyway, like the bottom part calls out. Ideas? Thanks.

<?php 

include "config.php"; 


if (isset($hostname) and isset($database) and isset($db_login) and isset($db_pass)) { 

$dbconn = mysql_connect($hostname, $db_login, $db_pass) or die("Could not connect"); 
mysql_select_db($database) or die("Could not select database"); 

if (!isset($pid)) { 
    $pid = 195,196,197; 
} 

   $query = "SELECT product_price FROM product_status WHERE product_id='$pid'"; 
   $result = mysql_query($query); 

   $line = mysql_fetch_row($result); 
   $product_price = $line[0]; 
       //echo "$"; 
       //echo addcommas($product_price); 

//} 
    }else if (!isset($pid)) { 
        $pid = 0; 
    } 

   $query = "SELECT product_price FROM product_status WHERE product_id='$pid'"; 
   $result = mysql_query($query); 

   $line = mysql_fetch_row($result); 
   $product_price = $line[0]; 
       echo "$"; 
       echo addcommas($product_price); 

mysql_close($dbconn); 
//} 

?>

[Frederick]

Try using

$pid = "195,196,197";

[ednark]

take a carefull look at your brackets { }

your code is not executing the order you want it to...

the last select is always executing and since both queries read into $result, the second query is overriding the results of the first...

i will repost your exact same code formatted a little different so you can see where you are going wrong...

if (isset($hostname) and isset($database) and isset($db_login) and isset($db_pass))
{ 
    $dbconn = mysql_connect($hostname, $db_login, $db_pass) or die("Could not connect"); 
    mysql_select_db($database) or die("Could not select database"); 
    if (!isset($pid))
    { 
        $pid = "195,196,197"; 
    } 
    $query = "SELECT product_price FROM product_status WHERE product_id='$pid'"; 
    $result = mysql_query($query); 
    $line = mysql_fetch_row($result); 
    $product_price = $line[0]; 
    //echo "$";
    //echo addcommas($product_price);
    //}
} else if (!isset($pid)) { 
    $pid = 0; 
} 

$query = "SELECT product_price FROM product_status WHERE product_id='$pid'"; 
$result = mysql_query($query); 
$line = mysql_fetch_row($result); 
$product_price = $line[0]; 
echo "$"; 
echo addcommas($product_price); 
mysql_close($dbconn); 
//}

[horstuff]

I tried the fix, but it still doesn't work. The bottom half of the script (after else if) is all that is functioning (results far all pid's are being echoed). Could it have something to do with $pid being called in two places

if (!isset($pid)) {

???

Thanks.

[ednark]

the code does not work because you have your brackets in the wrong place...

you need to go back and step through your code and figure out which portions are executing in what order and between which brackets... the way you indented your first post leads me to believe you don't understand correctly what your code is actually doing,

ultimately since both your queries are the same.. you only need to write it once... have your if/else logic choose what value $pid should have, then execute that at the end of the script....

[horstuff]

After trying to clean it up, I get this error:

Warning: mysql_fetch_row(): supplied argument is not a valid MySQL result resource in ........../price.php on line 37

Here is the revised code:

<?php

include "config.php";

function addcommas($price) {
  $kraj = false;
  $first = false;
  $comma = ',';
  $i = strlen($price);
  while ($kraj <> true) {
    if ((substr($price,$i-3,1) == '.') and ($first <> true)) {
        $i = $i - 6;
        $first = true;
    }else{
        $i = $i - 3;
    }
    if ($i > 0) {
       $price = substr_replace($price,$comma,$i,0);
    }else{
       $kraj = true;
    }
  }
  return $price;
}

if (isset($hostname) and isset($database) and isset($db_login) and isset($db_pass)) 
{  

    $dbconn = mysql_connect($hostname, $db_login, $db_pass) or die("Could not connect");  

    mysql_select_db($database) or die("Could not select database"); 

if (!isset($pid)) 
{  
    $pid_list = '195,196,197';  
}  
$query = "SELECT product_price FROM product_status WHERE product_id NOT IN ($pid_list)";  
$result = mysql_query($query);  
$line = mysql_fetch_row($result);  
$product_price = $line[0];  
//echo "$"; 
//echo addcommas($product_price);

} else {  

    $pid = 0;  

}  

$query = "SELECT product_price FROM product_status WHERE product_id='$pid'";  

$result = mysql_query($query);  

$line = mysql_fetch_row($result);  

$product_price = $line[0];  

echo "$";  

echo addcommas($product_price);  

mysql_close($dbconn);   

?>

[horstuff]

Got it working. Here is the code:

<?php

include "config.php";

function addcommas($price) {
  $kraj = false;
  $first = false;
  $comma = ',';
  $i = strlen($price);
  while ($kraj <> true) {
    if ((substr($price,$i-3,1) == '.') and ($first <> true)) {
        $i = $i - 6;
        $first = true;
    }else{
        $i = $i - 3;
    }
    if ($i > 0) {
       $price = substr_replace($price,$comma,$i,0);
    }else{
       $kraj = true;
    }
  }
  return $price;
}

if (isset($hostname) and isset($database) and isset($db_login) and isset($db_pass)) 
{  

    $dbconn = mysql_connect($hostname, $db_login, $db_pass) or die("Could not connect");  

    mysql_select_db($database) or die("Could not select database"); 

if (!isset($pid)) { 
     $pid = 0; 
} 

if ($pid == 197 || $pid == 196 || $pid == 81 || $pid == 195) 
{ 
        print '</b>Please Contact Us<b>'; 
}else{ 

$query = "SELECT product_price FROM product_status WHERE product_id='$pid'";  

$result = mysql_query($query);  

$line = mysql_fetch_row($result);  

$product_price = $line[0];  

echo "$";  

echo addcommas($product_price);  

mysql_close($dbconn);   

}
}
?>

Thanks everybody