Help with quotes

move3rd

<?
while ($row = mysql_fetch_array($result)) {

  //Create variables for use in template class
$table_track_list = "<table width='363' cellpadding='5' cellspacing='1' ><tr><td>".$row['track_num']."
                    ".$row['track_title']."</td><td><form action='edit_track.php' method='POST'>
                    <input type='hidden' name='track_title' value=\"".$row['track_title']."\">
		            <input type='hidden' name='track_num' value=\"".$row['track_num']."\">
		            <input type='hidden' name='artist' value=\"".$row['artist']."\">
		            <input type='hidden' name='cd_title' value=\"".$row['cd_title']."\">
		            <input name='POST' type='submit' value='Edit'></td></tr></table>";
	                                      }//End While Statment

$tracks_by = "Edit Tracks On $cd_title by $artist";
$hidden_input_artist = "<input type='hidden' name=\"artist\" value=\"$artist\">";
$hidden_input_cd_title = "<input type='hidden' name=\"cd_title\" value=\"$cd_title\">";

//include template class
include ($home_dir."templates/ultratemplate.php");

$oTemplate = new UltraTemplate();
//template for this script
$oTemplate->load($home_dir."templates/admin/edit_tracks.php");
//define template variables
$oTemplate->tag("tracks_by","$tracks_by");
$oTemplate->tag("hidden_input_artist","$hidden_input_artist");
$oTemplate->tag("hidden_input_cd_title","$hidden_input_cd_title");
$oTemplate->tag("table_track_list","$table_track_list");
$oTemplate->display();

mysql_free_result($result);
mysql_close($conn); 	   ?>

I have quotes in the rong place somewhere. The above script putputs this:

"; }//End While Statment $tracks_by = "Edit Tracks On $cd_title by $artist"; $hidden_input_artist = ""; $hidden_input_cd_title = ""; //include template class include ($home_dir."templates/ultratemplate.php"); $oTemplate = new UltraTemplate(); //template for this script $oTemplate->load($home_dir."templates/admin/edit_tracks.php"); //define template variables $oTemplate->tag("tracks_by","$tracks_by"); $oTemplate->tag("hidden_input_artist","$hidden_input_artist"); $oTemplate->tag("hidden_input_cd_title","$hidden_input_cd_title"); $oTemplate->tag("table_track_list","$table_track_list"); $oTemplate->display(); mysql_free_result($result); mysql_close($conn); ?>

Can anyone spot the problem?

poison

OMFG
no...but just a little tip...
use single quotes for strings literals containing HTML...and double quotes in the HTML ...so you save yourself a lot of escaping and make it a little more readable...i.e.

$test='<table width="363" cellpadding="5" cellspacing="1" ><tr><td>' . $row['track_num'];

move3rd

Thanks,

Think I best re-write it!

move3rd

I re-wrote it but it's still giveing me parse error:

while ($row = mysql_fetch_array($result)) {

  //Create variables for use in template class
$table_track_list = '<table width=\"363\" cellpadding=\"5\" cellspacing=\"1\" ><tr><td>'.$row['track_num'];
$table_track_list .= $row['track_title'].'</td><td><form action=\"edit_track.php\" method=\"POST\">';
$table_track_list .= '<input type=\"hidden\" name=\"track_title\" value=\"'.$row['track_title'].'\">';
$table_track_list .= '<input type=\"hidden\" name=\"track_num\" value=\"'.$row['track_num'].'\">';
$table_track_list .= '<input type=\"hidden\" name=\"artist\" value=\"'.$row['artist'].'\">';
$table_track_list .= '<input type=\"hidden\" name="cd_title\" value=\"'.$row['cd_title'].'\">';
$table_track_list .= '<input name=\"POST\" type=\"submit\" value=\"Edit\"></td></tr></table>';
	                                      }//End While Statment

move3rd

bump

laserlight

while ($row = mysql_fetch_array($result)) {
	//Create variables for use in template class
	$table_track_list = '<table width="363" cellpadding="5" cellspacing="1">'
		. '<tr><td>' . $row['track_num'] . $row['track_title'] . '</td><td>'
		. '<form action="edit_track.php" method="POST">'
		. '<input type="hidden" name="track_title" value="' . $row['track_title'] . '">'
		. '<input type="hidden" name="track_num" value="' . $row['track_num'] . '">'
		. '<input type="hidden" name="artist" value="' . $row['artist'] . '">'
		. '<input type="hidden" name="cd_title" value="' . $row['cd_title'] . '">'
		. '<input name="POST" type="submit" value="Edit">'
		. '</td></tr></table>';
}

But there's a problem: you arent using $table_track_list in the loop.
So you'll only end up with the last row inserted into $table_track_list, unless you turn it into an array instead, e.g.
$table_track_list[] = ...

move3rd

Thanks,

There was also a problem with my template causing parse error! :rolleyes:

It's now working correctly!😃

move3rd

I only had one 'track' in the db. When I added another it only outputed the last row as you said it would.

How can i get round this?

I changed it to this:

while ($row = mysql_fetch_array($result)) { 
    //Create variables for use in template class 
    $table_track_list[] = '<table width="363" cellpadding="5" cellspacing="1">' 
        . '<tr><td>' . $row['track_num'] . ' - ' . $row['track_title'] . '</td><td>' 
        . '<form action="edit_track.php" method="POST">' 
        . '<input type="hidden" name="track_title" value="' . $row['track_title'] . '">' 
        . '<input type="hidden" name="track_num" value="' . $row['track_num'] . '">' 
        . '<input type="hidden" name="artist" value="' . $row['artist'] . '">' 
        . '<input type="hidden" name="cd_title" value="' . $row['cd_title'] . '">' 
        . '<input name="POST" type="submit" value="Edit">' 
        . '</td></tr></table>'; 
}

But it didnt work.

move3rd

It works when I do this:🆒

 $table_track_list ="";							  

while ($row = mysql_fetch_array($result)) { 
    //Create variables for use in template class 
    $table_track_list .= '<table width="363" cellpadding="5" cellspacing="1">' 
        . '<tr><td>' . $row['track_num'] . ' - ' . $row['track_title'] . '</td><td>' 
        . '<form action="edit_track.php" method="POST">' 
        . '<input type="hidden" name="track_title" value="' . $row['track_title'] . '">' 
        . '<input type="hidden" name="track_num" value="' . $row['track_num'] . '">' 
        . '<input type="hidden" name="artist" value="' . $row['artist'] . '">' 
        . '<input type="hidden" name="cd_title" value="' . $row['cd_title'] . '">' 
        . '<input name="POST" type="submit" value="Edit">' 
        . '</td></tr></table>'; 
}

Somone told me about this in a prev thread. I had forgoten all about it! :rolleyes: