Image Upload and Resize

[falieson]

<?php
// Portrait Start
// Portrait Upload Start

$path = "/home/falieson/www/gltest/portraits/";
$upload_file_name = "portrait";

if(copy($portrait,$path.$portrait_name))
{
$image = $path.$portrait_name;
?>
<xmp>
$currentimagesize = getimagesize($image);
</xmp>
<xmp>
$image_width = $currentimagesize[0];
$image_height = $currentimagesize[1];
</xmp>
<?php
if (($image_height &gt; $max) || ($image_width &gt; $max))
{
    if ($image_height &gt; $image_width)
    {
    $sizefactor = (double) ($max / $image_height);
    }
    else
    {
    $sizefactor = (double) ($max / $image_width);
    }
}

$newwidth = (int) ($image_width * $sizefactor);
$newheight = (int) ($image_height * $sizefactor);

$newsize = $newwidth."x".$newheight;
$cmd = "/usr/X11R6/bin/mogrify -resize $newsize "."$path $newname
2&gt;&amp;1";
exec ($cmd, $exec_output, $exec_retval);
if($exec_retval &gt; 0)
{
print "ERROR: exec() error: $exec_output[0]";
}
else
{
print "Image was resized from ".$image_width."x".$image_height." to
$newsize ";
}
echo("Portrait succesfully uploaded");
}
else
{
$image = "{ $path}none.jpg";
echo("Portrait not submitted");
}

// Portrait Upload End

?> 

Parse error: parse error, unexpected ';' 20

This is actually part of a much larger script, it works fine before I added the XMP line to the print of the resized image.

[leatherback]

Not 100% sure, but eerrhh shouldn't:

if (($image_height > $max) || ($image_width > $max))

be:

if (($image_height > $max) || ($image_width > $max))

??

[falieson]

Sounds like an awesome reason, I will try that. I was using this tutorial:

http://www.phpbuilder.com/columns/michael20020712.php3

Now my code looks like this:

<?php
// Portrait Start
// Portrait Upload Start

$path = "/home/falieson/www/gltest/portraits/";
$upload_file_name = "portrait";

if(copy($portrait,$path.$portrait_name)) 
{ 
$image = $path.$portrait_name;
?>
<xmp>
$currentimagesize = getimagesize($image);
</xmp>
<xmp>
$image_width = $currentimagesize[0];
$image_height = $currentimagesize[1];
</xmp>
<?php
if (($image_height > $max) || ($image_width > $max))
{
	if ($image_height > $image_width)
	{
	$sizefactor = (double) ($max / $image_height);
	}
	else
	{
	$sizefactor = (double) ($max / $image_width);
	}
}

$newwidth = (int) ($image_width * $sizefactor);
$newheight = (int) ($image_height * $sizefactor);

$newsize = $newwidth."x".$newheight;
$cmd = "/usr/X11R6/bin/mogrify -resize $newsize "."$path $newname 2&gt;&amp;1";
exec ($cmd, $exec_output, $exec_retval);
if($exec_retval > 0)
{
print "ERROR: exec() error: $exec_output[0]";
}
else
{
print "Image was resized from ".$image_width."x".$image_height." to $newsize ";
}
 echo("Portrait succesfully uploaded");
 }
 else
 {
 $image = "{ $path}none.jpg";
 echo("Portrait not submitted");
 }

// Portrait Upload End

?>

The Problem is now this is what thats seen:
$currentimagesize = getimagesize($image);
$image_width = $currentimagesize[0];
$image_height = $currentimagesize[1];
ERROR: exec() error: Portrait succesfully uploaded

so.. I take it that the xmp tags aren't um.. working? xmp shouldn't be inside of php tags right? I have never used xmp before.

[leatherback]

Hi,

I have no clue as to what XMP is, or why you use it here. In the resize script I wrote, I just use the width/height from image size function

function CreateThumb($fit_size, $picture, $input_path, $cdnr)

{

  $quality = 100;
  $fullPath = $input_path.'\\'.$picture; 
    if ( !file_exists ( $fullPath ))
      {
      die("File doesn't exist!");
      }
  $outputpath = "c:";
  $outfile = $outputpath.'\\cd'.$cdnr.'_'.$picture;
  $inputpath = "";
echo $outfile;
  $size = getimagesize($fullPath);
  $height = $size[1];
  $width = $size[0];
 // echo $height;
 // echo '<br>';
 // echo $width;

   //save thumbnail
   if($height > $width)
     {
     $newY = $fit_size;
     $newX = $width / $height * $newY;
     $newX = round( $newX );
     }
   else
     {
     $newX = $fit_size;
     $newY = $height / $width * $newX;
     $newY = round( $newY );
     }

// ----------------------------------------


    $size =  getimagesize($cfile2);
    if (($size[1] > 130) && ($size[1] < 1000)) 
      {
      CreateThumb(100, $file2, $Ndir, $cd);
      }

[Weedpacket]

Originally posted by leatherback
I have no clue as to what XMP is, or why you use it here.

The <xmp> tag was deprecated in favour of <pre> in the HTML 2.0 standard back in 1995. Certainly, if you want the code in them to work, you want <?php and ?>, not <xmp> and </xmp> (descriptions of how to embed PHP code into HTML pages can be found in the manual. I don't know why the author of that article on ImageMagick used <xmp>; maybe it's a typo.